From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30517-done@debbugs.gnu.org
Subject: bug#30517: [PATCH] gnu: milkytracker: Actually link with the JACK library.
Date: Thu, 08 Mar 2018 10:11:55 -0500 [thread overview]
Message-ID: <874llqlhz8.fsf@posteo.net> (raw)
In-Reply-To: <87y3j4rq8u.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 07 Mar 2018 14:04:33 +0100")
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
>> flag.
>> ---
>> gnu/packages/music.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 3709f10d1..e88c9f21f 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>> (("add_subdirectory\\(resources/music\\)") ""))))))
>> (build-system cmake-build-system)
>> (arguments
>> - '(#:tests? #f)) ; no check target
>> + '(#:tests? #f ; no check target
>> + #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
>
> I’d suggest adding a comment as to why this is needed.
>
> Then I think you can go ahead and push it. If it fixes a use case for
> you, that’s already an improvement.
>
> Thanks,
> Ludo’.
Pushed with added comment. Thanks for reviewing!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-03-08 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 19:50 [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library Kei Kebreau
2018-02-18 20:22 ` Kei Kebreau
2018-03-07 13:04 ` Ludovic Courtès
2018-03-08 15:11 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874llqlhz8.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=30517-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.