From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#31088: Use '@' as version number separator in guix output Date: Tue, 01 May 2018 23:04:37 +0200 Message-ID: <874ljrnl3u.fsf@gnu.org> References: <871sfr2bsg.fsf@gmail.com> <87k1tf5zxy.fsf@gmail.com> <877epegxsc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDcSP-00052d-O2 for bug-guix@gnu.org; Tue, 01 May 2018 17:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDcSN-0005gy-33 for bug-guix@gnu.org; Tue, 01 May 2018 17:05:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDcSM-0005gl-Vt for bug-guix@gnu.org; Tue, 01 May 2018 17:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDcSL-0000fH-RZ for bug-guix@gnu.org; Tue, 01 May 2018 17:05:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <877epegxsc.fsf@gmail.com> (Chris Marusich's message of "Tue, 10 Apr 2018 21:41:23 -0700") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Chris Marusich Cc: Mathieu Lirzin , Pierre Neidhardt , 31088@debbugs.gnu.org Hello Chris, Thanks for digging into this. Chris Marusich skribis: > From 67165c95ff9b52b7ae34d7c07778138548013ccd Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Sun, 8 Apr 2018 16:51:42 -0700 > Subject: [PATCH] guix: Separate the package name and version with "@", not > "-". > > * guix/packages.scm (package-full-name): By default, use "@" to separate > the package name and package version. Add #:delimiter keyword > argument so that there is still a way to explicitly use a different > delimiter. > * gnu/packages/commencement.scm (gcc-boot0) : Adjust > accordingly. > * tests/graph.scm: Adjust accordingly. > * tests/profiles.scm: Adjust accordingly. > * NEWS: Mention the change. > > Fixes: . > Reported by Pierre Neidhardt . [...] > diff --git a/NEWS b/NEWS > index 2c898e65f..9769bfc87 100644 > --- a/NEWS > +++ b/NEWS > @@ -777,6 +777,7 @@ zynaddsubfx@3.0.2 >=20=20 > ** Programming interfaces >=20=20 > +*** package-full-name (guix packages) now uses "@" instead of "-" as its= delimiter. This is under =E2=80=9CChanges in 0.14.0 (since 0.13.0)=E2=80=9D, which is = probably not what you want. :-) > +(define* (package-full-name package #:key (delimiter "@")) > + "Return the full name of PACKAGE--i.e., `NAME@VERSION'. By specifying > +DELIMITER (a string), you can customize what will appear between the nam= e and > +the version. By default, DELIMITER is \"@\"." I=E2=80=99d prefer #:optional instead of #:key, it=E2=80=99d be less verbos= e. Other than that, please make sure =E2=80=9Cmake check=E2=80=9D passes, and = make sure this doesn=E2=80=99t trigger a full rebuild (from the patch it looks you al= ready checked both of these, but who knows ;-)). OK with this. Thank you! Ludo=E2=80=99.