From: Marius Bakke <mbakke@fastmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf.
Date: Mon, 02 Jul 2018 20:28:28 +0200 [thread overview]
Message-ID: <874lhhwkz7.fsf@fastmail.com> (raw)
In-Reply-To: <8736x1r1g0.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]
Mark H Weaver <mhw@netris.org> writes:
> Hi Marius,
>
> mbakke@fastmail.com (Marius Bakke) writes:
>
>> mbakke pushed a commit to branch staging
>> in repository guix.
>>
>> commit cb4b508cd68df89bfbd5255a0c5569f8318ad50f
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date: Mon Jul 2 12:07:58 2018 +0200
>>
>> build-system/meson: Really skip the 'fix-runpath' phase on armhf.
>>
>> This follows up commit d5b5a15a4046362377f1a45d466b43bb6e93d4f which doesn't
>> work because %current-system etc expands before the actual build.
>
> I'm disappointed by this workaround that simply removes the
> 'fix-runpath' phase on armhf. Is that phase needed, or is it truly
> optional? What does the phase accomplish, and how will armhf users be
> disadvantaged by the removal of that phase?
I'm sorry, I forgot to address your actual concerns. The (buggy)
workaround was put in place and discussed in
<https://bugs.gnu.org/30761>. The meat of it can be found in (guix
build-system meson):
;; XXX PatchELF fails to build on armhf, so we skip
;; the 'fix-runpath' phase there for now. It is used
;; to avoid superfluous entries in RUNPATH as described
;; in <https://bugs.gnu.org/28444#46>, so armhf may now
;; have different runtime dependencies from other arches.
Now, I'm not proud of this "workaround", but it's not exactly new, so I
don't see why we should rush to fix it now. Given how late we are in
this staging cycle, I would prefer delaying any proper fix until the
next round.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-07-02 18:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180702101757.22792.51026@vcs0.savannah.gnu.org>
[not found] ` <20180702101758.97A6020543@vcs0.savannah.gnu.org>
2018-07-02 17:29 ` 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf Mark H Weaver
2018-07-02 18:06 ` Marius Bakke
2018-07-03 19:20 ` Mark H Weaver
2018-07-04 7:21 ` Ludovic Courtès
2018-07-04 19:55 ` RFC: Portability should be a higher priority for Guix (was Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf.) Mark H Weaver
2018-07-04 22:32 ` Kei Kebreau
2018-07-05 8:39 ` Ludovic Courtès
2018-07-05 14:15 ` Kei Kebreau
2018-07-05 9:04 ` Jonathan Brielmaier
2018-07-05 19:40 ` Andreas Enge
2018-07-05 6:38 ` Ricardo Wurmus
2018-07-05 8:46 ` Ludovic Courtès
2018-07-05 9:52 ` Andreas Enge
2018-07-05 8:50 ` Ludovic Courtès
2018-07-05 9:01 ` Ludovic Courtès
2018-07-02 18:28 ` Marius Bakke [this message]
2018-07-03 19:24 ` 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf Mark H Weaver
2018-07-04 7:27 ` Ludovic Courtès
2018-07-04 14:27 ` Marius Bakke
2018-07-03 21:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lhhwkz7.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.