From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVXP-0001fr-48
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:45:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVXL-0006C0-6D
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:45:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43921)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fcVXL-0006BR-2d
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:45:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcVXK-00038S-ND
	for guix-patches@gnu.org; Mon, 09 Jul 2018 08:45:02 -0400
Subject: [bug#31736] [PATCH] Add an opam importer
Resent-Message-ID: <handler.31736.B31736.153114027311999@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180606192329.255ade5e@lepiller.eu>
	<20180606193740.44bef2ea@lepiller.eu> <871sdecow5.fsf@gnu.org>
	<84c7511b174300afe05f4a2f7ca8bad6@lepiller.eu>
Date: Mon, 09 Jul 2018 14:44:20 +0200
In-Reply-To: <84c7511b174300afe05f4a2f7ca8bad6@lepiller.eu> (Julien Lepiller's
	message of "Sat, 07 Jul 2018 23:56:08 +0200")
Message-ID: <874lh8h93v.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31736@debbugs.gnu.org

Hello Julien,

Julien Lepiller <julien@lepiller.eu> skribis:

> Here is a new version. What do you think?

I think it looks great.  :-)

> From b3fd75a804a4264cb083584591a3e589886d96c8 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Wed, 6 Jun 2018 19:14:39 +0200
> Subject: [PATCH] guix: Add opam importer.
>
> * guix/scripts/import.scm (importers): Add opam.
> * guix/scripts/import/opam.scm: New file.
> * guix/import/opam.scm: New file.
> * tests/opam.scm: New file.
> * Makefile.am: Add them.
> * doc/guix.texi (Invoking guix import): Document it.

[...]

> +@item opam
> +@cindex opam
> +@cindex ocaml
> +Import metadata from the @uref{https://opam.ocaml.org/, Opam} package
> +repository used by the OCaml community.

Nitpick: the proper spelling is =E2=80=9COPAM=E2=80=9D and =E2=80=9COCaml=
=E2=80=9D, so I think you need
to fix these above (in the concept index as well.)

Otherwise LGTM!

As a next step, you can add an OPAM updater, which will hopefully take
you no more than a few lines of code (see the bottom of cpam.scm, for
example.)

:-)

Thank you!

Ludo=E2=80=99.