From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaRcU-0000en-6c for guix-patches@gnu.org; Fri, 21 Dec 2018 15:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaRcQ-0002RK-8M for guix-patches@gnu.org; Fri, 21 Dec 2018 15:42:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaRcQ-0002R6-5M for guix-patches@gnu.org; Fri, 21 Dec 2018 15:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gaRcQ-0008BZ-1W for guix-patches@gnu.org; Fri, 21 Dec 2018 15:42:02 -0500 Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87k1k2olth.fsf@gnu.org> References: <20181216040528.29880-1-bandali@gnu.org> <87bm5lv6tj.fsf@gnu.org> <20181217072921.GG3468@macbook41> <87efag6x3w.fsf@aminb.org> <87k1k2olth.fsf@gnu.org> Date: Fri, 21 Dec 2018 21:40:47 +0100 Message-ID: <874lb6aa0g.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Amin Bandali Cc: 33764@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello! > > Amin Bandali skribis: > >> On 2018-12-17 9:29 AM, Efraim Flashner wrote: >>> On Sun, Dec 16, 2018 at 04:18:16PM +0100, Ludovic Court=C3=A8s wrote: > > [...] > >>>> > +(define-public python2-z3 >>>> > + (package (inherit python-z3) >>>>=20 >>>> This definition cannot be in python.scm; it must be in the same file as >>>> =E2=80=98z3=E2=80=99 or we can get =E2=80=9Cunbound variable=E2=80=9D = errors while loading either of >>>> these two modules. >> >> Oh I see. If we choose to keep it (add it), I=E2=80=99ll move it to mat= hs.scm. >> >>>> Also, as we=E2=80=99re approaching end-of-life upstream for Python 2.x= , we now >>>> avoid creating =E2=80=9Cpython2-=E2=80=9D packages, unless we cannot a= void it for some >>>> reason. Do you think we could do without this =E2=80=9Cpython2-z3=E2= =80=9D package? >>>>=20 >>> >>> Currently our z3 package builds python2 bindings >> >> What Efraim said. Since the current z3 provides python2 bindings, I >> thought I would preserve that option by adding a python2-z3 in case >> anyone wants to continue to use the python2 bindings. >> >> I=E2=80=99m Cc=E2=80=99ing Marius who=E2=80=99s one of the recent commit= ters to the z3 package >> definition. Marius, any thoughts on whether we should keep the python2 >> bindings around or do away with them? > > Marius, WDYT? Hello! I don't actually know z3 at all, I just updated it to fix the build on core-updates :-) In any case dropping python2 bindings seems sensible, seeing as Python 2 is EOL in a year[1]. So please go ahead, thank you Amin! [1]: https://www.python.org/dev/peps/pep-0373/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlwdT88ACgkQoqBt8qM6 VPrw4Qf+O5a19rZwuURvfrI2jJ+Ncn/xi8cRywuv+++sPWMp3gC1Ult2QxXDao+T ttupksN2uERD2KKj//+MfQUcE3bRPJuqU5hsoitN/ca/br7903AKmeXJUwLf6PbG BY4gIQRdMpvlyE3I0Ex4JZJLz5VIjeuYmSeBjy2l4UAoil1N5W9LjKh3aZ8LkA6T YVIrtXOPvpSxOBXLE0MMmZjnPWFuavrobDfYl4MCaSfX8fceGTlDBKTYFrsbuK+d VKEHOtHDdO2xeTCWfQ9rGrN1nsuqvSztnB49z9rpEvd2hbCFgiPXBou8t/ywL1Jy Amn9StJp3qa6a8Eoy3vUpRldDwDguQ== =dzxn -----END PGP SIGNATURE----- --=-=-=--