From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in master? Date: Sat, 12 Jan 2019 20:25:52 +0100 Message-ID: <874ladwudb.fsf@gmail.com> References: <87lg6sejwa.fsf@gmail.com> <878t1rygfu.fsf@gmail.com> <877ehbydmz.fsf@gmail.com> <87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com> <87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com> <87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com> <87lg5j6h00.fsf@gnu.org> <87pnuv26jv.fsf@gmail.com> <87efbb4xpt.fsf@gnu.org> <871s7bm8k5.fsf@gmail.com> <8736rl6049.fsf@gmail.com> <874lc15opg.fsf@gnu.org> <87r2f4smlk.fsf@gmail.com> <8736rk6ui1.fsf@gnu.org> <87d0qgt8ej.fsf@gmail.com> <871s5q1zyv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:34011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giPA6-0007un-2u for guix-devel@gnu.org; Sat, 12 Jan 2019 14:41:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giOur-0007sh-JM for guix-devel@gnu.org; Sat, 12 Jan 2019 14:25:58 -0500 In-reply-to: <871s5q1zyv.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel Hey Ludo! Thanks for your review. My comments below. > =E2=80=A2 On the first screen, should =E2=80=9CGraphical install=E2=80= =9D come first? Done in 0cc05606ddae0ec0bf6244418571ffc1478eeb9. > > =E2=80=A2 Should the choice of a locale come before the welcome screen? I'm not sure about this one. I prefer to welcome the user and expose available options directly, instead of diving directly into locale selection. > =E2=80=A2 Should the keyboard layout default to =E2=80=9CEnglish (US)= =E2=80=9D rather than > =E2=80=9CAfghani=E2=80=9D? Likewise for the layout variant. Sure, done in e4be764186be7638d7d4bf0a94998d1e4fd694d4. > > =E2=80=A2 s/Ok/OK/ :-) Done in 23d30dcad7baaeaa0fd4a7835e69137bc3c8dfb2. > > =E2=80=A2 For the partition encryption passphrase, we should probably a= sk for > confirmation, no? Done in 86f86f5a8029cd4d00360d6251891486f0eca5ed. > > =E2=80=A2 There=E2=80=99s a debug dialog box called =E2=80=9Cuser-parti= tions=E2=80=9D that pops up > after hitting =E2=80=9COk=E2=80=9D on the partition choice. :-) Removed in d1b52bdb6fb270bc5dbad54c165e781888114276. > > =E2=80=A2 In the =E2=80=9CDesktop environments=E2=80=9D screen, we shou= ld we allow for no > desktop environments, and then (or before?) have a second screen > where users can choose between a headless server kind of install or > a lightweight-X11-desktop kind of install? Seems like a good idea, I add it to my todo list :) > > =E2=80=A2 At the end, after seeing the complete OS definition, I got = =E2=80=9Cexeclp: > cryptsetup: Operation not permitted=E2=80=9D written at the top of the > =E2=80=9CCongratulations=E2=80=9D screen, and it looks like nothing w= as actually > installed (I had chosen the encrypted-root setup). After that I > got: > > ERROR: pty: failed to exec child /gnu/store/=E2=80=A6-installer: Op= eration not permitted (exec_child() in src/pty.c:299) > > in a loop and the VM became unusable. Not sure what happened! Hmm at least I can reproduce this issue, not sure what's happening. This error does not happend when creating a disk-image and running qemu manually. I'll try to investigate it soon. > > So what are the next steps? IMO we should consider merging real soon > and get people to test. WDYT? Sure, it would be great to merge this branch, so that we can move forward, and hopefully have everything ready for 1.0 release. Anyway, I plan to give a short talk about this installer and its future at fosdem. Sorry for my late answer, Mathieu