From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:38392)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vI8-0005oP-R7
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:27:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4v3a-0005UY-PA
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:12:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60262)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h4v3a-0005UK-Fz
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:12:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4v3a-0004fh-5i
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:12:02 -0400
Subject: [bug#34811] Make package name regexes case-insensitive
Resent-Message-ID: <handler.34811.B34811.155268788217896@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87ftrther0.fsf@nckx>
Date: Fri, 15 Mar 2019 23:11:11 +0100
In-Reply-To: <87ftrther0.fsf@nckx> (Tobias Geerinckx-Rice's message of "Mon,
	11 Mar 2019 11:44:35 +0100")
Message-ID: <874l833i0w.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
Cc: 34811@debbugs.gnu.org

Hello!

Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
skribis:

> I think they should.
>
> All of our package names are lower case, and it doesn't add value that
>
>  $ guix package -A ExifTool
>
> matches zero, zip, zilch, nada, nothing, while
>
>  $ guix package -A exiftool
>  perl-image-exiftool	11.11	out gnu/packages/photo.scm:208:2
>
> does.

Indeed.

>>>From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001
> From: Tobias Geerinckx-Rice <me@tobias.gr>
> Date: Mon, 11 Mar 2019 11:37:11 +0100
> Subject: [PATCH] ui: Match package names case-insensitively.
>
> * guix/ui.scm (make-package-name-regexp): New variable.
> * guix/scripts/package.scm (options->upgrade-predicate, process-query):
> Use it.

[...]

> -                   (make-regexp* (or regexp "")))
> +                   (make-package-name-regexp (or regexp "")))

I don=E2=80=99t think the abstraction brings much here; I=E2=80=99d prefer
=E2=80=98regexp/icase=E2=80=99 to be inlined.  WDYT?

Otherwise LGTM, thanks!

Ludo=E2=80=99.