From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:56186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8YcT-00061K-Ua
	for guix-patches@gnu.org; Mon, 25 Mar 2019 19:03:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8YcS-0007q8-Uu
	for guix-patches@gnu.org; Mon, 25 Mar 2019 19:03:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45245)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h8YcQ-0007pl-Tb
	for guix-patches@gnu.org; Mon, 25 Mar 2019 19:03:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8YcQ-0004vG-Pe
	for guix-patches@gnu.org; Mon, 25 Mar 2019 19:03:02 -0400
Subject: bug#34948: [PATCH 3/3] system: Add 'essential-services' field to
	<operating-system>.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.34948.D34948.155355496218888.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190322172719.11199-1-ludo@gnu.org>
	<20190322172719.11199-3-ludo@gnu.org>
	<cu7bm1ywurx.fsf@systemreboot.net>
Date: Tue, 26 Mar 2019 00:02:31 +0100
In-Reply-To: <cu7bm1ywurx.fsf@systemreboot.net> (Arun Isaac's message of "Tue,
	26 Mar 2019 02:12:26 +0530")
Message-ID: <874l7qv9q0.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 34948-done@debbugs.gnu.org

Hi Arun!

Arun Isaac <arunisaac@systemreboot.net> skribis:

> This neatly gets rid of all the #:container? arguments. That's very
> nice! :-) I haven't actually built and tested these patches, but these
> LGTM. Just one minor observation below.
>
>> +  (cons (service system-service-type
>> +                 (let ((locale (operating-system-locale-directory os)))
>> +                   (with-monad %store-monad
>> +                     (return `(("locale" ,locale))))))
>> +        (append base (list %containerized-shepherd-service))))
>
> Why not rewrite this using just a call to append, that is remove the
> call to cons? Like so:

No, IIRC =E2=80=98system-service-type=E2=80=99 should be the first in the l=
ist (?), but
also I find it more pleasant to the eye than an unbalanced =E2=80=98append=
=E2=80=99
call.  :-)

Thanks for your feedback, I=E2=80=99ve pushed it now:

  69cae3d335 system: Add 'essential-services' field to <operating-system>.
  cf848cc0a1 accounts: Add default value for the 'home-directory' field of =
<user-account>.
  abd4d6b33d records: Allow thunked fields to refer to 'this-record'.

I hope that=E2=80=99ll help address your container use case!

Ludo=E2=80=99.