From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:59193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hW5qg-0002st-Py
	for guix-patches@gnu.org; Wed, 29 May 2019 17:11:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hW5qf-0007gf-SL
	for guix-patches@gnu.org; Wed, 29 May 2019 17:11:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46540)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hW5qf-0007gX-Ou
	for guix-patches@gnu.org; Wed, 29 May 2019 17:11:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hW5qf-0002sh-Jb
	for guix-patches@gnu.org; Wed, 29 May 2019 17:11:01 -0400
Subject: [bug#35922] [PATCH] gnu: add terminator
Resent-Message-ID: <handler.35922.B35922.155916421111007@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190527074613.25582-1-atai@atai.org>
Date: Wed, 29 May 2019 23:10:01 +0200
In-Reply-To: <20190527074613.25582-1-atai@atai.org> (atai@atai.org's message
	of "Mon, 27 May 2019 00:46:13 -0700")
Message-ID: <874l5dt1au.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: atai@atai.org
Cc: 35922@debbugs.gnu.org

Hello,

atai@atai.org skribis:

> From: Andy Tai <atai@atai.org>
>
> * gnu/packages/gnome.scm (terminator): Add at 1.91

[...]

> +    (arguments
> +     `(#:python ,python-2))

Python 2.x is reaching EOL real soon.  Can it run on Python 3?

> +    (description
> +     "A tool to allow running multiple GNOME terminals in a grid and
> +     tabs and support for drag and drop re-ordering of terminals")

Could you make a full sentence and remove the trailing spaces?  See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descrip=
tions.html>.

> +    (license license:gpl2)))

This means =E2=80=9Cversion 2 only=E2=80=9D.  Is there an explicit =E2=80=
=9Cversion 2 only=E2=80=9D
statement, for example in source file headers?  If not, it should be
=E2=80=98gpl2+=E2=80=99.

Could you send an updated patch?

Thank you,
Ludo=E2=80=99.