all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: atai@atai.org
Cc: 35922@debbugs.gnu.org
Subject: [bug#35922] [PATCH] gnu: add terminator
Date: Wed, 29 May 2019 23:10:01 +0200	[thread overview]
Message-ID: <874l5dt1au.fsf@gnu.org> (raw)
In-Reply-To: <20190527074613.25582-1-atai@atai.org> (atai@atai.org's message of "Mon, 27 May 2019 00:46:13 -0700")

Hello,

atai@atai.org skribis:

> From: Andy Tai <atai@atai.org>
>
> * gnu/packages/gnome.scm (terminator): Add at 1.91

[...]

> +    (arguments
> +     `(#:python ,python-2))

Python 2.x is reaching EOL real soon.  Can it run on Python 3?

> +    (description
> +     "A tool to allow running multiple GNOME terminals in a grid and
> +     tabs and support for drag and drop re-ordering of terminals")

Could you make a full sentence and remove the trailing spaces?  See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

> +    (license license:gpl2)))

This means “version 2 only”.  Is there an explicit “version 2 only”
statement, for example in source file headers?  If not, it should be
‘gpl2+’.

Could you send an updated patch?

Thank you,
Ludo’.

  reply	other threads:[~2019-05-29 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  7:46 [bug#35922] [PATCH] gnu: add terminator atai
2019-05-29 21:10 ` Ludovic Courtès [this message]
2019-05-30  5:58   ` Andy Tai
2019-05-30  9:54   ` Ricardo Wurmus
2019-05-31  4:58     ` Andy Tai
2019-05-31  7:52       ` Ricardo Wurmus
2019-05-31 15:44         ` Andy Tai
2019-05-30  6:02 ` atai
2019-06-01 12:48   ` Ludovic Courtès
2019-06-01 17:42     ` Andy Tai
2019-06-01 17:41 ` atai
2019-06-01 21:56   ` bug#35922: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l5dt1au.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35922@debbugs.gnu.org \
    --cc=atai@atai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.