From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAkLf-0006Dx-Ae for guix-patches@gnu.org; Wed, 18 Sep 2019 20:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAkLe-000212-B2 for guix-patches@gnu.org; Wed, 18 Sep 2019 20:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAkLe-00020t-8Q for guix-patches@gnu.org; Wed, 18 Sep 2019 20:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iAkLe-0005MA-2C for guix-patches@gnu.org; Wed, 18 Sep 2019 20:31:02 -0400 Subject: [bug#37346] [PATCH] Move diffoscope from package-management to it's own module. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: <87d0fxwlav.fsf@yucca> References: <87ftl6cqfc.fsf@yucca> <20190911014625.529c1738@scratchpost.org> <87d0fxwlav.fsf@yucca> Date: Wed, 18 Sep 2019 17:30:35 -0700 Message-ID: <874l19w2j8.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 37346@debbugs.gnu.org --=-=-= Content-Type: text/plain On 2019-09-18, Vagrant Cascadian wrote: > On 2019-09-11, Danny Milosavljevic wrote: >> On Sun, 08 Sep 2019 16:35:19 -0700 >> Vagrant Cascadian wrote: >> >>> I was having infinite recursion issues importing additional modules such >>> as android.scm, bootloaders.scm and statistics.scm into >>> package-management.scm >> >> Yeah, I hate import cycles. >> >> I've pushed your patches to guix master. > > They don't seem to be in master as of commit: > > cf48ea9539020bd6300033a8910ca951225582e6 > > I don't see any reverts, so curious what happened? I went ahead and (re?)pushed it, dropping the use-modules bits based on ludo's review. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXYLMLAAKCRDcUY/If5cW quhQAPwJTRsjznxfzxDnQPt/yhq5uKKZKZvlF1yt1Hgcdyp7tQD/bOv/Un16pqA1 QFRWRouGfNOOAK7QYZpsRRNw8TlccgY= =onoa -----END PGP SIGNATURE----- --=-=-=--