From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 37994@debbugs.gnu.org
Subject: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep".
Date: Wed, 30 Oct 2019 18:15:47 +0100 [thread overview]
Message-ID: <874kzqw3wc.fsf@nckx> (raw)
In-Reply-To: <20191030161913.17691-1-mail@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
Pierre,
Pierre Neidhardt 写道：
> * gnu/packages/version-control.scm (git)[inputs]: Add pcre2.
> [arguments]: Add "USE_LIBPCRE2" to make-flags.
> (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in
> make-flags.
What do you think of removing pcre2 from INPUTS as well?
I'm a bit worried that upstream will grow auto-detection and/or
change the default value of USE_LIBPCRE2 one day, and that would
go unnoticed.
> + ;; For PCRE support in git grep (USE_LIBPCRE2)
Missing ‘.’.
Otherwise GTM!
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-10-30 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:19 [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep" Pierre Neidhardt
2019-10-30 17:15 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2019-10-30 19:53 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kzqw3wc.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=37994@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.