From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34571) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfQ8-0007DG-TR for guix-patches@gnu.org; Fri, 15 Nov 2019 12:30:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVfQ5-0002kZ-W3 for guix-patches@gnu.org; Fri, 15 Nov 2019 12:30:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56734) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVfQ5-0002jm-Kh for guix-patches@gnu.org; Fri, 15 Nov 2019 12:30:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVfQ2-0002T6-Jq for guix-patches@gnu.org; Fri, 15 Nov 2019 12:30:05 -0500 Subject: [bug#38208] [PATCH] gnu: Add python-3.8. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20191114084453.27042-1-tanguy@bioneland.org> References: <20191114084453.27042-1-tanguy@bioneland.org> Date: Fri, 15 Nov 2019 18:28:56 +0100 Message-ID: <874kz5giav.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tanguy Le Carrour , 38208@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Tanguy, Tanguy Le Carrour writes: > * gnu/packages/python.scm (python-3.8):=C2=A0New public variable. > [source]: Add patches to skip four tests. > * gnu/packages/patches/python-3.8-search-paths.patch: New file. > * gnu/packages/patches/python-3.8-fix-tests.patch: New file. Thank you for this! > ++ @unittest.skipIf(True, "This fails for unknown reasons on Guix") > + def test_keyboard_interrupt_exit_code(self): > + """KeyboardInterrupt triggers exit via SIGINT.""" > + process =3D subprocess.run( I'm fairly confident that these failures are because stdin is not a TTY. Can you try changing to this? @unittest.skipUnless(sys.stdin.isatty(), "KeyboardInterrupts require a TTY = device") It would be good to submit a patch along these lines upstream if that works. > +(define-public python-3.8 > + (package > + (inherit python-3.7) > + (version "3.8.0") > + (source > + (origin > + (inherit (package-source python-3.7)) > + (uri (string-append "https://www.python.org/ftp/python/" > + version "/Python-" version ".tar.xz")) > + (sha256 (base32 "110d0did9rxn7rg85kf2fwli5hqq44xv2d8bi7d92m7v2d72= 8mmk")) > + (patches (search-patches > + "python-3.8-search-paths.patch" > + "python-3-fix-tests.patch" > + "python-3.8-fix-tests.patch" > + "python-3-deterministic-build-info.patch")) > + (snippet > + '(begin > + ;; Delete the bundled copy of libexpat. > + (delete-file-recursively "Modules/expat") > + (substitute* "Modules/Setup" > + ;; Link Expat instead of embedding the bundled one. > + (("^#pyexpat.*") "pyexpat pyexpat.c -lexpat\n")) > + #t)))))) One final question... Do you know how stable the Python ABI is? Are packages compiled with 3.7 guaranteed to work with 3.8? I wonder if we should 1) rename it to 'python-next', and 2) override 'native-search-paths' so that it searches 'lib/python3.8/site-packages'. My concern is that e.g. 'guix environment --ad-hoc python python-numpy' might stop working unless we rename it, and/or adjust search paths. If Python 3.8 is fully backwards compatible, we probably don't have to do anything, otherwise we should adjust accordingly. Thoughts? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3O4FgACgkQoqBt8qM6 VPrRdQf+IG+0KgVmDy3YE1wSsOIoN4bH/V14uwvNzK9TA247wtZzZZ6TPY/4CUli dfX+zDCHoZUZmazRBSmq84VgHUA8snRUz4jKFlYf8uWXPfo4OnhWxFXVmnCHHh4s UaNv7oFztjTxqnk8EjKavjbwFfUFm2M3cCsjTbUdGzFlJVprbtAnkaqaPzGoX8xC LYeFvsXltxtPoDYS2z0QzzRU6GuU/wd6DUN2g7c2ZgUCoEMv2kA4eHa/VXIJUD6h GpEnh6D0xo5hQ3mhChDd0LvX3p312I8e/5SFtP+kT7Ln0x7IdyxXND8DfpJ2dAjg +omvWLLkXNy6Y9PGD/XC6crfT5aJoA== =weol -----END PGP SIGNATURE----- --=-=-=--