From: Marius Bakke <mbakke@fastmail.com>
To: Tanguy Le Carrour <tanguy@bioneland.org>, 38208@debbugs.gnu.org
Subject: [bug#38208] [PATCH] gnu: Add python-3.8.
Date: Fri, 15 Nov 2019 18:28:56 +0100 [thread overview]
Message-ID: <874kz5giav.fsf@devup.no> (raw)
In-Reply-To: <20191114084453.27042-1-tanguy@bioneland.org>
[-- Attachment #1: Type: text/plain, Size: 2415 bytes --]
Hello Tanguy,
Tanguy Le Carrour <tanguy@bioneland.org> writes:
> * gnu/packages/python.scm (python-3.8): New public variable.
> [source]: Add patches to skip four tests.
> * gnu/packages/patches/python-3.8-search-paths.patch: New file.
> * gnu/packages/patches/python-3.8-fix-tests.patch: New file.
Thank you for this!
> ++ @unittest.skipIf(True, "This fails for unknown reasons on Guix")
> + def test_keyboard_interrupt_exit_code(self):
> + """KeyboardInterrupt triggers exit via SIGINT."""
> + process = subprocess.run(
I'm fairly confident that these failures are because stdin is not a
TTY. Can you try changing to this?
@unittest.skipUnless(sys.stdin.isatty(), "KeyboardInterrupts require a TTY device")
It would be good to submit a patch along these lines upstream if that
works.
> +(define-public python-3.8
> + (package
> + (inherit python-3.7)
> + (version "3.8.0")
> + (source
> + (origin
> + (inherit (package-source python-3.7))
> + (uri (string-append "https://www.python.org/ftp/python/"
> + version "/Python-" version ".tar.xz"))
> + (sha256 (base32 "110d0did9rxn7rg85kf2fwli5hqq44xv2d8bi7d92m7v2d728mmk"))
> + (patches (search-patches
> + "python-3.8-search-paths.patch"
> + "python-3-fix-tests.patch"
> + "python-3.8-fix-tests.patch"
> + "python-3-deterministic-build-info.patch"))
> + (snippet
> + '(begin
> + ;; Delete the bundled copy of libexpat.
> + (delete-file-recursively "Modules/expat")
> + (substitute* "Modules/Setup"
> + ;; Link Expat instead of embedding the bundled one.
> + (("^#pyexpat.*") "pyexpat pyexpat.c -lexpat\n"))
> + #t))))))
One final question... Do you know how stable the Python ABI is? Are
packages compiled with 3.7 guaranteed to work with 3.8?
I wonder if we should 1) rename it to 'python-next', and 2) override
'native-search-paths' so that it searches 'lib/python3.8/site-packages'.
My concern is that e.g. 'guix environment --ad-hoc python python-numpy'
might stop working unless we rename it, and/or adjust search paths.
If Python 3.8 is fully backwards compatible, we probably don't have to
do anything, otherwise we should adjust accordingly.
Thoughts?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-11-15 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:44 [bug#38208] [PATCH] gnu: Add python-3.8 Tanguy Le Carrour
2019-11-15 17:28 ` Marius Bakke [this message]
2019-11-19 8:26 ` Tanguy Le Carrour
2019-11-19 20:51 ` Marius Bakke
2019-11-19 8:50 ` [bug#38208] [PATCH v2] " Tanguy Le Carrour
2019-11-19 20:54 ` bug#38208: " Marius Bakke
[not found] ` <handler.38208.B.157372113024712.ack@debbugs.gnu.org>
2019-11-19 10:33 ` [bug#38208] Acknowledgement ([PATCH] gnu: Add python-3.8.) Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kz5giav.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=38208@debbugs.gnu.org \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.