From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45609)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ioxrP-00054Q-Jd
 for guix-patches@gnu.org; Tue, 07 Jan 2020 18:02:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ioxrO-0000Rk-J5
 for guix-patches@gnu.org; Tue, 07 Jan 2020 18:02:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:43580)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ioxrO-0000RS-Fo
 for guix-patches@gnu.org; Tue, 07 Jan 2020 18:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ioxrO-0000tZ-D3
 for guix-patches@gnu.org; Tue, 07 Jan 2020 18:02:02 -0500
Subject: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading
Resent-Message-ID: <handler.38576.B38576.15784380993397@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191212074613.GA11713@zpidnp36> <87wob13mpn.fsf@elephly.net>
 <20191212100452.GE22717@zpidnp36> <87r210j5kq.fsf@gnu.org>
 <20200102073536.GA3066@zpidnp36> <87h81ew0aw.fsf@gnu.org>
 <edd8dcb27c53f00df6f1305240f2bf3a564e5765.camel@gnu.org>
Date: Wed, 08 Jan 2020 00:01:26 +0100
In-Reply-To: <edd8dcb27c53f00df6f1305240f2bf3a564e5765.camel@gnu.org> (Roel
 Janssen's message of "Tue, 07 Jan 2020 22:02:13 +0100")
Message-ID: <874kx6hnw9.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 38576@debbugs.gnu.org, Lars-Dominik Braun <ldb@leibniz-psychology.org>

Hi Roel,

Roel Janssen <roel@gnu.org> skribis:

> On Thu, 2020-01-02 at 12:43 +0100, Ludovic Court=C3=A8s wrote:
>> Hi,
>>=20
>> Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:
>>=20
>> > > An argument in favor of the status quo would be that it allows users=
 to
>> > > choose between =E2=80=98r=E2=80=99 and =E2=80=98r-minimal=E2=80=99. =
 Is that a compelling argument?
>> > reading the documentation I thought this was possible using
>> > --with-input=3Dr-minimal=3Dr ?
>>=20
>> Yes, good point.
>>=20
>> > > However, if we go that route, we should arrange to not propagate
>> > > =E2=80=98r-minimal=E2=80=99 (it=E2=80=99s intrusive) and instead hav=
e =E2=80=98kernel.json=E2=80=99 do the right
>> > > thing.
>> > I=E2=80=99m not following, sorry. What do you suggest kernel.json shou=
ld do?
>>=20
>> I was suggesting hard-coding the file name of the =E2=80=98R=E2=80=99 ex=
ecutable in
>> =E2=80=98kernel.json=E2=80=99, but I see you already did that in your in=
itial patch.
>> Sorry for the confusion.
>>=20
>> On second thought, I think propagating R is acceptable in this case
>> because a Jupyter kernel is a thin wrapper around a programming language
>> implementation.
>>=20
>> Unless there are objections, I=E2=80=99ll apply your initial patch.
>>=20
>
> I'm too late, but doesn't this break the kernel for people who have the "=
full" R
> in their profile, and therefore expect the "full" R to be available in a =
Jupyter
> notebook?

Indeed, it forces =E2=80=98r-minimal=E2=80=99 for use in the kernel.  But t=
here are
workarounds, as Lars-Dominik suggests above.

WDYT?

Ludo=E2=80=99.