From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wi/KFCl30V4lSQAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 20:57:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eDg6ECl30V7hNgAA1q6Kng (envelope-from ) for ; Fri, 29 May 2020 20:57:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA1F29403EA for ; Fri, 29 May 2020 20:57:12 +0000 (UTC) Received: from localhost ([::1]:55076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jem3y-0002La-KL for larch@yhetil.org; Fri, 29 May 2020 16:57:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jem3q-0002Jg-B0 for guix-patches@gnu.org; Fri, 29 May 2020 16:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jem3q-0001cH-1T for guix-patches@gnu.org; Fri, 29 May 2020 16:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jem3q-00070w-0M for guix-patches@gnu.org; Fri, 29 May 2020 16:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41562] use consistent arguments. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41562 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tom Zander , 41562@debbugs.gnu.org Received: via spool by 41562-submit@debbugs.gnu.org id=B41562.159078579126925 (code B ref 41562); Fri, 29 May 2020 20:57:01 +0000 Received: (at 41562) by debbugs.gnu.org; 29 May 2020 20:56:31 +0000 Received: from localhost ([127.0.0.1]:56342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jem3L-00070C-CT for submit@debbugs.gnu.org; Fri, 29 May 2020 16:56:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jem3J-0006zw-PA for 41562@debbugs.gnu.org; Fri, 29 May 2020 16:56:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48457) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jem3D-0001Qj-GR; Fri, 29 May 2020 16:56:23 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:35624 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jem3B-0008GL-VQ; Fri, 29 May 2020 16:56:22 -0400 From: Marius Bakke In-Reply-To: <3098426.mvXUDI8C0e@cherry> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> Date: Fri, 29 May 2020 22:56:18 +0200 Message-ID: <874kry4g0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: xKUhqez8qUX8 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom Zander via Guix-patches via writes: > As suggested on IRC > --=20 > Tom Zander >>>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 > From: TomZ > Date: Wed, 27 May 2020 13:21:58 +0200 > Subject: [PATCH] gnu: flowee: Disable unpredictable test. > > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts > which fail half the time in a build, so disable the test. Can you move this piece of information to a comment in the code? Also, this should say (flowee)[arguments]: ... > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > index f182057bb4..d176ac0660 100644 > --- a/gnu/packages/finance.scm > +++ b/gnu/packages/finance.scm > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over= RPC.") > (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")= ))) > (build-system cmake-build-system) > (arguments > - `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF") > + `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF" "-D= enable_gui=3DOFF") This should probably not be here? > #:phases > (modify-phases %standard-phases > (add-before 'configure 'make-qt-deterministic > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over= RPC.") > (lambda _ > (substitute* "testing/CMakeLists.txt" > (("test_api") "")) Can this be removed? It looks like it tries to do the same as your new substitution below. > + (substitute* "testing/CMakeLists.txt" > + (("add_subdirectory\\(api\\)") "")) > #t)) > (add-after 'configure 'set-build-info > ;; Their genbuild.sh to generate a build.h fails in guix (no= .git dir) . > --=20 > 2.25.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7RdvIACgkQoqBt8qM6 VPrj0Qf/UB7zSebDzKVLzH6XTxllF8LKu5Sz6e2amsgLJ9iMRBQwQEXPLV68x/we nfS6RGZpQWmKyrgECTWKaA/bXpqFiVPSscmUKo8OqvHzMy62T8UMYsrZ8ANbela0 S3bNle2cIHwBViotsugLFvJNMJh2ecT/JcnN5CoWDa0/niMbdGWQOMPHZgOFBzG1 GlBY8d8akfOoq8p81eaP1n3JbR0MNDs2MvzFYUlQzUYJ9qjfyETfp5dHMChKt8HF AFFSlY1PFS5LxHICB5EDQw0Z0uP4jLSm8c3YpRcE1FBpXegWvAL/VoNA/ohGs3Sj q5JgHsCL7RFxKSyu8XWGYKyb2qKdjg== =5lI6 -----END PGP SIGNATURE----- --=-=-=--