From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QDtNIzm3GF8TPgAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 22:01:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wBP5Hjm3GF9jfgAA1q6Kng (envelope-from ) for ; Wed, 22 Jul 2020 22:01:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAAD194005D for ; Wed, 22 Jul 2020 22:01:28 +0000 (UTC) Received: from localhost ([::1]:53458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyMnm-0004fQ-7w for larch@yhetil.org; Wed, 22 Jul 2020 18:01:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyMnO-0004eb-Dp for guix-patches@gnu.org; Wed, 22 Jul 2020 18:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jyMnO-0001O2-2H for guix-patches@gnu.org; Wed, 22 Jul 2020 18:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jyMnO-0007CR-1C for guix-patches@gnu.org; Wed, 22 Jul 2020 18:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42339] [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-configure phase. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Jul 2020 22:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42339 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 42339@debbugs.gnu.org Received: via spool by 42339-submit@debbugs.gnu.org id=B42339.159545523327625 (code B ref 42339); Wed, 22 Jul 2020 22:01:01 +0000 Received: (at 42339) by debbugs.gnu.org; 22 Jul 2020 22:00:33 +0000 Received: from localhost ([127.0.0.1]:43301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyMmv-0007BU-4R for submit@debbugs.gnu.org; Wed, 22 Jul 2020 18:00:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyMms-0007BH-SM for 42339@debbugs.gnu.org; Wed, 22 Jul 2020 18:00:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56868) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyMmm-0001JB-VT; Wed, 22 Jul 2020 18:00:24 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57882 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jyMmm-0003Zd-9q; Wed, 22 Jul 2020 18:00:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200712234039.17871-1-kuba@kadziolka.net> Date: Thu, 23 Jul 2020 00:00:22 +0200 In-Reply-To: <20200712234039.17871-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Mon, 13 Jul 2020 01:40:39 +0200") Message-ID: <874kpzgqh5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: dt9LOtKkvCrp Hello, Jakub K=C4=85dzio=C5=82ka skribis: > * gnu/packages/commencement.scm > (glibc-final-with-bootstrap-bash)[arguments]: Don't patch sunrpc, > as it's no longer required. Tweak C_INCLUDE_PATH and > CPLUS_INCLUDE_PATH instead of CPATH. > --- > > Hi Guix, > > I have stumbled upon this phase while I was working on making substitute > not fail silently. Turns out this substitution is no longer necessary > since we aren't building with --enable-obsolete-rpc anymore. I'm not > sure about the unsetenv parts, though. Switching them to > {C,CPLUS}_INCLUDE_PATH, which is where the header paths actually are > right now, did not change how `guix graph --type=3Dreferences` looks for > glibc-final (nor glibc-final-with-bootstrap-bash, for that matter). > > The phase itself was introduced in... > > commit 1c93be5600fb90a64cbbdf7a55061902d2ff150a > Author: Ludovic Court=C3=A8s > Date: Sat Jun 7 17:23:53 2014 +0200 > > gnu: glibc: Make sure the bootstrap libc is not in $CPATH. > > This fixes a bug whereby the bootstrap-glibc headers could be picked = up > when building libc.so, which could be noticed by the fact that the > .debug files contained references to bootstrap-glibc. > > * gnu/packages/base.scm (glibc-final-with-bootstrap-bash)[arguments]: > Add 'pre-configure' phase. > [inputs]: Remove 'alist-delete' call. > > The debug output does not refer to a bootstrap glibc anymore whether the = phase > is there or not, though it does refer to gcc-cross-boot0:lib. Does this > mean that the phase is simply obsolete, and only the hurd parts should > remain, or is the reference to gcc a bug? Perhaps gcc should have a > separate output for the includes it provides (stdarg and such) so that > this reference doesn't bring in the whole mesboot tree? This would > improve the closure of gcc-toolchain:debug... Oooh, nice. LGTM! Please confirm that nothing breaks (everything builds at least up to =E2=80=98gcc-final=E2=80=99) and you can push to =E2=80=98core-updates=E2= =80=99. Thank you! Ludo=E2=80=99.