From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id P1fUCru6018KZwAA0tVLHw (envelope-from ) for ; Fri, 11 Dec 2020 18:30:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AAMaBru6019PHgAAB5/wlQ (envelope-from ) for ; Fri, 11 Dec 2020 18:30:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BCE20940630 for ; Fri, 11 Dec 2020 18:30:16 +0000 (UTC) Received: from localhost ([::1]:47094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knnBH-0007G3-4S for larch@yhetil.org; Fri, 11 Dec 2020 13:30:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knmSY-0006Lz-Lz for guix-patches@gnu.org; Fri, 11 Dec 2020 12:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knmSY-0006WF-CO for guix-patches@gnu.org; Fri, 11 Dec 2020 12:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knmSY-0005Py-9I for guix-patches@gnu.org; Fri, 11 Dec 2020 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44990] [PATCH] gnu: electrum: Update to 4.0.5. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Dec 2020 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44990 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dftxbs3e Received: via spool by 44990-submit@debbugs.gnu.org id=B44990.160770863320803 (code B ref 44990); Fri, 11 Dec 2020 17:44:02 +0000 Received: (at 44990) by debbugs.gnu.org; 11 Dec 2020 17:43:53 +0000 Received: from localhost ([127.0.0.1]:42850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knmSO-0005PT-Sw for submit@debbugs.gnu.org; Fri, 11 Dec 2020 12:43:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knmSN-0005PC-16 for 44990@debbugs.gnu.org; Fri, 11 Dec 2020 12:43:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51044) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knmSH-0006Pd-2p; Fri, 11 Dec 2020 12:43:45 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=32818 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1knmSF-0005mm-6B; Fri, 11 Dec 2020 12:43:44 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 11 Dec 2020 18:43:42 +0100 In-Reply-To: (dftxbs3e@free.fr's message of "Tue, 01 Dec 2020 12:53:21 +0100") Message-ID: <874kks5jch.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44990@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BCE20940630 X-Spam-Score: -2.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: Js3rB+djl7LW Hi! dftxbs3e skribis: > Third time.. sorry. > > My biggest submission so far, please review carefully I can still count > my submissions with my hand. > > Please strip the first mail from the mbox when using git-am. Because > debbugs wont allow git-send-email to work without creating one bug per > patch I am sending the first email with my regular email client to > obtain the dedicated address and then using git-send-email. Yeah, the (annoying) trick is to send the cover letter, get the number, and then send the actual series: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html Overall the series LGTM. A couple of comments: 1. Could you please improve synopses and suggestions a bit, according to the guidelines at , and wrap lines to 80 chars? Don=E2=80=99t lose your hair on it but at least make sure to have full sentences in descriptions and so on. 2. The last patch moves a large chunks of eletrum =E2=80=98inputs=E2=80= =99 to =E2=80=98propagated-inputs=E2=80=99. If you are sure this is justifie= d, please add a comment right above the =E2=80=98propagated-inputs=E2=80=99 field ex= plaining why. However, it may not be a good idea to propagate that much as it =E2=80=9Cpollutes=E2=80=9D the profile of users who install =E2=80= =98electrum=E2=80=99, can lead to collisions, etc. Could you send a v2? Thanks! Ludo=E2=80=99.