From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2HCMKkTN+F+oeAAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 21:23:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uMxeJkTN+F+dGgAAB5/wlQ (envelope-from ) for ; Fri, 08 Jan 2021 21:23:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F1409402DD for ; Fri, 8 Jan 2021 21:23:16 +0000 (UTC) Received: from localhost ([::1]:55514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxzE3-0001fQ-0W for larch@yhetil.org; Fri, 08 Jan 2021 16:23:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxzDm-0001f9-HB for guix-devel@gnu.org; Fri, 08 Jan 2021 16:22:58 -0500 Received: from world.peace.net ([64.112.178.59]:39332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxzDk-0002v3-5d for guix-devel@gnu.org; Fri, 08 Jan 2021 16:22:58 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxzDX-0006IO-Ot; Fri, 08 Jan 2021 16:22:43 -0500 From: Mark H Weaver To: Ricardo Wurmus , Raghav Gururajan Subject: Re: [Telegram-Desktop]: Help with packaging In-Reply-To: <87sg7bfwt0.fsf@elephly.net> References: <671cd289-5c83-3673-34f9-8287ff7c30a8@raghavgururajan.name> <5a6392cd-b478-846a-beda-4f97e46cbdd0@raghavgururajan.name> <87sg7bfwt0.fsf@elephly.net> Date: Fri, 08 Jan 2021 16:21:35 -0500 Message-ID: <874kjr15vp.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 2F1409402DD X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: M5O1/KxTJ/sY Hi, Ricardo Wurmus writes: > Because you are fetching from git and the git checkout is not writable > You need a build phase like this: > > --8<---------------cut here---------------start------------->8--- > (add-after 'unpack 'make-writable > (lambda _ > (map make-file-writable > (find-files "." ".*")) > #t)) > --8<---------------cut here---------------end--------------->8--- It's more appropriate to use 'for-each' here. 'map' collects all of the results into a list and returns that list, which is not needed here, and is slightly less readable. Also, the second argument to 'find-files' is optional; omitting it does what's needed more efficiently. So, in the interest of promoting better practices, I would recommend this instead: --8<---------------cut here---------------start------------->8--- (add-after 'unpack 'make-writable (lambda _ (for-each make-file-writable (find-files ".")) #t)) --8<---------------cut here---------------end--------------->8--- Regards, Mark