From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id L7DDBO5xLGALFgAA0tVLHw (envelope-from ) for ; Wed, 17 Feb 2021 01:31:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CDQFAO5xLGBVQwAAB5/wlQ (envelope-from ) for ; Wed, 17 Feb 2021 01:31:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61FEC17444 for ; Wed, 17 Feb 2021 02:31:25 +0100 (CET) Received: from localhost ([::1]:51610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCBgZ-0002Kp-7t for larch@yhetil.org; Tue, 16 Feb 2021 20:31:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC77d-0001Fk-FH for guix-devel@gnu.org; Tue, 16 Feb 2021 15:39:01 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC77b-0006p1-CQ for guix-devel@gnu.org; Tue, 16 Feb 2021 15:39:01 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id CEFC460003; Tue, 16 Feb 2021 20:38:53 +0000 (UTC) From: Nicolas Goaziou To: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1. References: <87im6sxef9.fsf@nckx> Date: Tue, 16 Feb 2021 21:38:52 +0100 In-Reply-To: <87im6sxef9.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 16 Feb 2021 15:42:02 +0100") Message-ID: <874kibhhnn.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 16 Feb 2021 20:30:45 -0500 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 61FEC17444 X-Spam-Score: -2.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1FTLCrnKqlin Hello, Tobias Geerinckx-Rice writes: > Commit 3e10f0eef0fb8b99f5220653b6564693365491b1 removes a phase: > >> Remove unneeded phase and some replacements. > > without explanation. It's admittedly not the prettiest hack, but is > needed to run Alacritty on Wayland[0]. > > Do you remember why you removed it? (Please, say so in the commit > message!) As written in the commit message, I removed it because Alacritty was working without it here on my Gnome 3 Wayland session, hence the "unneeded" part. What else was necessary? Please bear in mind that: 1. it was not a small version bump, so many things could have changed in the package definition; 2. the hack is actually non-trivial as it references packages that do not even belong to the inputs but was not even a single comment line explaining its importance. I'm sorry if you lost time re-instating this hack. OTOH, there is certainly room for improvement in this situation. Regards, -- Nicolas Goaziou