From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aLNIHsvrMGDtPQAA0tVLHw (envelope-from ) for ; Sat, 20 Feb 2021 11:00:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GMX+GcvrMGBabgAAbx9fmQ (envelope-from ) for ; Sat, 20 Feb 2021 11:00:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A80E810DD6 for ; Sat, 20 Feb 2021 12:00:26 +0100 (CET) Received: from localhost ([::1]:58440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDPzt-0005sn-FI for larch@yhetil.org; Sat, 20 Feb 2021 06:00:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDPzW-0005se-Nr for guix-patches@gnu.org; Sat, 20 Feb 2021 06:00:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDPzW-00032g-FT for guix-patches@gnu.org; Sat, 20 Feb 2021 06:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDPzW-00019L-D2 for guix-patches@gnu.org; Sat, 20 Feb 2021 06:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46031] services: cuirass: Add "simple-cuirass-services". Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Feb 2021 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46031 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 46031@debbugs.gnu.org Received: via spool by 46031-submit@debbugs.gnu.org id=B46031.16138187914369 (code B ref 46031); Sat, 20 Feb 2021 11:00:02 +0000 Received: (at 46031) by debbugs.gnu.org; 20 Feb 2021 10:59:51 +0000 Received: from localhost ([127.0.0.1]:51068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDPzL-00018P-7u for submit@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDPzI-000186-Fz for 46031@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41674) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDPzD-0002uZ-43 for 46031@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:43 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34402 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lDPzB-00061m-Cl; Sat, 20 Feb 2021 05:59:42 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87czxxz767.fsf@gnu.org> Date: Sat, 20 Feb 2021 11:59:38 +0100 In-Reply-To: <87czxxz767.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 22 Jan 2021 09:50:56 +0100") Message-ID: <874ki7j97p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A80E810DD6 X-Spam-Score: -2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: mQrwmtB8Mxgu Hi, Mathieu Othacehe skribis: > Here is a service that provides some syntactic sugar over the (complex) > Cuirass configuration. It uses Guix Channels to declare Cuirass inputs. > > In the future, it would be nice if Cuirass could operate directly on > Channels. For now, this service only act as a translation layer for > people willing to setup a simple Cuirass instance. I had overlooked these patches; that=E2=80=99s really nice! > +@lisp > +(simple-cuirass-services > + (simple-cuirass-configuration > + (build (list > + (build-manifest > + (channel-name 'conf) > + (manifest "guix/manifest.scm")))) > + (channels (cons* (channel > + (name 'my-guix) > + (url "https://my-git-repo/guix.git")) > + (channel > + (name 'conf) > + (url "https://my-git-repo/conf.git")) > + %default-channels)) > + (non-package-channels '(conf)))) > +@end lisp I wonder if it would make sense to allow users to pass directly a manifest, as in (pseudo syntax): (simple-cuirass-configuration (build (list (build-manifest =E2=80=A6 (local-file "my-manifest.scm")))) (channels =E2=80=A6)) It=E2=80=99d be less expressive (you=E2=80=99d have to reconfigure when you= change the manifest), but perhaps easier to set up. WDYT? > + (define (config->spec config) > + (match-record config > + (build channels non-package-channels systems) > + `((#:name . "simple-config") > + (#:load-path-inputs . ("guix")) > + (#:package-path-inputs . ,(package-path channels > + non-package-channels)) > + (#:proc-input . "guix") > + (#:proc-file . "build-aux/cuirass/gnu-system.scm") > + (#:proc . cuirass-jobs) > + (#:proc-args . ((systems . ,systems) > + ,@(if (eq? build 'all) > + '() > + `((subset . "manifests") > + (manifests . ,(format-manifests build)))= ))) > + (#:inputs . ,(map channel->input channels)) > + (#:build-outputs . ()) > + (#:priority . 1)))) > + > + (list > + (service cuirass-service-type > + (cuirass-configuration > + (inherit cuirass) > + (specifications #~(list > + '#$(config->spec config))))) What about exposing =E2=80=98simple-cuirass-configuration->specs=E2=80=99, = and document it such that one can do: (service cuirass-service-type (cuirass-configuration (specifications (simple-cuirass-configuration->specs config)))) or even: (service cuirass-service-type (compile-simple-cuirass-configuration config)) ? That way, the relationship between =E2=80=9Csimple=E2=80=9D and =E2=80=9Cno= t simple=E2=80=9D would be clearer. Thanks, Ludo=E2=80=99.