From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GNlCHFVmzmBwKQAAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 23:49:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sBTJF1VmzmC4IQAAbx9fmQ (envelope-from ) for ; Sat, 19 Jun 2021 21:49:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2889426420 for ; Sat, 19 Jun 2021 23:49:09 +0200 (CEST) Received: from localhost ([::1]:48496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luipv-00036H-LX for larch@yhetil.org; Sat, 19 Jun 2021 17:49:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luipq-000357-Ip for guix-patches@gnu.org; Sat, 19 Jun 2021 17:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luipq-0005EO-AW for guix-patches@gnu.org; Sat, 19 Jun 2021 17:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luipq-0005Wz-58 for guix-patches@gnu.org; Sat, 19 Jun 2021 17:49:02 -0400 Subject: bug#48986: [PATCH] gnu: opendoas: Fix restricted path "safepath". Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 21:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 48986 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 48986-done@debbugs.gnu.org Mail-Followup-To: 48986@debbugs.gnu.org, brice@waegenei.re, brice@waegenei.re Received: via spool by 48986-done@debbugs.gnu.org id=D48986.162413933121231 (code D ref 48986); Sat, 19 Jun 2021 21:49:01 +0000 Received: (at 48986-done) by debbugs.gnu.org; 19 Jun 2021 21:48:51 +0000 Received: from localhost ([127.0.0.1]:60914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luipf-0005WN-9s for submit@debbugs.gnu.org; Sat, 19 Jun 2021 17:48:51 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:22487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luipd-0005W6-8F for 48986-done@debbugs.gnu.org; Sat, 19 Jun 2021 17:48:49 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 13BD8240003; Sat, 19 Jun 2021 21:48:42 +0000 (UTC) From: Brice Waegeneire References: <20210612212442.13395-1-brice@waegenei.re> <877ditpm47.fsf@gnu.org> Date: Sat, 19 Jun 2021 23:48:39 +0200 In-Reply-To: <877ditpm47.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 16 Jun 2021 22:53:28 +0200") Message-ID: <874kdty18o.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624139349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=7ERMShFjtwsEZpJZLtf+TiiLMp4YWwNNpmujLwMCkGw=; b=hE2Mk0bF9qgC7d5mPoWa/hF1NRBCSkzkwfZk9NqBvSTqFRkZfIK0BIt21HDZaYepHPxY9r T9w2HtNN+1vlXYOdCjEb7SneWbET1olUUin161Z2jgAScj+E2US0yg1ZndEsKYaog6Adnc 6Xn5Hr+EVutVjoqHtw3q4sNdw1t+wP2QAZre1zOgi0wbudmXm4bi35/2U3ZPQLUCj3F+2a ziPhoQ1eAYhdvDeBEILW2qgeEF2a+96lgUYiPOWH/ACtfd2tFBqfJ8MpFSzB7exZvSUVk0 mbVXHGiXuFHDFfgc5o7VpPG7R0k0Dwe0Jt4wRNjqBtcuSaXOYpb8a7IGHiubiQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624139349; a=rsa-sha256; cv=none; b=iL7AZL9cQ/5Ure08kD6HecJa4o3kPIkKb/N4EeivhFJWcSEAEVfTWBUIqgK9NcyO8gfLuq oNq7CJ4EVHN9BZxC/bTrl/tNEnAG7AT2O6QxnWsYbHrSrco0OOUtLVNacd1fzf6pyBLghi dV952OiA1NnQ1g4yMaJupBgeJneA3A/xpn0EAGs201tspX5I/KxT/fnHmxh5wu7hKyZ3K8 7iffebvg7lJGB9ARUm+mTsX+Shbr/h+MqhYDtv4zpD0VmfNODJHCtcJRO3JtROvy03Frvu sbr5Z/kxDIjgK37071vJ9T8AvrtkOUPY2vxU1wyyjWwhJjQthqfIhk/EW0ZzBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2889426420 X-Spam-Score: -2.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: o6ZpQTFv0T7Z Ludo=E2=80=99, Thank you for the review. Ludovic Court=C3=A8s writes: > Hi Brice, > > Brice Waegeneire skribis: > >> OpenDoas look for binaries in safepath when a rule specify a relative >> command, such as =E2=80=9Cpermit keepenv :wheel cmd guix=E2=80=9D. >> >> * gnu/packages/admin.scm (opendoas)[phases]: Rename 'fix-install' phase >> to 'pre-configure', run it before 'configure' and add a substitution for >> safepath. > > You could maybe move the comment above to admin.scm, right above > (substitute* "doas.c" =E2=80=A6). Done. > Otherwise LGTM, thanks! Pushed as eb939109b9c06a09e1534a403745bd362b653d95. Cheers, - Brice