From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id vcI7FqCk6WBPSgEAgWs5BA (envelope-from ) for ; Sat, 10 Jul 2021 15:46:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ECtAEaCk6WAxFAAAB5/wlQ (envelope-from ) for ; Sat, 10 Jul 2021 13:46:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EAF321D274 for ; Sat, 10 Jul 2021 15:46:07 +0200 (CEST) Received: from localhost ([::1]:33554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2DJ1-0004F6-3I for larch@yhetil.org; Sat, 10 Jul 2021 09:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2DIw-0004Ex-MP for guix-patches@gnu.org; Sat, 10 Jul 2021 09:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2DIw-00024b-E0 for guix-patches@gnu.org; Sat, 10 Jul 2021 09:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2DIw-0003XL-Ad for guix-patches@gnu.org; Sat, 10 Jul 2021 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49169] [PATCH 00/11] Removing input labels from package definitions Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Jul 2021 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49169 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49169@debbugs.gnu.org Received: via spool by 49169-submit@debbugs.gnu.org id=B49169.162592475513580 (code B ref 49169); Sat, 10 Jul 2021 13:46:02 +0000 Received: (at 49169) by debbugs.gnu.org; 10 Jul 2021 13:45:55 +0000 Received: from localhost ([127.0.0.1]:60322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2DIo-0003Wy-UM for submit@debbugs.gnu.org; Sat, 10 Jul 2021 09:45:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2DIm-0003Wk-GI for 49169@debbugs.gnu.org; Sat, 10 Jul 2021 09:45:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33166) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2DIh-0001wd-5P; Sat, 10 Jul 2021 09:45:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42886 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2DIg-00088n-Tg; Sat, 10 Jul 2021 09:45:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210622090221.15182-1-ludo@gnu.org> <20210630204832.25753-1-ludo@gnu.org> <868s2ekbw5.fsf_-_@mgsn.dev> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Messidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 10 Jul 2021 15:45:45 +0200 In-Reply-To: <868s2ekbw5.fsf_-_@mgsn.dev> (Sarah Morgensen's message of "Fri, 09 Jul 2021 21:53:30 -0700") Message-ID: <874kd2e0za.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625924768; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=VOVqte7cjlk4wBri4acGnnDxjb0YSCt2OgPg8gdvKt0=; b=P/WyMshKSSB410gDm48y2qjPDs8eOy9odOxJy4aBCCS3v97flr3Mkb2a5heOO2r1YnWmQg Ai01M2B8SU+IeLSnGQxDFl4CD/F2e6h1ABV1R8GW5xU5RDA8s5/LOLC1pBG3c8lgVDiFfq LYQW409Ex1alJ5KJ87j5k6p44PdlpUhbW1z0W8WzmdwyanKsUH7FUaoiZred2RuZSKbk7y HuDuLv1+stY686RwDOR3SjHwaRsfYsd/jS/Ep+S5D7LsbXqXI8gNbEB9NM3OqoKtjIt7WG P8fvuq6UdlBpqqWSZVhWStK9qxD0IqzDe1aV36ilK2ZyFUWSwCmK/r/c06+vUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625924768; a=rsa-sha256; cv=none; b=EXO3fQqrpAFF1z+/yQxr3rZoUed3D2uwWsuxn0g7nS84buAsRoT/Oy6dBFjFNGBNage69K 62szgtjJuaBksxE0n6w2KfBQ6Xz47A8hoM6jSDz95T+9c0OS8gXNOgqA9KzxRUo6XW/i7Y bzpOacGGGQc2iXSPivBsa8c6iIfHSyxvO/rv52oD2tZlN5ufNCckXFzoFYI5hwzlS1JOyE 2+QF2Or0pFrfgFPt24rmb1OuG+yXnffwrhBaF7e8OkPVb8BVbYaJ7EJ0tbNu+mjZYKQI02 dihEGUGp7nlt9558sOL6ACAqsIyVw/MKP03jf74l2CbXGY0oUTQkIHYGSBn3Ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EAF321D274 X-Spam-Score: -2.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2CxJFI+Ys0yn Hello! Sarah Morgensen skribis: > This is a wonderful direction! I am always happy to see boilerplate > evaporate. Heh thanks, I agree! > Ludovic Court=C3=A8s writes: > >> =E2=80=A2 I changed a few importers to emit simplified package inputs. >> We=E2=80=99ll have to take care of the other importers eventually. > > I found one more easy change to make in the importers. I just gave it a > quick smoke test with the Go importer, nothing exhaustive; and I'm not > sure which other importers use it. I've attached the patch below. Awesome, I=E2=80=99ll apply this patch on your behalf. > In the manual, you added: > >> Each element of these lists is either a package, origin, or other >> ``file-like object'' [...] > > How should a file input like this be handled? > > ("some.patch" (search-patch "some.patch")) > > If I had to guess, I'd try some gexp like... > > #$(local-file (search-patch "some.patch")) Exactly, or: (local-file "patches/some.patch") >> guix/scripts/style.scm | 527 +++++++++++++++++++++++++++++++++++++++++ >> tests/style.scm | 366 ++++++++++++++++++++++++++++ >> 23 files changed, 1643 insertions(+), 298 deletions(-) > > The style script makes up fully half of the patch! Wow. Yes, but the patch resulting from running =E2=80=98guix style=E2=80=99 will= be an order of magnitude bigger. :-) Now that =E2=80=98core-updates=E2=80=99 is in a better shape, I feel safer = pushing this patch series. Let=E2=80=99s see=E2=80=A6 Thanks! Ludo=E2=80=99.