From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4H8BCGQHA2EKRgEAgWs5BA (envelope-from ) for ; Thu, 29 Jul 2021 21:54:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ILGZA2QHA2G3JQAAB5/wlQ (envelope-from ) for ; Thu, 29 Jul 2021 19:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E7023481 for ; Thu, 29 Jul 2021 21:54:11 +0200 (CEST) Received: from localhost ([::1]:58958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9C6c-0004id-43 for larch@yhetil.org; Thu, 29 Jul 2021 15:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9C6U-0004hs-4b for guix-patches@gnu.org; Thu, 29 Jul 2021 15:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9C6T-00048G-Ti for guix-patches@gnu.org; Thu, 29 Jul 2021 15:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9C6T-0007Kw-TU for guix-patches@gnu.org; Thu, 29 Jul 2021 15:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49533] [PATCH] gnu: Add omins-lv2. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Jul 2021 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49533 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thorsten Wilms Cc: Ricardo Wurmus , 49533@debbugs.gnu.org, Sarah Morgensen Received: via spool by 49533-submit@debbugs.gnu.org id=B49533.162758841728154 (code B ref 49533); Thu, 29 Jul 2021 19:54:01 +0000 Received: (at 49533) by debbugs.gnu.org; 29 Jul 2021 19:53:37 +0000 Received: from localhost ([127.0.0.1]:58337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9C65-0007K2-4k for submit@debbugs.gnu.org; Thu, 29 Jul 2021 15:53:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9C63-0007Jo-NH for 49533@debbugs.gnu.org; Thu, 29 Jul 2021 15:53:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46996) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9C5x-0003m9-SA; Thu, 29 Jul 2021 15:53:29 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45326 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9C5x-0002pX-HW; Thu, 29 Jul 2021 15:53:29 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86fsw7rnln.fsf@mgsn.dev> <20210724194117.8372-1-t_w_@freenet.de> Date: Thu, 29 Jul 2021 21:53:28 +0200 In-Reply-To: <20210724194117.8372-1-t_w_@freenet.de> (Thorsten Wilms's message of "Sat, 24 Jul 2021 21:41:17 +0200") Message-ID: <874kcc28xz.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627588451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=O7L6RVFeFrZH639eY9foMMnSDObUzLpPa9T7ppf7yYw=; b=o6WrCDBt7gcor3hQWawxSfM5GTr/E/5MADYOSsi2IkkzKiF24TBTKL6jXesF/H2P7hGHB0 oEzl5ou3yja0j4fgCmN3JbCaD6iX6qoMQmRaLGbCJBjp6FZPPpIzexnCzwcrLh10uMb367 eUZEw1Zk2Ic/rVKbHt5mVO1TAwtd8qw1LS493r6OAzoFCvgabFpPt2iCed9Y27evVlHslS Q0W07K8iyFmJrABHSu3j9rp1Ymy2oUkLOzc0G+vmRuPap9S/972U5FlZGYht666+09riRh byg1ha95EAZT+Hq9J5qmvqmxSeYEQeiJ9Rf0QkMwclZl/MX1MXFznLela2v3xA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627588451; a=rsa-sha256; cv=none; b=cirm2rQOXtxAw178daMIU1CD7EkTOV3suspRnpknLGrAiNwV03YbXa1jA3WPC6rYYHOOtq NiSWxxoYHsgW8de0N+AsnTNGlmbg15qp2g6jj0DGuJeaFOPOYyu6j+L+EaVXWZnbFQToQb BtlaPSbMPh8N0WzcSR3oR3Qa/5onCLJoy5wO4serVQLxIUVcCI17sexf1giS1Z9EdISDlW uN4BzHJRTvQsBUTgPC9XsjB+wQBYeCQlWKzm5WUwqj2Kw/mrZf1Crtj+hccG4BpDk5P+lN P1Kbe9fA7yRLbwaTnc/uhZPUrM0h6tnkGXNYV/lrk9EazbburGJnj28UL0Q8Bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5E7023481 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: Et1hxCz3rTwd Hi Thorsten, Thorsten Wilms skribis: > * gnu/packages/audio.scm (omins-lv2): New variable. It LGTM, modulo minor issues: > +(define-public omins-lv2 > + (package > + (name "omins-lv2") Please consider passing it through ./etc/indent-code.el: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html > + ;; No release despite being perfectly usable. 0.0.0 seems to be the o= nly > + ;; version the author ever specified: > + (version "0.0.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/") > + (commit "058f341053067b69a84d4081107fda5058290ff9"))) Please check out on how to compute version numbers in such cases. > + (native-search-paths > + (list (search-path-specification > + (variable "LV2_PATH") > + (files '("lib/lv2"))))) I=E2=80=99m surprised this is here (in the plugin) rather than in the packa= ge that loads this plugin. There are other LV2 plugins doing that though. Ricardo, WDYT? > + (license (list license:gpl2+ license:gpl2+)))) (license license:gpl2+) should be enough. :-) Could you send an updated patch? Thank you, and thanks, Sarah! Ludo=E2=80=99.