From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aFCQNND96WHlhwAAgWs5BA (envelope-from ) for ; Fri, 21 Jan 2022 01:26:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UJPWMdD96WHfRgAA9RJhRA (envelope-from ) for ; Fri, 21 Jan 2022 01:26:56 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53A73100CB for ; Fri, 21 Jan 2022 01:26:56 +0100 (CET) Received: from localhost ([::1]:36326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAhlX-0000V7-DT for larch@yhetil.org; Thu, 20 Jan 2022 19:26:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAeIs-000713-MB for guix-patches@gnu.org; Thu, 20 Jan 2022 15:45:13 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAeIo-0002p2-39 for guix-patches@gnu.org; Thu, 20 Jan 2022 15:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAeIo-0008CS-1k for guix-patches@gnu.org; Thu, 20 Jan 2022 15:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46848] [PATCHES] [core-updates] PEP 517 python-build-system Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46848 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 46848@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 46848-submit@debbugs.gnu.org id=B46848.164271144831444 (code B ref 46848); Thu, 20 Jan 2022 20:45:02 +0000 Received: (at 46848) by debbugs.gnu.org; 20 Jan 2022 20:44:08 +0000 Received: from localhost ([127.0.0.1]:59312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAeHv-0008B6-W0 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 15:44:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAeHu-0008Ac-GJ for 46848@debbugs.gnu.org; Thu, 20 Jan 2022 15:44:07 -0500 Received: from [2001:470:142:3::e] (port=51594 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAeHh-0002jD-04; Thu, 20 Jan 2022 15:43:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=pXkj+Jzo7eEicfiKAYkrEIYSP5Gb+CFNo93zR/uwn6c=; b=rw2k8zw9PAubwiGt6ppt cJZHoQvhLGyjBxA2OTOT2XJEEGkROWtImAq2rvvgoy7Ejr75GZQhlKh5r4RVPYEYjexTvVyKlx1Ag fxglJKeCKkQQol59kSyEIzyOHQU3Wu2TCgBFXdBV2pD5cDvFaJPeJiBhVz0wRDJgt7BL3pd0TPiU+ awfFJo+ke8+Qwfnb+zVenuVl+TM+8a8vxqwnxPfM3iVYohdb5m8O6q3uPmbJMOGEp7mAvSTGbgKJ5 hsCB0PR5s5r9+gRJkKvnszrXe/Z18nj1R6QFnqvNjXSQJ62XY7e91UtA3v/wDKGr13hPVOES6CV+q TvJhT6Swuf0E4Q==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:59890 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAeHh-0001p3-4P; Thu, 20 Jan 2022 15:43:53 -0500 From: Marius Bakke In-Reply-To: References: <877daubeju.fsf@gnu.org> Date: Thu, 20 Jan 2022 21:43:50 +0100 Message-ID: <874k5yb0jd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642724816; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pXkj+Jzo7eEicfiKAYkrEIYSP5Gb+CFNo93zR/uwn6c=; b=IZNq7neFvhM4Q560OutHK+/TElQ5IDSYoSATZ5DifbJ0il588QkbGnc+o2wXltOFDnzyB/ f7yah7tbFhj8WdSzgnP8A8hD+SFytX+YcdXwO0pKbydDZlw8pTruzXPeUU2UgbE379mX9r VsQo31LfYQ0kuxvZj8d5fJDUtxv/a6gcBWp+nwPuuz6pKAyEt1Jtd5f28xZPlkAeoH39kx zIW6Jfu6QCzOIDzss7jGp8B/H3bw0MJMtxVD2OaeIvHINSbCncTWat7W33SS7dS08UTs4r e9T4YbJRH+IPJLyjq6iyBvkGo7OPRkijtD7pQB9EKERT5pphl9L97vy7F9F5uA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642724816; a=rsa-sha256; cv=none; b=pYQP0A0o4xaN4Os/8JE3aE4DnuOB3QeeARjVXehilA7P7aVkULP7jrlbCMY4v25bd3C4Af MjsAUxcMgZd+p859VxAAJ7bIWEATCmz5r32STL0o5iN6A8gZYjnaH+yEaUOJpjFQ5idn78 Bmr0B+bJG5MRcIiHTOGeV2TE2SENi0kRbpDpUjXvP6Wz3dWrkXS4By0t3MySl2J+Rcfka2 japSPuReZyqFUBUn5/J7I6fO3Wj2yprWzwXmHVnQGIRsiCoUGuVTM4KSQWMWy0Z6F9xSvz l9RZGgO7jaawRgvHv25AfS87+eSkEoQCJvbb+Y5hKsUkPuyOiSF8eSUHmsfz7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rw2k8zw9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rw2k8zw9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 53A73100CB X-Spam-Score: -7.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: e3Yc66TAoELO --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars-Dominik Braun skriver: > Hi Marius, > >> Can you elaborate on the name clash issue? > the problem seems to be that most packages do not put the source code > into a subdirectory in the sdist. I.e. package foobar will have a foobar/ > directory, instead of src/foobar. Thus Python tries to load the module > foobar.barbaz from that directory, instead of the store. Thus it=E2=80=99= ll > also look there for C extensions and fail. I don=E2=80=99t know why it do= es > that, even when *not* using `python -m` =E2=80=93 according to the docume= ntation > it should not. If anyone has any pointers I=E2=80=99d like to have a look= again. Perhaps it could be worked around by building in a separate directory, i.e. ./build/lib, like setuptools does? And ensure that the original source directory does not end up on {,GUIX_}PYTHONPATH. (I don't really understand the problem, just throwing ideas around.) >> Unfortunately we need Python 2 for some time still. It is used to >> bootstrap old versions of GHC, Node, and probably other things. > But as far as I see these specific examples do not use > python-build-system. Only if some package using `#:python python-2` is > required during bootstrapping, then we=E2=80=99d need a way to support Py= thon > 2, right? Right. If we don't need any Python 2 modules it should be fine to remove support from the build system. >> Do you think it is feasible to provide this as a new build system, say >> pep517-build-system, during a transitional period? Then we can a) start >> using it right away for the increasing amount of packages that lack a >> setup.py; and b) flesh out most bugs before eventually merging it back >> (possibly piecemeal) into python-build-system. > Actually, I think that=E2=80=99s a good idea. I tried, but I cannot fix a= ll > packages broken by this change on my own, so smoothing the transition > could help and =E2=80=93 as you said =E2=80=93 we could catch bugs early = on. > > I could prepare a patch, if there is interest in this path. It would lower the bar significantly for testing and contributing, so I would appreciate it. :-) >> * I also think trying "python setup.py test" is unnecessary. > It still works quite often, although its usefulness will decrease in > the future I guess. Another problem I see is that this command will not > fail if there are no tests. > >> * It would be nice to support the "no tests" case without having to add >> explicit #:tests? everywhere. Perhaps along the lines of... > My idea was to force packagers to make and explain this decision > explicitly. If you don=E2=80=99t run tests, you have to add `#:tests? #f` > and leave a comment why they are disabled. I do see this could become > a hassle with packages that simply don=E2=80=99t have any tests. But my h= ope > is that it increases package quality. My main concern is end-user experience when they just want to get some random library working on their local channel. But it's arguably something that can be solved on the importer level and not a strong opinion. Thinking about importers, perhaps they could start emitting git origins when possible, as there is a trend to strip tests before uploading to PyPI. >> (_ (apply invoke `("python" "-m" "unittest" ,@test-flags)))))) > If I remember correctly I tried this and it did not work for some > reason. I=E2=80=99ll have a look again. Eh, it should be (apply invoke "python" "-m" "unittest" test-flags), but you probably got that. :-P Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYenJhg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeGuwD9H2BY3O9ueLy3SB08wMJF/fov3rf5Yv8pnOR5 U1ljuasA/340yEq0yCLyQD4/iqk1v7G4JOwTP5DtgHDLiC+GTi0J =3u8K -----END PGP SIGNATURE----- --=-=-=--