From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gE30Cx3TKWIIHQAAgWs5BA (envelope-from ) for ; Thu, 10 Mar 2022 11:29:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CEOOCB3TKWIIfgAAauVa8A (envelope-from ) for ; Thu, 10 Mar 2022 11:29:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CAA782C425 for ; Thu, 10 Mar 2022 11:29:48 +0100 (CET) Received: from localhost ([::1]:49240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSG3H-0000ui-PN for larch@yhetil.org; Thu, 10 Mar 2022 05:29:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSG2Y-0008Sl-Rl for guix-patches@gnu.org; Thu, 10 Mar 2022 05:29:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSG2Y-0006dB-JP for guix-patches@gnu.org; Thu, 10 Mar 2022 05:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSG2Y-00047o-Gn for guix-patches@gnu.org; Thu, 10 Mar 2022 05:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Mar 2022 10:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54180@debbugs.gnu.org Received: via spool by 54180-submit@debbugs.gnu.org id=B54180.164690810515797 (code B ref 54180); Thu, 10 Mar 2022 10:29:02 +0000 Received: (at 54180) by debbugs.gnu.org; 10 Mar 2022 10:28:25 +0000 Received: from localhost ([127.0.0.1]:33390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSG1x-00046j-EG for submit@debbugs.gnu.org; Thu, 10 Mar 2022 05:28:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSG1v-00046T-Ss for 54180@debbugs.gnu.org; Thu, 10 Mar 2022 05:28:24 -0500 Received: from [2001:470:142:3::e] (port=53664 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSG1q-0006Z5-9w; Thu, 10 Mar 2022 05:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=w5f3l+ubzAe6DLbEo/XBtYS98pu/5wOvZkleRsLP/54=; b=VnjFlFh3MoylsiIF7V4u df+WFjIxBzKgl3VfZ4XJ7qZIJWocT5/0Uv08DMK33+lNQevtaUz0et9zhR82nILpPaGSixxwhfAHU mcrFhIn7cIFV0QM0lZnMmGgovSfsWywPnQ1bZuY+EdV4yUz1YtOUsmzwuWuhIicSLjx0alDtyxLfe l/1dSQv9dgvDHewiyj3jbH3oOA5AF7BEAOsiWGHRmBZTpVh4ZQxMpYN4mSGLQl09OkuQjJpFavVVT 9AXfQA8iDlj5apM6wLQUJVTl/X/KPAF6R4/kaTV5KXBZaSfvbygtc6v/J70KrpNuu+MxHThJuLxDB mTU5017Ksnn/mA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59591 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSG1o-0004q2-Qm; Thu, 10 Mar 2022 05:28:17 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220227135342.10296-1-ludo@gnu.org> <20220227135342.10296-2-ludo@gnu.org> <66bb9a617542057fe6c536631927d94c530dc173.camel@telenet.be> Date: Thu, 10 Mar 2022 11:28:15 +0100 In-Reply-To: <66bb9a617542057fe6c536631927d94c530dc173.camel@telenet.be> (Maxime Devos's message of "Sun, 27 Feb 2022 16:58:09 +0100") Message-ID: <874k46yudc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646908188; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=w5f3l+ubzAe6DLbEo/XBtYS98pu/5wOvZkleRsLP/54=; b=EmDgn87b47G/isBiRIKaVafIYp4Ai5LjW1KSKdMflxEMmt7YpxZ/qEruhw93uaMIBVf3QZ Q+lzblGgyLb8MaNc9A2+OqRrc8vX8I/arnUMiSAX3aHigUo1pGpScAz7YmtEP2FWaj2VZ4 x0OE5vKWa7bHQSVEH4zq1FORhcLQhX/bL/Vu0VJZfLFbmOcG8RVYeB7pobY1u6QVIQi07D 6ueGkGNr86/k7bPtD5XqPtLYGGOfUAN0A1Atm0zoUUh5CuNCuQtpuhRW0ngRfDzq6qNSik GicEDz9a/3eJFRnPT2dSrRWV98qaRtWaocgh47NHewgUJkbaUAaAeUUa/hSI7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646908188; a=rsa-sha256; cv=none; b=icyfxcH1eHCdXid1kn54CF9vaHK+1mw7otOZBMvMQ+rLn+HPwzctm+x/d40xZFBO46MG4U kB0Zppj/qqP9toFrJCNzv/4DwzFvCrsR9JT1dkw5/gUgmtFo0neh8vs81s9NqNPhw/rCNB ASn0NLEy7tz7awAzpgG8af2c+OVeI06yCx1G+BfX4WdP8vRWkr87/RhGvFiPtZVjhKZVf4 alr1wSVx64up6Vw+7rLLb5acwD2JtB4q9C74dIK4+hRr2uNkHgT4fMT454oeMUA1mm9bQN KSDWsyGryaZVfrjMSFm+egDNbgPghAyzQOwalVtdRyuvV1olKS2/4Fj/mKJcAQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VnjFlFh3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VnjFlFh3; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CAA782C425 X-Spam-Score: -5.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: dT/uAKGyWmeW Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op zo 27-02-2022 om 14:53 [+0100]: >> (file-exists? (get-target-path path)) >> [... other uses of file-exists? ...] Note that this patch just shuffles code around; it does not introduce new =E2=80=98file-exists?=E2=80=99 calls. > 'file-exists?' does not simply check whether the file exists. > E.g., when there is some permission error, then it returns #false. > > I think that in case of an permission error, it would best be reported > to the user, so I think a variant of 'file-exists?' may be needed. I believe later patches mostly address this by avoiding separate =E2=80=98s= tat=E2=80=99 calls (=E2=80=98file-exists?=E2=80=99 is a thin wrapper around =E2=80=98sta= t=E2=80=99). Ludo=E2=80=99.