From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UNVOMeCeMGIkJAEAgWs5BA (envelope-from ) for ; Tue, 15 Mar 2022 15:12:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CBuBLuCeMGKmmQAA9RJhRA (envelope-from ) for ; Tue, 15 Mar 2022 15:12:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 785E735227 for ; Tue, 15 Mar 2022 15:12:48 +0100 (CET) Received: from localhost ([::1]:33940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU7up-0004hD-Mr for larch@yhetil.org; Tue, 15 Mar 2022 10:12:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU3UE-0000Zc-60 for guix-patches@gnu.org; Tue, 15 Mar 2022 05:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nU3UD-0003pM-RO for guix-patches@gnu.org; Tue, 15 Mar 2022 05:29:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nU3UD-0007pl-Id for guix-patches@gnu.org; Tue, 15 Mar 2022 05:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54393] [PATCH 0/2] Add 'guix manifest' to "translate" commands to manifests Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Mar 2022 09:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54393 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 54393@debbugs.gnu.org Received: via spool by 54393-submit@debbugs.gnu.org id=B54393.164733648330025 (code B ref 54393); Tue, 15 Mar 2022 09:29:01 +0000 Received: (at 54393) by debbugs.gnu.org; 15 Mar 2022 09:28:03 +0000 Received: from localhost ([127.0.0.1]:47572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU3TH-0007oD-4e for submit@debbugs.gnu.org; Tue, 15 Mar 2022 05:28:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU3TG-0007nl-8a for 54393@debbugs.gnu.org; Tue, 15 Mar 2022 05:28:02 -0400 Received: from [2001:470:142:3::e] (port=33254 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU3T9-0003jV-Gd; Tue, 15 Mar 2022 05:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oB6R0gt5gf41cRkZ+x8E4ss/dKLX2N3EgQhYeSfBNgM=; b=Vo5tnm42X625YzDUMndn UOFu3CQpraZJsHMflYj1SssCgovcZTAcGdfS5Em1O8CYzR641MOL9LW1METK+lPxKM24Hc5fgxyXQ k1+c0QegAj9tfTiQUX9mDmkGgcB8GQbORUuXfmtkNho+iToUFMlnJ2olgjMM5fErAGOdibkKvGbVN NZLjhmkj0AvEHgXsKKTP/7OG2F5q7W/PHxkKCVxs9kBWCS+zGRc7Myl6Y76XJBl23kKvMXEZlpxTo TgAY47Y5Bk1IVEqZHryzRRgh11gOAWlBru70WQ/8nTWrZOoSwQ1guKs2TKkq8kV/LH/z89GuTVKUo UWZOEiDzsD2CPg==; Received: from [193.50.110.182] (port=59360 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU3T8-0006bv-Uz; Tue, 15 Mar 2022 05:27:55 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220314215015.24435-1-ludo@gnu.org> Date: Tue, 15 Mar 2022 10:27:53 +0100 In-Reply-To: (Liliana Marie Prikler's message of "Tue, 15 Mar 2022 08:18:57 +0100") Message-ID: <874k3zmup2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Tue, 15 Mar 2022 10:11:51 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647353568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oB6R0gt5gf41cRkZ+x8E4ss/dKLX2N3EgQhYeSfBNgM=; b=eyGRp6115h81oTkpaV33S7wDrb8n4fO8/bNpjAaTX38Tiduz2MvbqPxHlk9Qc92boAjxZw wGwOFVqTt/VfzNCtjqXjkYW0WTYrAGSlJ3vWcQtaf7vdSxk+kz6pXEtQcxTdgQLUpaH0mC kGOLC+wrgg1tWoL3NBxLF+XUe0F3XTTd5uzDzEt53Ce8CtlpyKV7h8LrvZDJ6PwCWjiXnR ejcCnY1FvBBawk+rcEMtQ9aAmMTa/9nFcJv2HtwZHNgt4jE9J5NPTCo4mP6piLHJkHDqsi 2EC/nr05gi7uRbbeFNhGMxngj+NW4TFo0q0Ku4JCOyiN3ANeqt8S0mZotIkmig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647353568; a=rsa-sha256; cv=none; b=XuxxpXSHQjUlmX5d6MFe2PlsnZLDB6RQ0vHDgGMU43z/W6VFn9sHKCfuzPKCCX+ne9lq88 JY3y7gqtEioSF+bEZkjV7UP1iM5jSQjc6YUTfc3QjWzrwp4o/Ks10R7jVjEjs1FdjjLdXr UOhqX2rVNFD0L+H7EZs7oUTnoADdaeTkRdr7FtYb+8dOIbvtkDILK+TB/j8aO2t22acmJN lb1AcedRQ6ZcRgAi3s13dWnC8NiJUrBw+guE/H5QP4BBjqiOlcC/l4yfbZd9R3KHpzu+yd vkq4h/x6rR/a98HlsuQfq+phJNgmaewF2XoGnmoQYLd2GbtJOswN6T06wV8pCA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Vo5tnm42; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Vo5tnm42; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 785E735227 X-Spam-Score: -4.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: haHqdJMfKwtB Hi, Liliana Marie Prikler skribis: > The current implementation is missing the most important feature, which > would be =E2=80=98guix manifest --profile $GUIX_PROFILE=E2=80=99 :) True, we could add =E2=80=98-p=E2=80=99 and make it equivalent to =E2=80=98= guix package --export-manifest=E2=80=99. I think lack of =E2=80=98-p=E2=80=99 is not a showstopper though since =E2= =80=98guix package --export-manifest=E2=80=99 remains available. [...] > Furthermore, one issue I have with both the existing and proposed > approaches is that both mandate the specification style, The reasons for the specification style are: 1. That it=E2=80=99s easier to implement reliably, since you just need to= rely on package specs. 2. The resulting code is future-proof: if packages are moved from one module to another, or if their variables are renamed, it still works. 3. It=E2=80=99s a one-to-one mapping compared to the command line, which hopefully makes it clearer. However, =E2=80=98manifest->code=E2=80=99 existed before this patch series,= so I think it=E2=80=99s beyond the scope of this review. Thanks, Ludo=E2=80=99.