From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sFtILuDleGK0PAAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 11:58:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IEJlLuDleGI67wAA9RJhRA (envelope-from ) for ; Mon, 09 May 2022 11:58:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 330703E027 for ; Mon, 9 May 2022 11:58:56 +0200 (CEST) Received: from localhost ([::1]:40566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no0AI-0005hX-VK for larch@yhetil.org; Mon, 09 May 2022 05:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no04c-0000Y4-HW for guix-patches@gnu.org; Mon, 09 May 2022 05:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no04c-00054i-6E for guix-patches@gnu.org; Mon, 09 May 2022 05:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no04c-0005LH-5D for guix-patches@gnu.org; Mon, 09 May 2022 05:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55316] [PATCH] scripts: package: Transform before creating manifest entries. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55316 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 55316@debbugs.gnu.org Received: via spool by 55316-submit@debbugs.gnu.org id=B55316.165208992920437 (code B ref 55316); Mon, 09 May 2022 09:53:02 +0000 Received: (at 55316) by debbugs.gnu.org; 9 May 2022 09:52:09 +0000 Received: from localhost ([127.0.0.1]:56154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no03k-0005JY-Nf for submit@debbugs.gnu.org; Mon, 09 May 2022 05:52:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no03h-0005J4-W8 for 55316@debbugs.gnu.org; Mon, 09 May 2022 05:52:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no03c-0004xO-9i; Mon, 09 May 2022 05:52:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DptBGxhxGMHgblwT0ax1xBoOIba/X3/4YmMfkfc1+3s=; b=e/feirmxv+UyIVZ2HWpF kRcD7eLf79op2kiJJNZhdjhdjt1WRtGM9Kl6L95cVdFdAh/zoK6bQRTwRxFafYR2qOpzjJ80ZdFDL DZPXWbSu7FPNKmCNm0DKh+DElVI6r1L8SQEPrdOvUkZv49Vyl/0+Bi5SeNBylM4eAAyfLtYrSYM7E jH0mCX1MYMgWqExhRmw5xZ+hrUX4/afnPTgOLAoftx8mOLOmXihHey1uE2R8XHu4TFGNNhNtMmCuA 2XyHYlhfzibiKVAeMZj7wW6HONO5g/9XaHmlpJhE2D6EnHaHu3AJyWznLzj1S6UKTE2GHEVA4/cEv T7tdLUBvaJjmkQ==; Received: from [193.50.110.244] (port=52676 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no03b-0000cU-OF; Mon, 09 May 2022 05:51:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220508141606.14085-1-dev@jpoiret.xyz> Date: Mon, 09 May 2022 11:51:58 +0200 In-Reply-To: <20220508141606.14085-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Sun, 8 May 2022 16:16:06 +0200") Message-ID: <874k1zrq2p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652090336; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DptBGxhxGMHgblwT0ax1xBoOIba/X3/4YmMfkfc1+3s=; b=tBkawNslwJsVk9ufIY++donyMZorNW4mXDGmuVAdDIts70y9oVA7RU4f/MvJ0R2QusX2pg WCkuJW3WSMQqceVZ8mNbkKEj4hmaotbF44yCnK4Kona1J0n0Gxemte6G7WQNKSxbYb6Xrn L4WWqG7pXWpKvNmZf2qQ0hfpwDiXu6C2FnhhK7LI64CGW4fRRy1YPm8wK84eyBJ1c8o/XN TWhEAIH2kCMcWP4+FUvznHQp5ymXD6xOvdHlZwMKuHiFluTSefCRBIDjFwmhRQuEFUTxG8 9PMCxqwq51KLpW71AQqgwVAPKvWDk2URtADLMes8reL14MsWLoyni+21PUsoxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652090336; a=rsa-sha256; cv=none; b=GKzUHwIvRQr/V19LsMegqMt506F+pyi5PCmaVQPZokMUKzVe7d2mhmeixC5HjSJOhRkYdk d783IrioSAbbf60+LVTKBZBcmEHr028lWcUUrNj5gFuviGE0JGkewHcM1equJIHBlQZx8y NLHmFyEEUGaNuDSRmg6BF+6HYdnsVLC1I3SiDfCczDwC8mSsfhNq6DPLsTNAOS7EJpx3oz HL8brpd3//pfltBR5/BCxV6Dq649+67lKUnkXewXxoZl1f5LOtZcxqxnlnMcuKbz2aM9CC EwzCcKuKui334qugNBVDoI2qrsqbguPBQEAFcI7XnS8+DyQd0tkeV1w8L4QNDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="e/feirmx"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="e/feirmx"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 330703E027 X-Spam-Score: -4.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1HuoKHcHN5Dz Hello! Josselin Poiret skribis: > * guix/scripts/package.scm (options->installable): Add TRANSFORM > argument, to be able to directly transform the new packages before > creating their manifest entries. > (process-actions): Remove transform-entry, and step3. > --- > Hello everyone, > > Someone on IRC [1] reported that they couldn't run > > guix install emacs-avy emacs-embark --with-branch=3Demacs-avy=3Dmaster --= with-branch=3Demacs-embark=3Dmaster > > without guix complaining about conflicting entries of emacs-avy and > the propagated one from emacs-embark, even in a profile without either > of them. The issue was that package transformations were applied to > the contents of the generated manifest entries, but weren't applied to > any of their dependencies. Interesting. > To solve this, I figured it would be simpler to just apply the > transformation from the start, only creating the manifest entries > after they have been applied. Also, the default > `package->manifest-entry` preserves transformations properties by > default, so this doesn't lose any info either. As discussed on IRC, could you make sure transformation properties are preserved in the manifest? I only see one test that explicitly checks that, "transaction-upgrade-entry, transformation options preserved" in tests/packages.scm, and then there=E2=80=99s "options->transformation + package->manifest-entry" in tests/transformations.scm. Also, could you add a test that reproduces the problem being fixed? Thanks! Ludo=E2=80=99.