From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wNz4I8sFgWL1xAAAbAwnHQ (envelope-from ) for ; Sun, 15 May 2022 15:53:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uNLyIssFgWLWdAAAG6o9tA (envelope-from ) for ; Sun, 15 May 2022 15:53:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0EA2C4A5 for ; Sun, 15 May 2022 15:53:14 +0200 (CEST) Received: from localhost ([::1]:45012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqEgL-00081G-TL for larch@yhetil.org; Sun, 15 May 2022 09:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqEgA-0007zZ-Ur for guix-patches@gnu.org; Sun, 15 May 2022 09:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqEgA-0005RK-Kc for guix-patches@gnu.org; Sun, 15 May 2022 09:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqEgA-0005Jl-I6 for guix-patches@gnu.org; Sun, 15 May 2022 09:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53414] [PATCH] update Node LTS to 16.13.2 Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 May 2022 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53414 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ryan Sundberg Cc: 53414@debbugs.gnu.org X-Debbugs-Original-Cc: 53414@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165262275920407 (code B ref -1); Sun, 15 May 2022 13:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 May 2022 13:52:39 +0000 Received: from localhost ([127.0.0.1]:48809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqEfm-0005J4-Sf for submit@debbugs.gnu.org; Sun, 15 May 2022 09:52:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:54086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqEfl-0005Iw-I2 for submit@debbugs.gnu.org; Sun, 15 May 2022 09:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqEfl-0007yf-AP for guix-patches@gnu.org; Sun, 15 May 2022 09:52:37 -0400 Received: from mout.gmx.net ([212.227.17.22]:37885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqEfj-0005PY-2k for guix-patches@gnu.org; Sun, 15 May 2022 09:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1652622736; bh=n5wIGZfLQ0sgcmlDwl1Zh32kX3UwTijV+giJxFi7joU=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=lZ3ny04HBK4lFzzqCd2LbKrWDWy9SJGSH5FEPnW/U3pTSLrcAAgD/F+HLDJfv7Fg1 gKqjtiJJIw9wFcyvA9QwZ8LSLnWtvzwa6g5RtMBWOoiOYMAMBtbnFgURxUdpaHyxeH XtOgWPARJNd8gglgrNShY5fOLrRWp8ojiPB0Twjk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MzQkK-1ndG9v47SC-00vOp6; Sun, 15 May 2022 15:52:16 +0200 References: <145389012.1197903.1642777885519@privateemail.com> <079ca956e4d7c6b71921ee34638de012ae0a0c5f.camel@telenet.be> <87lexyew8j.fsf@gmx.com> <14d2b050-5e3c-c923-023f-38584bd726b8@arctype.co> User-agent: mu4e 1.6.10; emacs 28.1 From: Pierre Langlois Date: Sun, 15 May 2022 14:45:16 +0100 In-reply-to: <14d2b050-5e3c-c923-023f-38584bd726b8@arctype.co> Message-ID: <874k1q52es.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:0FhbzchbejK7oKl/9VwEkgVc6/db6W1b3VLUFK0ud7eE1jiDJQb KaEy5Gxeb/Dyp9hh3fuG9VCFuUSReY0mg+DmxHjh8QXkNAlBjyPWSwpdTZSJb5ziQSbhOJe MEjcvuh04VkMPtFNfXGNjEEVKonpvT47f9HqYAJ5Y/b8GpYfDX1KcLeGKRzBWp1DtITOest ZnzHQ6A9PJw0uMSpnN9ag== X-UI-Out-Filterresults: notjunk:1;V03:K0:DwPKbY8Yh84=:UKNQH7DbNl8vVYAhZUk1E/ +UF4E25Ght0/9+B4Mi4wtDvYWAx2HSi8nSk8vOuPUGxPJ5s4iB242+zqH85wHu8bS9Ez2qNhm 69ba5hYG5A4GICWKYt6AlIiVNN80fSqIxi+FbpenI5ca1wcjiGTt/CFILbkJAybYoioYRU+wO aRUVVP/R8iLl0dRJfYs5gEMgQnICFe+rqEj03qEOEAzPH71o2+RWSZNcSNV3L173PFyqY6AWy oJZBCe+CXiz4Qz2p47LL4zCF9KqWIMcqr0hqrd4+Q0tgUPRY9b2l3NmuGaMoXboOXBJA+HvQ/ PSA/UFCVvHK/iCvVBQCdf9djh4oFfTsPAcK/Jsnp20QuFxK41r6dzg/RjwIyzUKrPTG3JWRKC BBgRoTvykZ3SAT6Nx52tnZ/mWFL0v4/KHpPgkxmfK1JkRVkXvz4riOAeHJkVbNH7ET33NntsE YUb9MTSL4UzVM+s6kob7SPi13DcQe+vVYVnweM7G6QbOII+bizxCicJ1kxREwnEbqqLcZBWJp 5VuSJqQHBlGuT5PAd3Ce+7JIaTw5jee9I2dhUorGhopXqe0XKOKIKqyJUri+vt+UNBLcMzx9g Nr9EWfmmInhWaxvbrittHPI6N6ntqWKZr7R+9+B2vAJEPf0giN03ied31rExTbv/LIJuE6z5C rMnAoO8bHqLRYfAwyXja0NP5E/dVL+MJ2ZJiwXNtkRdmzUjw5DB9HgIcI/oTZr54+lPqhnf/O u+rTb1qGhGSg85SGmBUZckNjp1Ql4EU7rQaGIJDjLexlk59EhbGA1hQS2DJDRhAp8Kor5j8wE 8rhzVU+KEIsU7MN1pWFmhDA+pl1QCnnoo5BkHkn2eIHK88mVtpgMCXmSPt2ds8LIL2SmcFWY4 od089LTXdEep1khtNvu3vt0UC+TaATDtdGNfO82PuaGo+RCsvrole+r3TAhLQC5588wDVKMvi ppb9U3gRzrTzZzzt8h+qNWLc738qRNBvdWWAE/8tfNm34L9jZ+wyBpX2F8sp/meiviltmDc8h XCpQUm3ImxG4YhMumCKrEBTk+3YINpDDdFW5bDG3wx1TcvpmK3gi89/THfRC9Opo1pfFKjtog 0bqWLindl/5pfc= Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652622794; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=x2L+37i8jlKCOYpFtoSV73Llb8PTdNEgCGli07Ytw6Q=; b=u2+rqaQ9VpT87e6nLJfedd/KuWbiYvGgpNawWc7KyiV4hN43b4ABvvwvEvD3ACEa47Yn+Z kCwV6nfN4q3+2TjJMcfgkTNp7q5hhqFRPCqbXLcdy/X2gjxU6xkpXr17RYNHPV1vbt0qub Ikzhcc6zHNoyoFxpnYlYXo8DlgXt1O6PZSNGM/SHBJmWZmCk5yToQhJpZO5xpvi85SutFQ 9SZ9sp5nz2QpzEz5XCS/gHqtRVPRauXx+32zysMd0wcw/exxOmCyW+ru2z8GSBM5eACYZI JPHYxwKF0tE5uEEcy38twjsbgaeYVUSKErIA95lGkBXlq01pN+YzJv6MUgK8OA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652622794; a=rsa-sha256; cv=none; b=hTzG6g257ZJZTzKeQ8rh0MFR1pcWwf9ZNiXvuZCPeBdik7mUhGPNeUaj1dPZsthVJBy0ac B6GjKZa4HW+azcwkZPWMKNayCxIw4144hf+iNj5Glv1v1n1sRLg1BccipONoOkiH+Bo7hy WxmJmdq1NbGXihvPYqmPwWWS6YuQJ/KZeLUZw+sYgODSmAZfYMhhXSq8jlVMCwMVXA8xr1 xeWvZyZ9cHXC0f1gnNYNj0EYU7xKRgwvVDMvD0NPFxdN4zhgJvgnMVDHEoXBpRCb7KuOxQ HcTSJAkZAaDGnHXTpbqX/vDICJsm/lwL23JKtHQYnDt9mSYTrc3yOjBjtfrZSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=lZ3ny04H; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=lZ3ny04H; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D0EA2C4A5 X-Spam-Score: 2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: kAtxb26hpf+T --=-=-= Content-Type: text/plain Hi! Ryan Sundberg via Guix-patches via writes: > [[PGP Signed Part:Undecided]] > Hello all, here is a revised version of zamfofex's patch that inherits > from node-14. I tried to trim as much fat out as possible in the > inherited node-(16-)lts, but some of the package arguments were > divergent in minor ways. I also bumped the version to 16.5.0 in the > meantime. The patch LGTM, however when testing it out I wasn't able to build node packages, I get the following error for example: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build node-string-decoder ... starting phase `install' npm info using npm@8.5.5 npm info using node@v16.15.0 npm timing npm:load:whichnode Completed in 1ms npm timing config:load:defaults Completed in 1ms npm timing config:load:file:/gnu/store/4iqwfsbapa3lhhap1jyg0bry8d1373li-node-16.15.0/lib/node_modules/npm/npmrc Completed in 2ms npm timing config:load:builtin Completed in 2ms npm timing config:load:cli Completed in 3ms npm timing config:load:env Completed in 0ms npm timing config:load:project Completed in 1ms npm timing config:load:file:/tmp/guix-build-node-string-decoder-1.3.0.drv-0/npm-home-0/.npmrc Completed in 2ms npm timing config:load:user Completed in 2ms npm timing config:load:file:/gnu/store/72cb549aap0inzc8d0v959w6z8qz964m-node-string-decoder-1.3.0/etc/npmrc Completed in 0ms npm timing config:load:global Completed in 1ms npm timing config:load:validate Completed in 0ms npm timing config:load:credentials Completed in 0ms npm timing config:load:setEnvs Completed in 1ms npm timing config:load Completed in 11ms npm timing npm:load:configload Completed in 11ms npm timing npm:load:setTitle Completed in 0ms npm timing config:load:flatten Completed in 1ms npm timing npm:load:display Completed in 5ms npm timing npm:load:logFile Completed in 4ms npm timing npm:load:timers Completed in 0ms npm timing npm:load:configScope Completed in 0ms npm timing npm:load Completed in 21ms npm timing arborist:ctor Completed in 1ms npm timing idealTree:init Completed in 4ms npm timing idealTree:userRequests Completed in 42ms npm timing idealTree:#root Completed in 19ms npm timing idealTree:node_modules/string_decoder Completed in 3ms npm timing idealTree:node_modules/string_decoder/node_modules/safe-buffer Completed in 0ms npm timing idealTree:buildDeps Completed in 24ms npm timing idealTree:fixDepFlags Completed in 0ms npm timing idealTree Completed in 73ms npm timing reify:loadTrees Completed in 74ms npm timing reify:diffTrees Completed in 1ms npm timing reify:retireShallow Completed in 1ms npm timing reify:createSparse Completed in 0ms npm timing reify:trashOmits Completed in 0ms npm timing reify:loadBundles Completed in 0ms npm timing reify:audit Completed in 0ms npm timing reifyNode:node_modules/string_decoder/node_modules/safe-buffer Completed in 8ms npm timing reifyNode:node_modules/string_decoder Completed in 12ms npm timing reify:unpack Completed in 13ms npm timing reify:unretire Completed in 0ms npm timing build:queue Completed in 1ms npm timing build:deps Completed in 1ms npm timing build:queue Completed in 0ms npm timing build:links Completed in 1ms npm timing build Completed in 2ms npm timing reify:build Completed in 2ms npm timing reify:trash Completed in 0ms npm timing command:install Completed in 98ms npm ERR! Cannot set properties of null (setting 'dev') npm timing npm Completed in 279ms npm ERR! A complete log of this run can be found in: npm ERR! /tmp/guix-build-node-string-decoder-1.3.0.drv-0/npm-home-0/.npm/_logs/2022-05-15T13_47_30_141Z-debug-0.log error: in phase 'install': uncaught exception: %exception #<&invoke-error program: "/gnu/store/4iqwfsbapa3lhhap1jyg0bry8d1373li-node-16.15.0/bin/npm" arguments: ("--prefix" "/gnu/store/72cb549aap0inzc8d0v959w6z8qz964m-node-string-decoder-1.3.0" "--global" "--offline" "--loglevel" "info" "--production" "install" "../package.tgz") exit-status: 1 term-signal: #f stop-signal: #f> phase `install' failed after 0.4 seconds command "/gnu/store/4iqwfsbapa3lhhap1jyg0bry8d1373li-node-16.15.0/bin/npm" "--prefix" "/gnu/store/72cb549aap0inzc8d0v959w6z8qz964m-node-string-decoder-1.3.0" "--global" "--offline" "--loglevel" "info" "--production" "install" "../package.tgz" failed with status 1 builder for `/gnu/store/6a1vjam7gx0znrr8yngaw2lqld9868l0-node-string-decoder-1.3.0.drv' failed with exit code 1 build of /gnu/store/6a1vjam7gx0znrr8yngaw2lqld9868l0-node-string-decoder-1.3.0.drv failed View build log at '/var/log/guix/drvs/6a/1vjam7gx0znrr8yngaw2lqld9868l0-node-string-decoder-1.3.0.drv.gz'. guix build: error: build of `/gnu/store/6a1vjam7gx0znrr8yngaw2lqld9868l0-node-string-decoder-1.3.0.drv' failed --8<---------------cut here---------------end--------------->8--- I'm a bit clueless as to what's happening, it could be a flavour of this issue upstream: https://github.com/npm/cli/issues/3847 So hopefully this will be resolved with a new node release, in the meantime, we could still package node 16 but not make it the default node for the build-system, WDYT? I'd suggest to keep the node-lts pointing to the node-14 version. Also, as an aside, I'm afraid the patch doesn't allow node to be cross-compiled, but that's also currently broken on master so we could fix that as a follow-up IMO. Thanks for working on this! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmKBBYsYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UOsEIAJ+2ImfKEKo9BygwmSCTAs3x /k8fNrta0E3GvbsFYTXd3CTV+DoX5pSwgCWkndc3Rtu3gYiA1mT6gdOOZCoPIv0C XkXBwVwEjxxjCf2L/eWPrlXXBnTvMl6F5lFHUBKd585ihUbRC2T2vlPOwBJoIkaQ G9lerp0uR9w3xSilNrufboVy4BzdZJ9ByQKMlaww5yT2AWD//TlRR76coSNQbjjf QjBdlcOtWSAZME+6KoLTZoU8460djBUWzk4lFPAoEWf7chNV+SObFqgbBtTSdfK/ RmlkG0iHjk8I1KS9746tfspsMsAP105O1kWpV1BsXf4NEB3PytawLO2mU5/3LCs= =58t7 -----END PGP SIGNATURE----- --=-=-=--