From: Olivier Dion via <gwl-devel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: gwl-devel@gnu.org
Subject: Re: [PATCH] gwl/ui: Check for log-events configuration
Date: Sat, 04 Jun 2022 11:10:42 -0400 [thread overview]
Message-ID: <874k10xy4t.fsf@laura> (raw)
In-Reply-To: <875ylg5v60.fsf@elephly.net>
On Sat, 04 Jun 2022, Ricardo Wurmus <rekado@elephly.net> wrote:
> Olivier Dion <olivier.dion@polymtl.ca> writes:
>
>> Some GWL sub-commands such as `graph' do not accept a log event configuration.
>> This results in returning `#f' from `(%config 'log-events)'
>
> I don’t understand how this leads to a problem. Do any of the features
> of “graph” use “log-event”?
Yes. `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info
"Loading workflow file"'.
> Generally, I’d prefer to give “log-events” a better default. I can’t
> imagine a situation where #F (rather than the empty list) would be
> appropriate.
The empty list would be a more sane choice I agree. I'll send a v2 with
this change. Also, the `print?` predicate could be memoize with `mlambda'?
--
Olivier Dion
oldiob.dev
next prev parent reply other threads:[~2022-06-04 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 18:32 [PATCH] gwl/ui: Check for log-events configuration Olivier Dion
2022-06-04 15:00 ` Ricardo Wurmus
2022-06-04 15:10 ` Olivier Dion via [this message]
2022-06-06 10:32 ` Ricardo Wurmus
2022-06-06 13:25 ` Olivier Dion via
2022-06-06 18:51 ` Olivier Dion via
2022-06-06 19:48 ` [PATCH 1/3] " Olivier Dion
2022-06-06 19:48 ` [PATCH 2/3] gwl/config: Share log-event switch with subcommands Olivier Dion
2022-06-12 9:03 ` Ricardo Wurmus
2022-06-06 19:49 ` [PATCH 3/3] graph: Add output switch Olivier Dion
2022-06-12 9:05 ` Ricardo Wurmus
2022-06-12 9:08 ` [PATCH 1/3] gwl/ui: Check for log-events configuration Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k10xy4t.fsf@laura \
--to=gwl-devel@gnu.org \
--cc=olivier.dion@polymtl.ca \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.