From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iHRdFFDPQ2NlKgEAbAwnHQ (envelope-from ) for ; Mon, 10 Oct 2022 09:52:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SHeBFFDPQ2N+mQAA9RJhRA (envelope-from ) for ; Mon, 10 Oct 2022 09:52:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A231F9F5 for ; Mon, 10 Oct 2022 09:52:48 +0200 (CEST) Received: from localhost ([::1]:60764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohnah-0001ik-BH for larch@yhetil.org; Mon, 10 Oct 2022 03:52:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnZy-0001hK-UO for guix-patches@gnu.org; Mon, 10 Oct 2022 03:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohnZy-0004xj-K0 for guix-patches@gnu.org; Mon, 10 Oct 2022 03:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohnZy-0005mI-Eh for guix-patches@gnu.org; Mon, 10 Oct 2022 03:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58231] [PATCH 0/2] Checking the 'license' field of packages Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Oct 2022 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58231@debbugs.gnu.org Received: via spool by 58231-submit@debbugs.gnu.org id=B58231.166538830522188 (code B ref 58231); Mon, 10 Oct 2022 07:52:02 +0000 Received: (at 58231) by debbugs.gnu.org; 10 Oct 2022 07:51:45 +0000 Received: from localhost ([127.0.0.1]:45780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnZg-0005lg-Ts for submit@debbugs.gnu.org; Mon, 10 Oct 2022 03:51:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnZe-0005lQ-Bp for 58231@debbugs.gnu.org; Mon, 10 Oct 2022 03:51:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnZX-0004uI-De for 58231@debbugs.gnu.org; Mon, 10 Oct 2022 03:51:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NTC+y0af76a99/Qw0LRFL1I3GzQyjjwV1+6vMzD8Uj0=; b=PqxfvmBNlLSjhGsbTwtM vLrt1n8eJ/6VUhGwWOFfxESVLMvDWpnVv1X2PcCLGtsQx2Su7mHCzoXUST+Cos97+VfiQIV5mIng1 99XrDTpMokMXO7xIC0iPQ0K73HBIzm9qIaDwGu+ipbbQbAG3NhqzSSHP9pRsUuQh/z3A1XxEhTKrR 5T5HJHELY7ol8QHp08ZvzC1GlpzZMTpPPpP2BLwVheBZ8Ha6GPpnDQtTbt/pFO9AnOYnSYoAflGdV pO1LNq8K4lyfZPTQXrGoWXKBZyMfWts5Vr/Dyz40kPn/i0H7Ve0SZ0NToFdbVEQqnYn//SFd5dF4d R/OiQf/6v3JLRA==; Received: from [193.50.110.253] (port=38174 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnZW-0003Nx-WD for 58231@debbugs.gnu.org; Mon, 10 Oct 2022 03:51:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221001161911.8116-1-ludo@gnu.org> Date: Mon, 10 Oct 2022 09:51:32 +0200 In-Reply-To: <20221001161911.8116-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 1 Oct 2022 18:19:11 +0200") Message-ID: <874jwc5d6j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665388368; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NTC+y0af76a99/Qw0LRFL1I3GzQyjjwV1+6vMzD8Uj0=; b=UX6XoUJ5Bd+Iu9nlBLZ/j19J4QHGzwLzIac78Ag1kO11yZ9BoHaAgCfgBOIytDvH396H7d QaMKPe5vkLlWM0xwFyN4D3yqHcPEV0d4J/e+Cazvbt44BjW6UB+iHL+19zavNpVyO+UkTl +g8gBMND8yXaGz8wgW+iAWHF5xZIwxFK1a7M3pR2PHPjJLMYAosmx6qKvbiUpywTvVYKnl Bv0QBxGhptS26Ltn1haULBFTq6QIlHHGPhI6mlM2fna0iF2EupJhL+1DnLHSGWrRQj4BCr Xep+EI8yH7W4awuhw/rGkjMOQ+f0fQgLiwYcRfyuAdg636RMebLX1kQa9rjQcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665388368; a=rsa-sha256; cv=none; b=dldGVuUawbcqsf19pOgyFGtb3M8UkBYooTaYGhqRbJsuvZHt9T2iUm/MAfy9XtCVtvt41x F9aXrw9TWup43OpVc5yK8ocMuYRw+OVoACHfzIcF48mFYnjVEy5e/fCcF8ym+dWv9F5gWK RVIFj6sQYh1/z+fclgmYtNtSUzh1MUuJal17HqXSedf3JHqUVXDpnh40D1TJ1TdgAOadDZ kKybtLJw/xIR1iym+KeucvNQU01hpiw0v03rK4hDBes11WfO3ZVvdmXdaRvapO8su6QUvV Leu1m7w+hA/fes+pakbiEf2+QhWkXXgiAob2ZT9U359jh1QLrSQgxykDh9H4Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PqxfvmBN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PqxfvmBN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2A231F9F5 X-Spam-Score: -4.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: nN07DvtuJtks Ludovic Court=C3=A8s skribis: > The funny part of this patch is that the license validation expands > to #t in the majority of cases, meaning that it comes without > run-time overhead (there is macro-expansion overhead, but I didn=E2=80=99t > measure it). A quick measurement of the time taken by the =E2=80=9CComputing Guix deriva= tion=E2=80=9D step=C2=B9 (most of which is macro expansion) suggests it=E2=80=99s going f= rom ~1m34s to ~1m44s on my laptop=E2=80=94so roughly a 10% slowdown on this stage. I guess that=E2=80=99s the price to pay. That phase has always been very slow though, mostly due to psyntax, and we need to do something about it anyway. Ludo=E2=80=99. =C2=B9 I ran =E2=80=98time guix time-machine --branch=3Dwip-license-checks = --url=3D$PWD=E2=80=99 and similar for the commit before those changes.