From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sJSbKcovQ2P3QQEAbAwnHQ (envelope-from ) for ; Sun, 09 Oct 2022 22:32:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yLOqKcovQ2PGWQAA9RJhRA (envelope-from ) for ; Sun, 09 Oct 2022 22:32:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F7369513 for ; Sun, 9 Oct 2022 22:32:10 +0200 (CEST) Received: from localhost ([::1]:49712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohcy1-0002cv-Mf for larch@yhetil.org; Sun, 09 Oct 2022 16:32:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohcxu-0002cZ-HU for guix-patches@gnu.org; Sun, 09 Oct 2022 16:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohcxu-0002Vq-9i for guix-patches@gnu.org; Sun, 09 Oct 2022 16:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohcxu-0005UR-4h for guix-patches@gnu.org; Sun, 09 Oct 2022 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 Oct 2022 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58123 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= Cc: maximedevos@telenet.be, 58123@debbugs.gnu.org Received: via spool by 58123-submit@debbugs.gnu.org id=B58123.166534749821074 (code B ref 58123); Sun, 09 Oct 2022 20:32:02 +0000 Received: (at 58123) by debbugs.gnu.org; 9 Oct 2022 20:31:38 +0000 Received: from localhost ([127.0.0.1]:45002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohcxV-0005Tp-Hr for submit@debbugs.gnu.org; Sun, 09 Oct 2022 16:31:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohcxU-0005Tb-8V for 58123@debbugs.gnu.org; Sun, 09 Oct 2022 16:31:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohcxO-0002Tt-OT; Sun, 09 Oct 2022 16:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OGHX91I8IIXGg4rCQ9gPmL/1XmPaRorT2nPtPSsQ6fs=; b=Svs+lhltCyxpMIpR4Lar 8ODr7K3RVEDzN7OJnqIwcsZDNSJ1t38zULxchboGdC7Cio4UIiWO7HDzTsBsDw1kkkTC9BlDf30s6 7BCnNTXYF5R3oDspz/bx++VXOypkCJjnqHD0mc07vwTq4gfEV4PR2+1+OqZ/mUh0YpBQOvctn89OJ Sq6z45i3AeEdXRwyrLbhWJ51Yn7gIS86RD8MqLwuPpDR726AUuXCmdPV8q5srVHkq92JfGp283gax 9aj8nkfJAxr20WsM0nvMASVau/DQWEGFZK6UhOBnye8eroLWAA3cBnL8JLpzA4iCyRUuQTkCNIFe+ KdG+2i2G+UmF2Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59572 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohcxN-0005lk-D9; Sun, 09 Oct 2022 16:31:30 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r0zwr9dv.fsf@disroot.org> <87mtae9d0t.fsf@disroot.org> Date: Sun, 09 Oct 2022 22:31:27 +0200 In-Reply-To: <87mtae9d0t.fsf@disroot.org> ("=?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?="'s message of "Sun, 02 Oct 2022 22:38:42 +0200") Message-ID: <874jwc4u3k.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665347530; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OGHX91I8IIXGg4rCQ9gPmL/1XmPaRorT2nPtPSsQ6fs=; b=PkPxb714WKlUGQ9HK3dtc3EJo8tKYukFRmGQeF0aDcN6b+s/nBLEEvSd272GVWUIwQNzj7 M7PkU/ZYfMYQCx42MMifvrJMMFKrwBcp+C4+lXZhXyToFnkPT37Fis6gyj7Z4y/Nqwe/r4 fyUUYoriv1NiYAPQhxaPXHgz0ea6lc+pChFQQHP02UCTpJYqwl4XrbQ3XqsgAXjevwggXe g4txLgpWSb3GydFVH/V0kxzQ35e5zN+5KgZa9tJGBVWQ+4Z8r8QvhSbWmMOQ9+qnoSJFGy pfkLoQrv62s6/x9x3nPburmrlLNbKOsSxvmzkAurivt8YLw9yIJgcjLDA+Mpig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665347530; a=rsa-sha256; cv=none; b=pteZxBM23fbu3qfsJYxe/Y1V7y9u2Pljml5fFc+afdqltA0lstVO57qD7+ZI57kMUquS2B ryBShMSZwip3HMwOVyYw+ODEf5EJlL4hVrG+Pt0k/nr6K/DPU3/pHzEQ7RAKwTMXxWKhDc EhwM0acv0vfiKZJWpOihgWiCD2AmDoEeD9xKn1DYpKufT30ahqIJbSdO+ZwUzSndgSS9jN UW/ZDsQF6zFU4EdP4ztETOjbHFNNhJnoBLb/TnuSgCVZOA56jH7x2kSDogYP9V4s03znNB HpqwDtaJAf2vfZrzofM22OCY5pGbPIe2anXJT/ptArAJkjQNr60cEnOxp6Dn7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Svs+lhlt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Svs+lhlt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6F7369513 X-Spam-Score: -2.88 X-Migadu-Scanner: scn0.migadu.com X-TUID: qtM77SDHeiFf Hi M=C3=A1ja, M=C3=A1ja Tom=C3=A1=C5=A1ek skribis: > I have applied the changes as you suggested. Thank you for your (as you > said) "superficial comments", they were really helpful! And I am happy > that you made them, as I'm sometimes too happy that I have made a > contribution and I forget that I don't write only for myself, but for > others. Thanks for the nice and useful service! It looks pretty good already (in part thanks to Maxime=E2=80=99s guidance := -)). I would have two more asks: 1. Could you update doc/guix.texi to document the new service? You can mostly use =E2=80=98generate-documentation=E2=80=99 to produce the= reference of the configuration record, and then add a paragraph giving some context and a documented example. 2. Could you add a test under (gnu tests *)? That would ensure the service does not bitrot going forward. Let us know if you need guidance on these things. When you=E2=80=99re done, please send an updated patch with those changes here. Thank you! Ludo=E2=80=99.