From: "Ludovic Courtès" <ludo@gnu.org>
To: "Mája Tomášek" <maya.tomasek@disroot.org>
Cc: maximedevos@telenet.be, 58123@debbugs.gnu.org
Subject: [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type
Date: Sun, 09 Oct 2022 22:31:27 +0200 [thread overview]
Message-ID: <874jwc4u3k.fsf_-_@gnu.org> (raw)
In-Reply-To: <87mtae9d0t.fsf@disroot.org> ("Mája Tomášek"'s message of "Sun, 02 Oct 2022 22:38:42 +0200")
Hi Mája,
Mája Tomášek <maya.tomasek@disroot.org> skribis:
> I have applied the changes as you suggested. Thank you for your (as you
> said) "superficial comments", they were really helpful! And I am happy
> that you made them, as I'm sometimes too happy that I have made a
> contribution and I forget that I don't write only for myself, but for
> others.
Thanks for the nice and useful service!
It looks pretty good already (in part thanks to Maxime’s guidance :-)).
I would have two more asks:
1. Could you update doc/guix.texi to document the new service? You
can mostly use ‘generate-documentation’ to produce the reference of
the configuration record, and then add a paragraph giving some
context and a documented example.
2. Could you add a test under (gnu tests *)? That would ensure the
service does not bitrot going forward.
Let us know if you need guidance on these things. When you’re done,
please send an updated patch with those changes here.
Thank you!
Ludo’.
next prev parent reply other threads:[~2022-10-09 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 17:16 [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type guix-patches--- via
2022-09-29 18:31 ` Maxime Devos
2022-09-30 13:40 ` guix-patches--- via
2022-09-30 18:47 ` Maxime Devos
2022-09-30 18:48 ` Maxime Devos
2022-10-02 20:38 ` [bug#58123] guix-patches--- via
2022-10-09 20:31 ` Ludovic Courtès [this message]
2022-10-11 18:04 ` [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type guix-patches--- via
2022-10-13 13:05 ` Ludovic Courtès
2022-12-01 15:59 ` Ludovic Courtès
2022-12-15 21:07 ` guix-patches--- via
2023-12-20 21:48 ` Sergey Trofimov
2024-01-08 16:29 ` bug#58123: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jwc4u3k.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=58123@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=maya.tomasek@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.