all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: ludo@gnu.org, 57963@debbugs.gnu.org,
	Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#57963] Almost plain SXML serializer
Date: Wed, 12 Oct 2022 17:03:27 +0400	[thread overview]
Message-ID: <874jw9mbxc.fsf@trop.in> (raw)
In-Reply-To: <87a661i7zm.fsf@taiju.info>

[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]

On 2022-10-12 20:42, Taiju HIGASHI wrote:

> Andrew Tropin <andrew@trop.in> writes:
>
>> On 2022-10-11 06:21, Liliana Marie Prikler wrote:
>>
>>> Am Dienstag, dem 11.10.2022 um 12:54 +0900 schrieb Taiju HIGASHI:
>>>> We can specify invalid value such as (list "foo" '(foo bar) 123).
>>> It will be sanitized before that.
>>>
>>>> > Also, making multi-type fields is debatable, but isn't great IMO.
>>>>
>>>> I see. If we had to choose one or the other, I would prefer the
>>>> string-type field.
>>> Prefer sexp-type.
>>>
>>
>> Current (v5) extra-config has a list type.  This list can contain strings
>> and nested lists, string elements are for raw XML, and list
>> elements are for SXML.
>>
>> This is done I guess to support following use case:
>>
>> (list "<tag>Already existing XML copied from existing .xml file, which
>> we don't want to rewrite to SXML.</tag>"
>>       '((tag (@ (attr1 "value1")
>>                 (attr2 "value2"))
>>              (nested "Part of the configuration defined with SXML")
>>              (empty)))
>>       "<another-tag>Maybe some other part of raw XML</another-tag>")
>>
>> This way we can combine SXML with already existing raw XML.
>>
>> Am I right?
>
> You're right.  The current implementation allows XML string and SXML
> list in the list.  Also, it can mix those.
>

Ok, that means we can cover this use case, but at the same time have
more functionality, clarity and consistency.

We can make extra-config to be SXML only (with G-exps support), this way
we will achieve not only the same functionality, but will get more
advanced features like referencing files/directiories in the /gnu/store
or generating parts of configuration using full-fledged scheme (the
simpliest example is just reading the content of the existing file-like
object or using format to generate "raw XML" and insert it in arbitrary
place of SXML tree).

--8<---------------cut here---------------start------------->8---
(list #~"<tag>Already existing XML copied from existing .xml file, which
we don't want to rewrite to SXML.</tag>"
      `((tag (@ (attr1 "value1")
                (attr2 "value2"))
             (nested "Part of the configuration defined with SXML")
             ,#~(format #f "    <nested-tag>~a</nested-tag>" #$variable)
             (fontdirs
              (dirs ,(file-append font-iosevka "/share/fonts")))
             (empty)))
      #~(call-with-input-file #$(local-file "old.xml") get-string-all)
      #~"<another-tag>Maybe some other part of raw XML</another-tag>")
--8<---------------cut here---------------end--------------->8---

Liliana, Ludo what do you think?

>>>> > If serialization would support G-exps, we could write
>>>> >
>>>> > (list #~"RAW_XML_HERE")
>>>> >
>>>> > or even something like this:
>>>> >
>>>> > (list #~(READ-THE-WHOLE-FILE #$(local-file "our-old.xml")))
>>>>
>>>> Does it mean that the specification does not allow it now? Or does it
>>>> mean that it is not possible with my implementation?
>>> I think your serialize would have to unpack the G-Expressions.  You can
>>> test that with some example configs of your own.
>>>
>>>> >
>>> Cheers
>
> Thanks,

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2022-10-12 13:05 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  0:27 [bug#57963] [PATCH 0/1] Support user's fontconfig Taiju HIGASHI
2022-09-21  0:29 ` [bug#57963] [PATCH 1/1] home: fontutils: " Taiju HIGASHI
2022-09-21  8:54   ` Liliana Marie Prikler
2022-09-21  9:59     ` Taiju HIGASHI
2022-09-21 11:40       ` Liliana Marie Prikler
2022-09-22  1:27         ` Taiju HIGASHI
2022-09-23  7:20           ` Liliana Marie Prikler
2022-09-22  1:20 ` [bug#57963] [PATCH v2] " Taiju HIGASHI
2022-09-22  6:14   ` Andrew Tropin
2022-09-22  8:53     ` Ludovic Courtès
2022-09-22  9:50       ` Taiju HIGASHI
2022-09-24 15:52         ` [bug#57963] [PATCH 0/1] " Ludovic Courtès
2022-09-24 22:58           ` Taiju HIGASHI
2022-09-25  6:25             ` Liliana Marie Prikler
2022-09-25  7:29               ` Taiju HIGASHI
2022-09-25  7:34                 ` Taiju HIGASHI
2022-09-25 15:50                 ` Liliana Marie Prikler
2022-09-26  1:43                   ` Taiju HIGASHI
2022-09-26 18:19                     ` Liliana Marie Prikler
2022-09-27  9:55 ` [bug#57963] [PATCH v3] home: fontutils: " Taiju HIGASHI
2022-09-27 10:10   ` Taiju HIGASHI
2022-09-28 21:15     ` [bug#57963] [PATCH 0/1] " Ludovic Courtès
2022-09-29  1:01       ` Taiju HIGASHI
2022-09-29 14:28         ` Ludovic Courtès
2022-09-29 14:51           ` Taiju HIGASHI
2022-09-29 16:02             ` ( via Guix-patches via
2022-09-30  0:12               ` Taiju HIGASHI
2022-09-30 18:30             ` liliana.prikler
2022-10-01 11:11               ` Taiju HIGASHI
2022-09-28 19:11   ` [bug#57963] [PATCH v3] home: fontutils: " Liliana Marie Prikler
2022-09-29  0:31     ` Taiju HIGASHI
2022-09-29 14:46       ` Taiju HIGASHI
2022-09-29 14:36 ` [bug#57963] [PATCH v4 1/2] home-services: Add base Taiju HIGASHI
2022-09-29 14:36   ` [bug#57963] [PATCH v4 2/2] home: fontutils: Support user's fontconfig Taiju HIGASHI
2022-09-29 14:55     ` Taiju HIGASHI
2022-09-30 18:34     ` liliana.prikler
2022-10-01 11:19       ` Taiju HIGASHI
2022-10-01 16:14         ` liliana.prikler
2022-10-02 13:22           ` Taiju HIGASHI
2022-10-01 21:57     ` Ludovic Courtès
2022-10-02 13:38       ` Taiju HIGASHI
2022-09-29 14:43   ` [bug#57963] [PATCH v4 1/2] home-services: Add base Liliana Marie Prikler
2022-09-29 15:09     ` Taiju HIGASHI
2022-09-30 18:21       ` liliana.prikler
2022-10-01 11:08         ` Taiju HIGASHI
2022-10-01 21:47   ` Ludovic Courtès
2022-10-02 13:45     ` Taiju HIGASHI
2022-10-02 14:59       ` Liliana Marie Prikler
2022-10-03 23:27         ` Taiju HIGASHI
2022-10-10  5:50         ` Andrew Tropin
2022-10-02 13:12 ` [bug#57963] [PATCH v5 1/2] home: services: " Taiju HIGASHI
2022-10-02 13:20   ` Taiju HIGASHI
2022-10-02 13:15 ` Taiju HIGASHI
2022-10-02 13:15   ` [bug#57963] [PATCH v5 2/2] home: services: Support user's fontconfig configuration Taiju HIGASHI
2022-10-10  6:40     ` Andrew Tropin
2022-10-10 16:15       ` Liliana Marie Prikler
2022-10-12  6:05         ` Andrew Tropin
2022-10-11  3:54       ` Taiju HIGASHI
2022-10-11  4:21         ` Liliana Marie Prikler
2022-10-11  8:09           ` Taiju HIGASHI
2022-10-11 18:24             ` Liliana Marie Prikler
2022-10-12  3:59               ` Taiju HIGASHI
2022-10-12  4:21                 ` Liliana Marie Prikler
2022-10-12  7:07           ` [bug#57963] Almost plain SXML serializer Andrew Tropin
2022-10-12 11:42             ` Taiju HIGASHI
2022-10-12 13:03               ` Andrew Tropin [this message]
2022-10-12 18:23                 ` Liliana Marie Prikler
2022-10-13  3:51                   ` Andrew Tropin
2022-10-12  6:43         ` [bug#57963] [PATCH v5 2/2] home: services: Support user's fontconfig configuration Andrew Tropin
2022-10-12 11:38           ` Taiju HIGASHI
2022-10-12 12:41             ` Andrew Tropin
2022-10-13 12:37       ` Ludovic Courtès
2022-10-14  5:06         ` Andrew Tropin
2022-10-15 11:13           ` Taiju HIGASHI
2022-10-17 16:28             ` Ludovic Courtès
2022-10-18 12:41               ` Taiju HIGASHI
2022-10-19 21:42                 ` Taiju HIGASHI
2022-10-20  1:23                   ` [bug#57963] [PATCH 0/1] Support user's fontconfig Declan Tsien
2022-10-20  1:37                     ` Taiju HIGASHI
2022-10-20  2:03                       ` Declan Tsien
2022-10-20  3:44                         ` Taiju HIGASHI
2022-10-20  5:06                           ` Declan Tsien
2022-10-21  1:02                             ` Taiju HIGASHI
2022-10-27  4:00                   ` [bug#57963] [PATCH v5 2/2] home: services: Support user's fontconfig configuration Taiju HIGASHI
2022-10-27  5:18                     ` Liliana Marie Prikler
2022-10-27  5:31                       ` Taiju HIGASHI
2022-10-27  6:36                         ` Liliana Marie Prikler
2022-11-02  1:43                           ` Taiju HIGASHI
2022-11-02  6:45                             ` Liliana Marie Prikler
2022-11-04  8:46                               ` Taiju HIGASHI
2022-11-04 16:29                                 ` ( via Guix-patches via
2022-11-06 13:24                                   ` Taiju HIGASHI
2022-10-20  5:40     ` Declan Tsien
2022-10-21  4:03       ` Taiju HIGASHI
2022-10-21  5:02         ` Declan Tsien
2022-10-21  8:01           ` Taiju HIGASHI
2022-10-21  9:15             ` Declan Tsien
2022-10-23  6:32               ` Taiju HIGASHI
2022-10-23  7:33                 ` Declan Tsien
2022-10-23 11:40                   ` Taiju HIGASHI
2022-10-07  5:20 ` [bug#57963] Next steps for this issue Taiju HIGASHI
2022-10-07  5:44   ` Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jw9mbxc.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=57963@debbugs.gnu.org \
    --cc=higashi@taiju.info \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.