From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SDneIjO9imOcewAAbAwnHQ (envelope-from ) for ; Sat, 03 Dec 2022 04:06:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aDnxITO9imPNCgEAG6o9tA (envelope-from ) for ; Sat, 03 Dec 2022 04:06:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5CF91DE1E for ; Sat, 3 Dec 2022 04:06:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Iqp-0007gW-DZ; Fri, 02 Dec 2022 22:06:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Iqo-0007gL-NZ for bug-guix@gnu.org; Fri, 02 Dec 2022 22:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Iqo-0002gm-FO for bug-guix@gnu.org; Fri, 02 Dec 2022 22:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Iqo-0003G8-3t for bug-guix@gnu.org; Fri, 02 Dec 2022 22:06:02 -0500 Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sat, 03 Dec 2022 03:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Pierre Langlois , 59423-done@debbugs.gnu.org Mail-Followup-To: 59423@debbugs.gnu.org, maxim.cournoyer@gmail.com, pierre.langlois@gmx.com Received: via spool by 59423-done@debbugs.gnu.org id=D59423.167003672312512 (code D ref 59423); Sat, 03 Dec 2022 03:06:01 +0000 Received: (at 59423-done) by debbugs.gnu.org; 3 Dec 2022 03:05:23 +0000 Received: from localhost ([127.0.0.1]:50450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1IqA-0003Fk-TN for submit@debbugs.gnu.org; Fri, 02 Dec 2022 22:05:23 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:41865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Iq7-0003Fa-Ku for 59423-done@debbugs.gnu.org; Fri, 02 Dec 2022 22:05:21 -0500 Received: by mail-qv1-f51.google.com with SMTP id d13so4661619qvj.8 for <59423-done@debbugs.gnu.org>; Fri, 02 Dec 2022 19:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DjwmKcT4HFr8RE8NSGx63jE/GWoowcBi9VMLufi0/g0=; b=etFs5c0mzn6yMCXxhsm/d3pkiYGyzUkicCZsd70yonvyggsWzZCWcunCgSniDXfFr0 cR17dOIRnw1++MRjPBGjHPbL4IudmP6pj8zrckScY7FM7e4AY2w3pQrgQxHtHavy+YaW Z1F0Zp8DbLznbxMkM2Nq4J2Q88bXA66glWgKNVHpwEvfsah+Rf3odaOlGzQ5s6DtYzlx kLkLWM7dO/4M6wZfpRWkreCHyvzvRwZYzMYA23ND1JpZbKlf01DuoM2JxrhZoUuJQIWD 0ZcYpXM498/Jp1bOyZl0Z6CwQaRXdjx5fYQhrOZZYhSr2Ro/QoiVVwc3MsaYPni3cCeW ZwZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DjwmKcT4HFr8RE8NSGx63jE/GWoowcBi9VMLufi0/g0=; b=Tl19BU7Txz4vuRfzLE1MmC/030SFxXbhYZdFsfuROY/R2Phq5gFxBD+Aoik1XaXLUE Rfuh6JY0WoFcvWPp/GnPzfdpUBt2ZtP7r826vhFMmgAVl9onhI8gWyUQai9r/nDBEFk0 o6Bhq5lPq3Pt7e62QtBzyvRn9Jjg64QQwLUcGVG0ek7YWUwYLBpgHqv/18j55GCksbt4 5y9XeBKXsnJZgd/16Cn1OTQD0Hxzx0wXWAsQPAs8GjmpE3sTdHfoH30Ad+x0P2qCgmOZ ZOf8xZU9/pHe0z3F/Rj6u5R3D/6Warw4R3DUo/a+Gm2qcb2DW8btAiRZ9wZ9pPqcs7tv hVmA== X-Gm-Message-State: ANoB5pmenKvraUGsZGXICaXTa9f8U7m68OAfJs5rdN1TnV0IK0vNjvwI aKfZS7JyO4Xvpk+XUHrl5szt60tGk4w= X-Google-Smtp-Source: AA0mqf4O/psV+ifc/9Go/yxc5vEbJ5zWGn4dgVzGaQM+WCxJCTDGXGliCiclv4MPIiJ7qtnzoM+gpQ== X-Received: by 2002:ad4:5402:0:b0:4c7:2804:d69a with SMTP id f2-20020ad45402000000b004c72804d69amr10630602qvt.21.1670036713751; Fri, 02 Dec 2022 19:05:13 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id az20-20020a05620a171400b006e42a8e9f9bsm6730252qkb.121.2022.12.02.19.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 19:05:13 -0800 (PST) From: Maxim Cournoyer References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> <87fse6fmrq.fsf@gmail.com> <87cz995wwu.fsf@gmx.com> <87o7stw2gz.fsf@gmail.com> <87pmd7ceck.fsf@gnu.org> <87sfi2svb9.fsf@gmail.com> <8735a2ahmi.fsf@gnu.org> <87a64aseqm.fsf@gmail.com> <87iliuup80.fsf@gnu.org> <878rjpqzbi.fsf@gnu.org> Date: Fri, 02 Dec 2022 22:05:12 -0500 In-Reply-To: <878rjpqzbi.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 02 Dec 2022 22:18:41 +0100") Message-ID: <874judgpav.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670036787; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DjwmKcT4HFr8RE8NSGx63jE/GWoowcBi9VMLufi0/g0=; b=MwBuesDTHHffBjPxcwruA0xULM+G1PZuYcHl4/qt2rcUC+EKhO4dzqEkJy5HHVCG502bbN 852JjIoAI8l3qrqYQ7ixlvpGJH6VrMHWi+ndJfydpKPP/CRvYwWMmok7FrPco3Sp9BjddP ZsgronrbAMwHiShZErrq9m9kqV+hBANsMYmok9dEAZDAuvdD1D76m6YHyOLfcZYPhXH9Uv FjSNhlPlSPnwwzJORHtOh84UGcKIyBQW5DbeiOUMRPXMiUKhhUJHAHHYS8cfaZcmxi1K+r xTDUOuxqMTcu9xB4S4g3jWol5X0jb/YGlfhvjWtqgYTgcVUVxj5sIiQcJzVSXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670036787; a=rsa-sha256; cv=none; b=trNwxNJskx/JN4ezNal6C+4NgZaVlnnovkKOZm45a2FnSUEBJHYCixCr7r+BBYK1KugXCW U0Ua10HnZePYzZXfSKNcT56bNnU6as+V6iZvZvUMqxOzJiggMkGuV4GPN/9sKRxMK+csfC zbzU5yciyXdIY782NZ6NB1mDRP1c2ifxjmBfsdLEN0t+WCWJrWujdwXxCdLXnsRMHM4UX9 zYJwVvntoNNXXT0ao/dapsJ/CWKSNy5UdjPM6smmciuMA4QRN1uOwULlkhDJPd8dwaLiKZ vcu3ZOu2mLuQGRbu05KVpo0LGjOnDrxZAxy17jofJc+Qm8hsoipGB+FVKmPeQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=etFs5c0m; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=etFs5c0m; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5CF91DE1E X-Spam-Score: 7.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: SCc1XFNVrKeN Hi Ludovic, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> Maxim Cournoyer skribis: > > [...] > >>> No :-). I meant why do we even set a default accessor for the *source >>> location* information (in the (gnu service configuration) macros); it's >>> that one that doesn't seem to get used (or I'm blind to it!), at least >>> via this accessor. If it's not strictly necessary, we can stop >>> producing it, and that would solve the problem. >> >> Like I wrote, I think it=E2=80=99s necessary, even if not used now. > > To complement this answer: key high-level record types usually have a > =E2=80=98location=E2=80=99 field: , , , = , > , etc. The rationale is that it allows us to report > accurate location info for errors and warnings, to jump to their > definition, and so on. > > For configuration records this is not a common pattern, but the > rationale holds. =E2=80=98zabbix-front-end-config=E2=80=99 uses the =E2= =80=98%location=E2=80=99 field, > but it seems to be the only one so far. Thanks for this extra bit of information and for spotting this usage. I think "location" is likely to conflict for the general purpose 'define-configuration' generated records, so I've renamed the "location" *accessor* to "source-location". In the near future I want to migrate more service configurations to the 'define-configuration' machinery, to benefit from its useful self-validating property. For now I wouldn't feel at ease doing so unless raw record matching (not yet using 'match-record') works the same way, since we still have many occurrences making use of that (often via match-lambda). For that reason, I prefer to not revert the record layout until we've gotten rid of all the match-lambda matching record fields directly (which will take some time). I've applied the rename fix to master. --=20 Thanks, Maxim