All updaters are broken

[Ricardo Wurmus <rekado@elephly.net>]

Hi Guix,

Running “guix refresh -t cran -u” I get this error:

--8<---------------cut here---------------start------------->8---
Backtrace:
In ice-9/boot-9.scm:
  1752:10 18 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In unknown file:
          17 (apply-smob/0 #<thunk 7f0061a232e0>)
In ice-9/boot-9.scm:
    724:2 16 (call-with-prompt _ _ #<procedure default-prompt-handler (k proc)>)
In ice-9/eval.scm:
    619:8 15 (_ #(#(#<directory (guile-user) 7f0061a28c80>)))
In guix/ui.scm:
   2276:7 14 (run-guix . _)
  2239:10 13 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 12 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
  1752:10 11 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In guix/store.scm:
   661:37 10 (thunk)
In guix/monads.scm:
    576:2  9 (run-with-store #<store-connection 256.99 7f0056ccd550> #<procedure 7f005cae7a60 at ice-9/eval.scm:333:13 (a)> #:guile-for-build …)
In ice-9/eval.scm:
   191:27  8 (_ #(#(#<directory (guix scripts refresh) 7f005edfb1e0> #<procedure 7f005cae7b20 at ice-9/eval.scm:333:13 (a)>) (#<package…> …) …))
In ice-9/boot-9.scm:
    152:2  7 (with-fluid* _ _ _)
    152:2  6 (with-fluid* _ _ _)
    152:2  5 (with-fluid* _ _ _)
In ice-9/eval.scm:
    619:8  4 (_ #(#(#<directory (guix scripts refresh) 7f005edfb1e0> #<store-connection 256.99 7f0056ccd550> (#<<upstream-updater> name:…>) …)))
In srfi/srfi-1.scm:
    634:9  3 (for-each #<procedure 7f0056a6dc00 at ice-9/eval.scm:333:13 (a)> (#<package node-openzwave-shared@1.7.2 gnu/packages/zwave.sc…> …))
In ice-9/eval.scm:
   173:47  2 (_ #(#(#<directory (guix scripts refresh) 7f005edfb1e0> #<store-connection 256.99 7f0056ccd550> (#<<upstream-updater> nam…>) …) …))
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure update-spec-package: Wrong type argument: #<package node-openzwave-shared@1.7.2 gnu/packages/zwave.scm:94 7f0051378a50>
--8<---------------cut here---------------end--------------->8---

There’s nothing wrong with the package “node-openzwave-shared”.  The
problem is that for some reason the updater now gets a <package> value
instead of an <update-spec>.

Commit 8aeccc6240ec45f0bc7bed655e0c8149ae4253eb seems like the problem
here.  Hartmut, can you please fix this?  Otherwise I’d like to revert
this and related commits ASAP.

I haven’t seen these patches on the mailing list or the issue tracker.
Have they been reviewed?  These changes also break existing tests, which
should have been run before merging.

Let us please do better and avoid breaking the master branch by
discussing changes and running tests.

Thanks!

-- 
Ricardo