From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oK7ED1NOTWROwgAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 19:05:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ACm0DlNOTWRf2AAAG6o9tA (envelope-from ) for ; Sat, 29 Apr 2023 19:05:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 082CB38331 for ; Sat, 29 Apr 2023 19:05:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pso0Q-000614-5d; Sat, 29 Apr 2023 13:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pso0N-0005yx-UK for bug-guix@gnu.org; Sat, 29 Apr 2023 13:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pso0N-0008OD-Ek for bug-guix@gnu.org; Sat, 29 Apr 2023 13:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pso0L-0007yO-Sg for bug-guix@gnu.org; Sat, 29 Apr 2023 13:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 14/17] services: mpd: Obsolete 'environment-variables' field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bruno Victal Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168278785930586 (code B ref 63082); Sat, 29 Apr 2023 17:05:01 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 17:04:19 +0000 Received: from localhost ([127.0.0.1]:36452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psnze-0007xF-L7 for submit@debbugs.gnu.org; Sat, 29 Apr 2023 13:04:18 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:61536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psnzc-0007x2-PR for 63082@debbugs.gnu.org; Sat, 29 Apr 2023 13:04:17 -0400 Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-5ed99ebe076so12811166d6.2 for <63082@debbugs.gnu.org>; Sat, 29 Apr 2023 10:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682787851; x=1685379851; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=y7b/QDDCJKgxZpwXAIMGWLZ3Oewz+lkDcj/c4UMReEI=; b=VI2jMtzIndjGXk4t+eE+9ILBODjjgPfpIKVSQFAbezF+EBUUUe45j0g5b44wlVYXgl X1M2hn1SNl01hJiVMh66wVYfc2xUkggEqFFptNHBaRV0/+0dNneHRQ/Y2u/e89pElOr3 e/6CZ8guelR1hpdAD+SEcFPhVuIzwmOiTN7rxbE7ltrrmeRT1yo+jq5mptiVQuNs5DcR JFI9AqkWS5aXhVnpFW89BazzrjXfsv4yZqJHXtTCFENZWwQWSSHJdUYDGM6qBOQWDAR+ S1FlsPgbtf2His79dXG2+wGnNUhn+Clr9PH5YT0dg+AmOYaf4OQcm6ypZS4dyvTJtQBC eDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682787851; x=1685379851; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y7b/QDDCJKgxZpwXAIMGWLZ3Oewz+lkDcj/c4UMReEI=; b=iK+KLKZpbxBlO+pPOXapsxULhO+lqMtNIq4fOl1rm6b4D/iKq+qXaOk6T5GI3ZdyXe bxgXG6oTFF9cecCTg+3ah/mXifw83YycVp7R7N9r5k5uCYa21s5rbimp/0PQ7NLxuQN+ DVkQGwWLa3vQPy920iPJbZf6GpkTaETblrVui9yKauPRlWAKsPUnusvWH13VYl1sMUdk 7639X8MpB9vUQvtl0M6TVzJdNeduJ9P73QNGiWrdsRGR1Y7omc4kbsgSUPg0Fx3aJFhD NnEiTDOng8I++9oOmSKHhEinIEwtWEX5+6SgF2b/36cer91lgrt7rubgz+pFS59964IH T53g== X-Gm-Message-State: AC+VfDyFNwnFeDBtrqy7ZukCyS2Rox6Fnqsjk5lm+krUNoSLZ+qS2skG wpOqN6/cUDHzEDdN9JbmI5Pmbvt1daw= X-Google-Smtp-Source: ACHHUZ6OdQ+VL5mGtTc9RUmtrBdyk+KWN5/Xpx/Mo8l5pBhF2LFSXas1CZsIJpGEOWOfrgFk/YVfBw== X-Received: by 2002:a05:6214:20af:b0:5f1:5f73:aec1 with SMTP id 15-20020a05621420af00b005f15f73aec1mr12668443qvd.19.1682787850936; Sat, 29 Apr 2023 10:04:10 -0700 (PDT) Received: from hurd (dsl-155-245.b2b2c.ca. [66.158.155.245]) by smtp.gmail.com with ESMTPSA id u17-20020a0cdd11000000b006166a6c62cesm2514253qvk.69.2023.04.29.10.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 10:04:10 -0700 (PDT) From: Maxim Cournoyer References: <16e06b4b2a932a7c48696fcc1b89c5a454dc9d2b.1682690696.git.maxim.cournoyer@gmail.com> <2fabf610-5256-dad1-0e62-449fbcc738f0@makinata.eu> Date: Sat, 29 Apr 2023 13:04:08 -0400 In-Reply-To: <2fabf610-5256-dad1-0e62-449fbcc738f0@makinata.eu> (Bruno Victal's message of "Fri, 28 Apr 2023 23:17:28 +0100") Message-ID: <874joyaad3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682787923; a=rsa-sha256; cv=none; b=d5timsbiXnjsIbqT/PDLwW3MX72ECkBDSTv7OAz2I2qvYVAAaB/rW9yF7fk8+5xTFzKuuI pBazcm6V1flvT5bY8G2W/EXrIEhLlPG5yi4KTrg2TR0cWMYWVZ/VFhldT6BkdQvDhlGStO 3bT9JXlCIE6GSCT+q1LNpYlc90OdGwzuiJs7FofKBoGfO5GWS8+tUh4lQ/miF4iBjKN5S7 W5CAPf5ntc4zOm6cQ5TvT5OlQw9Um8/E5Zzjx7FzY8b7aD4e1l2QnXrSnf58QQexpQwMhR jO/BEghOS2U2n75eVnDtmYXF+q4dy0ONSke3a3jkQl8gkRke1XVdDRs/xQ3Acw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=VI2jMtzI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682787923; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=y7b/QDDCJKgxZpwXAIMGWLZ3Oewz+lkDcj/c4UMReEI=; b=Fg/3z1ts4v2PzwWA/fs8jtMPt8G8J7r0sglglz/nhze0chCHIjK9bxM21EIuw2n3UhPozJ 33dX/zWOlFJ5XLmCd7mmk8nEskifL+DCW5giFFGIANf2r4IDGcvwhL9m+RHRP8K/Oo2aZ/ cmZ+1h8fGCrvtBPu4q3fcJ85Jku9iDMO2Os21znneV4eroE4+h2d4ciJcDF69ui9vDUgyM GLx7i1ZbLdrRPXQenABET5ZPQEyLZoBNrUPthk6GNIIfxiJCVxl296BlPVcP9VV4rsVefo NP2rsC90xj5391Z6fQunex3YFp5o1CVB0vR4gHdTII9Y0vHrBC+YKgJ4nSzjmg== X-Migadu-Spam-Score: -1.40 X-Spam-Score: -1.40 X-Migadu-Queue-Id: 082CB38331 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=VI2jMtzI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: ZcekevtUz084 Hi Bruno, Bruno Victal writes: > On 2023-04-28 15:27, Maxim Cournoyer wrote: >> Rationale: Services can be extended via the simple-service mechanism instead >> of having to expose fields on service configurations that are not directly >> connected to the service's configuration. >> >> * gnu/services/audio.scm (mpd-environment-variables-sanitizer): New sanitizer. >> (mpd-configuration): Use it. >> (mpd-shepherd-service): Hard code the useful environment variables inside the >> Shepherd service. >> --- > > This field shouldn't be deprecated as one of it's primary purposes is to allow for > the pulseaudio daemon configuration to be set to another one. > What you're doing here is effectively hardcoding the pulseaudio configuration. Our only means to declare a pulseaudio configuration (pulseaudio-service-type) places it at this location, so it seems reasonable to hard code it. What use case do you have for a custom pulseaudio configuration that pulseaudio-service-type could not cater to? This prevents users defining another environment variable and forgetting to replace these, then wondering why the default pulse configuration doesn't work, and it felt out of place to me (an implementation detail better encapsulated). > I'd consider this field to be within the same category as > 'shepherd-requirement', it's for flexibility I like the idea of more flexibility, but I don't like that these fields need to be duplicated for each service, somewhat encumbering the view. Perhaps we need to devise some 'always nice to have' set that would be configurable for any service without having to expose these fields as part of their main configuration? -- Thanks, Maxim