From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sNvgHw7ztmTdCgAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:16:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YNOsHw7ztmTLCgEAauVa8A (envelope-from ) for ; Tue, 18 Jul 2023 22:16:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B9714697A for ; Tue, 18 Jul 2023 22:16:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=XNgUGQ2F; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689711374; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aP93fTllDuy6Q9AWjKHl2bsG4qE9MsX7uBbHT8eeSIo=; b=Uruyx6lZH3WZddj07ZwEvCTMcxOKOP2kdIC8bKYxMuKuJyKXx8A+gLYyKRbktNVNOqbYpt ykqX+PKjK2YswV4NYr+2YCNqavrrny23PHKMEzJXSBwJbzsI8pxqBwE7+qiVVFKinVME31 qdjv1eoYrQvIQ31t8VwhidIQeloU4XFi4SxL40hIuIjTHUQMkQdmP826yWpPrGcTp6PRUf 2UPO3ZaDZLzcqIuSkGGfc0SkJA3tyCIczs5ukVj7UaUvMX7i6eX/o1N218HY352mxyg5Vv W0uCelAeh9mUrQQLjKrshLz//ubfFhRe0P62xBFjw/vTk3CKTLuff9/QmeyvTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689711374; a=rsa-sha256; cv=none; b=GsZibVQiTvC6YNTwQ9zTzXWDwSOESDsq84z65skkyRs1MgsaS9hKjXE9R1UlMi5vjVs9yL HQhc+HDy6d8WrnLKZBqNlzYlwanCbYxOn9aWTLa86aHQkn1L2/7NgPlKHD+teFQELUH8wV aULQn2vMl7X6ACFwTXmJy3ArOjVqX9UVtak7wEtU8Lf5IYjNYWh1E71jgYlQOAkL2mQQSR w69RtW1YpqwMvMVnMg3EW1hZ4EcpY77qNBB5syxOqsph5crLtinrQPicRKzWuzrddooyG0 JnSvIY8mscqJnXXcktMnpLiK6qSqt1lXYQJQ2aRPTFnfK+WoK39PJIozMn/B7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=XNgUGQ2F; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLr76-0000i2-9e; Tue, 18 Jul 2023 16:16:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr75-0000hY-0O for guix-patches@gnu.org; Tue, 18 Jul 2023 16:16:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLr74-0001ab-PB for guix-patches@gnu.org; Tue, 18 Jul 2023 16:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLr74-00041S-EX for guix-patches@gnu.org; Tue, 18 Jul 2023 16:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Raghav Gururajan , 64711@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971132315409 (code B ref 64711); Tue, 18 Jul 2023 20:16:02 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:15:23 +0000 Received: from localhost ([127.0.0.1]:54391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr6Q-00040T-Ro for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:15:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr6M-00040D-Fn for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:15:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr6G-0000rG-TU; Tue, 18 Jul 2023 16:15:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=aP93fTllDuy6Q9AWjKHl2bsG4qE9MsX7uBbHT8eeSIo=; b=XNgUGQ2FSnnVF24J9EVL 4eg7kmv39HUMev0eN1HxHKca29T/9RoClffbAjUcpw7hL+ojOZ2YQ6LXhuWQCuq2MzE7vFiDYTMvN 4qz/qhff2eA5HygPAQZnGtEXow+ZnWcBnSq8TCcAbZkb6ix5IGr8XV9oIuPUkkVOsdt4skTVdb6+T m8W1MhufwoaZPLO7iTA/3GKifOhkETaBvfxMsIGDvw17jvClM6aCH10LLmfJbAFLDAOR14X/bYup0 jGkLhhKV2Z3czEbyApxU80LbRpuawNs0hHl2L25Z0hnXVbcc+D0Rz92YD+xYcEJnGJfeQNwJhYogB mB+rEFKo5HPtQQ==; Received: from 2a02-a462-da03-1-aeb0-2f5e-e96a-dccb.fixed6.kpn.net ([2a02:a462:da03:1:aeb0:2f5e:e96a:dccb] helo=drakenpad.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr69-0007Wp-U8; Tue, 18 Jul 2023 16:15:12 -0400 From: Janneke Nieuwenhuizen Organization: AvatarAcademy.nl References: <87sf9lt28s.fsf@gmail.com> X-Url: http://AvatarAcademy.nl Date: Tue, 18 Jul 2023 22:15:01 +0200 In-Reply-To: <87sf9lt28s.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 18 Jul 2023 16:04:51 -0400") Message-ID: <874jm1dliy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.86 X-Spam-Score: -3.86 X-Migadu-Queue-Id: 5B9714697A X-Migadu-Scanner: mx1.migadu.com X-TUID: TKnBwy7lv9GD Maxim Cournoyer writes: Hi Maxim, > Thanks for your efforts on this. Sure. It's been fun, but a lot of work (world rebuilds) indeed. Things will get a lot better once we have CI for these native Hurd builds. > Janneke Nieuwenhuizen writes: > >> * gnu/packages/gtk.scm (pango)[native-inputs]: Do not include >> gobject-introspection when building for the Hurd. >> --- >> gnu/packages/gtk.scm | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm >> index 853696c7f5..15dea2852b 100644 >> --- a/gnu/packages/gtk.scm >> +++ b/gnu/packages/gtk.scm >> @@ -401,12 +401,14 @@ (define-public pango >> (list bash-minimal >> zlib)) >> (native-inputs >> - (list `(,glib "bin") ;glib-mkenums, etc. >> - gobject-introspection ;g-ir-compiler, etc. >> - help2man >> - perl >> - pkg-config >> - python-wrapper)) >> + `((,glib "bin") ;glib-mkenums, etc. >> + ,@(if (target-hurd?) >> + '() >> + (list gobject-introspection)) ;g-ir-compiler, etc. >> + ,help2man >> + ,perl >> + ,pkg-config >> + ,python-wrapper)) > > Stylistically, I think it'd be better to use append (and 'if') here than > quasiquotes (to avoid having to unquote all inputs). Okay, I can change it to (cons `(,glib "bin") ;glib-mkenums, etc. (append (if (target-hurd?) '() (list gobject-introspection)) ;g-ir-compiler, etc. (list help2man perl pkg-config python-wrapper))) > Otherwise it LGTM. Thanks! --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com