From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gM3MHL8YwGTtfgEASxT56A (envelope-from ) for ; Tue, 25 Jul 2023 20:47:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WPfUHL8YwGQHuAAA9RJhRA (envelope-from ) for ; Tue, 25 Jul 2023 20:47:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E924038CF0 for ; Tue, 25 Jul 2023 20:47:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=hallsby.com header.s=google header.b=ArQ86fNF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690310847; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WYSxOWVAvhjMcvL9br6gtfPi3bKC6S0z8KRrj0JoRAo=; b=iRBjIjVf7zrlVppVU11gyo83ivU43av0G90EWc37oHUsvnrKOu5NE+BrMxp6412yiOpwPf NqzgNIooyy50uTp+NnUc8B5F/9a3Nij8JOFZiddmDrqARDO2hXxL/2aWwd2mEJAnfSp/Os dHMnM8a/2AEKE633Ed97BE7fTr8SfhQVKRPNxBHR/azSDSen3hePVSCLaKGUovwHV/bwWz zs+/YtOeALBNEcCcKilxy1cSKVsw+KU/7kf9Bt379UWWqSxfNQJa+DXd2osfKq7S27t/KW Gd8ZaRYcs7bVwxtt7etb8mCgXCSrYNruWu08WP8JUY6Q4rBic51U8Jt9UjbkJw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690310847; a=rsa-sha256; cv=none; b=b0/rcEQvXGJZhDaJap2d0EvOwjiKk9xk5DXE7PY7RP4Hpm4WqKcuIBwkqLZAldOP3JXAQw j1BAhi2ur+uiHU8BrhJVzh5oU2f2wcQqyGF/pgUoDAqg5Enyfbg25G+nizY3P4Mn5Nndtj t5PppNtdal2w8fEay83G75s3q2ss1AwdBmv0cf6Z6qQu9TdvDGwcHR/Qlb0X+UoNvVGkv5 tFQQT69NENWh6jm1bWTGlbTuMq7jzMvryE3x+09x6b9O28c7hQSEfWZ5G5feF3nXNAu/Kp cXxH7CZtafn3VI6RWkZLfb3i4/J2D1dKh9dkdfnh8M9j5CBsvS+GJBt48txtWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=hallsby.com header.s=google header.b=ArQ86fNF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qON3v-0007oJ-4M; Tue, 25 Jul 2023 14:47:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qON3n-0007nf-9P for guix-patches@gnu.org; Tue, 25 Jul 2023 14:47:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qON3m-0002Tt-OR for guix-patches@gnu.org; Tue, 25 Jul 2023 14:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qON3m-0000qX-KQ for guix-patches@gnu.org; Tue, 25 Jul 2023 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input Resent-From: "Karl G. Hallsby" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jul 2023 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 64861@debbugs.gnu.org Received: via spool by 64861-submit@debbugs.gnu.org id=B64861.16903108013223 (code B ref 64861); Tue, 25 Jul 2023 18:47:02 +0000 Received: (at 64861) by debbugs.gnu.org; 25 Jul 2023 18:46:41 +0000 Received: from localhost ([127.0.0.1]:46962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qON3Q-0000pv-En for submit@debbugs.gnu.org; Tue, 25 Jul 2023 14:46:40 -0400 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:52734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qON3N-0000ph-So for 64861@debbugs.gnu.org; Tue, 25 Jul 2023 14:46:38 -0400 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3a38953c928so4101398b6e.1 for <64861@debbugs.gnu.org>; Tue, 25 Jul 2023 11:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1690310792; x=1690915592; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=WYSxOWVAvhjMcvL9br6gtfPi3bKC6S0z8KRrj0JoRAo=; b=ArQ86fNFL4xyRa7M5J5i6+qA0d5IFu1+Kk099D0puKOGdgK607xNO/+KtBOkv0tfE5 I6NhVBNEG9nTt2h+uFcX/18oUpM0UwtD25Ti1pcVySP4wDWq5bUb7L2UTaCN1TByz+Cu 19FEetSJOF8VicDcELvR/AhZ/8qZwEqTi6jLNxcuW9gc6z0hhrVQ6tJ1iKI+X4GaXGjV rB17VG7tYddjLBunhocB9Y7Jgwko0gs1MnNyhSsbsd9t/mi15pB616hhYf3md1y6tuaE ernE4gdQQ+7jbwP7efVIe+p95aLde6Z2guqQ8qmZHBSoipceLS0jvsoM85qTyxufneqk BWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690310792; x=1690915592; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WYSxOWVAvhjMcvL9br6gtfPi3bKC6S0z8KRrj0JoRAo=; b=CnM3rY0iZs8Pp4fCdK8/57tkB1OAn3Gd23+/tjaR8IfoTcFY+yFNpIKGc5yC8KNSDo D85mk/a7CeUu6Kodd0hHnN0WXc/9r7BP+en9R1G3mgXWQTXOMxZoW1lUTwSVBsZz54sc Q7W1hoghWD5C7zl9KN3PQztnwwSmN8ufQTuw7Ezx12MTjlf6zkUkqFvtIoC+CYbmh0z2 Eh2VWtx/TxWI5efBu407GEOitULUkb/I9/I48B//KjuTlz4Vw3weGJdWp6WISsVmoPt5 PIhZZ4hXzfgR1TrPvTIgamz+REnOKrTn2dc1OJThFog4102tfs7IXhUJmwHqP6sL4RJY iqYA== X-Gm-Message-State: ABy/qLZXHxrmQEglNa9vfGeru8ThRkoWTEf+J7ySCmmoyYzCQZ6j6ss7 qK6sE146YfeTE/WQCkYrN934q13zJhzdAvL3XsgGoA== X-Google-Smtp-Source: APBJJlG/JASfHjo81DC8CLISa0PfO8mhS+agvW4IeteZy5Tc/p6AmqcV+lzbrf/twRLJooDZ7Yyj8Q== X-Received: by 2002:a05:6808:1594:b0:3a5:a82f:2cd with SMTP id t20-20020a056808159400b003a5a82f02cdmr11539604oiw.8.1690310791782; Tue, 25 Jul 2023 11:46:31 -0700 (PDT) Received: from localhost (1459483-v115.1145-static.batvilaa.metronetinc.net. [192.69.181.148]) by smtp.gmail.com with ESMTPSA id s14-20020a0cb30e000000b006238b37fb05sm4567450qve.119.2023.07.25.11.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 11:46:31 -0700 (PDT) References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@hallsby.com> <87pm4f7skl.fsf@cbaines.net> User-agent: mu4e 1.10.3; emacs 28.2 Date: Tue, 25 Jul 2023 13:41:55 -0500 In-reply-to: <87pm4f7skl.fsf@cbaines.net> Message-ID: <874jlr96d5.fsf@hallsby.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "Karl G. Hallsby" X-ACL-Warn: , "Karl G. Hallsby via Guix-patches" From: "Karl G. Hallsby via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -5.14 X-Spam-Score: -5.14 X-Migadu-Queue-Id: E924038CF0 X-TUID: BSdewA+/sujH Christopher Baines writes: > [[PGP Signed Part:Undecided]] > > Karl Hallsby writes: > >> * guix/lint.scm (new check): Run lint check warning user if the provided >> package uses guix as a propagated-input. >> >> Passing guix as a propagated-input is problematic when users install a p= ackage >> into their profiles. This can cause the guix propagated by the package t= o be >> used in preference of the real one in $HOME/.config/. It was first notic= ed on >> IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and repro= duced >> with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#0= 54737. >> --- >> guix/lint.scm | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > > I'm not sure this lint warning is helpful as in both cases mentioned in > the IRC links you provided (guile-imanifest and guix-data-service), > these packages provide Guile modules that depend on Guix, and therefore > the guix package is expected in their propagated inputs. > > If you remove guix or make it a input instead of a propagated input, > then this breaks using the package, for example, with this change: > > modified gnu/packages/guile-xyz.scm > @@ -2098,8 +2098,10 @@ (define-public guile-imanifest > (build-system guile-build-system) > (native-inputs > (list guile-3.0)) > + (inputs > + (list guix)) > (propagated-inputs > - (list guile-readline guile-colorized guix)) > + (list guile-readline guile-colorized)) > (home-page "https://sr.ht/~brown121407/guile-imanifest") > (synopsis "Interactive Guix manifests") > (description "This package provides functions to generate Guix m= anifests > > Using guile-imanifest breaks: > > =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-i= manifest -- guile -c "(use-modules (imanifest))" > Backtrace: > ... > > ice-9/boot-9.scm:3330:6: In procedure resolve-interface: > no code for module (guix profiles) > > > I think some other approach is needed to avoid people having problems > with the guix package appearing in their users profile. > > [[End of PGP Signed Part]] That makes sense. Though, this lint is just a warning, so if nothing else, it should make people think if guix really needs to be propagated. If this lint is not the solution, then a way to mark packages that are not recommended to be installed like this would be nice.