From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8GfvK5fb/mRDQAAAauVa8A:P1 (envelope-from ) for ; Mon, 11 Sep 2023 11:19:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8GfvK5fb/mRDQAAAauVa8A (envelope-from ) for ; Mon, 11 Sep 2023 11:19:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5E964C9B6 for ; Mon, 11 Sep 2023 11:19:18 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=web.de header.s=s29768273 header.b=mH91bcLD; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=web.de (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694423959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vOh3hLWUmRlNgJ4UZWRBS1vEEbeL2Jw9LwQ63iNDW34=; b=LxNnWHEbM2lE0Mka2JEIuYW4w4r9T4W8LZSUfcl4Fy2KPtXeYcZZfnM2dzp+ozeM5Cbv6k /pHVl7ynXo/eNGW8nmYghFoO1/c3DNsX4n1r8q156LpmUDcb8ynJs+OmQG8Y4nJMSb/e2A GPCTep601omPiTj19fsFS6kUxqQPqDjGA/I2tQc+Kga7W0YRqKE968IsR5dCXD6MQzHDcP 2cy9vMXfe/WgT0kJrYFgBRYV/OE+IpHTR4EuNqwXygzYrVg6BClTE9aZrbHP30nSLV4Rjs Dr3Ty8gZ9YWVgFHdb/hyzcuVIyrfQinBs3eumwGyGUiudyDk6g7G1Ok/Pa4szg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=web.de header.s=s29768273 header.b=mH91bcLD; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=web.de (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694423959; a=rsa-sha256; cv=none; b=ZPgpvoznqe6lElWjOxjDC/OAVn/3wFQp9mwEbIHcGtfr+oJdH4MndxIvpNEf/KU8ggbWkm v8MIAjIFjZALeddQ4LMrFHH7dJsA9gYe865/iPr60vjCTZG6pmymqSKZ176TZ2edRXadei OtHMx5wP2VfdCSBdnjFB6X1D5AophM706zHvY1bE5hh8jNSZkxZJp2xOJJso1KF0jeU8y/ ZIUkH+5RijXbXp5uR0CCX6LRRJ9bzeSJrls4mziF2+YjcYdJBUYHjwvLJA78U3KY2D8YJX y+GuEnplX8gD01lFQWSRjmxq/4WahBlZuBPMkq7U/carkJwDFGv0LxZ8EUpabw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfd4S-0001jV-MV; Mon, 11 Sep 2023 05:19:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfd4M-0001im-Os for bug-guix@gnu.org; Mon, 11 Sep 2023 05:19:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfd4L-00089Z-V1 for bug-guix@gnu.org; Mon, 11 Sep 2023 05:18:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfd4P-0004BV-Rt for bug-guix@gnu.org; Mon, 11 Sep 2023 05:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65391: Acknowledgement (People need to report failing builds even though we have ci.guix.gnu.org for that) Resent-From: "Dr. Arne Babenhauserheide" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 11 Sep 2023 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65391 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: Maxim Cournoyer , 65391@debbugs.gnu.org, maximedevos@telenet.be, iyzsong@envs.net, mirai@makinata.eu, atai@atai.org, raingloom@riseup.net Received: via spool by 65391-submit@debbugs.gnu.org id=B65391.169442390416041 (code B ref 65391); Mon, 11 Sep 2023 09:19:01 +0000 Received: (at 65391) by debbugs.gnu.org; 11 Sep 2023 09:18:24 +0000 Received: from localhost ([127.0.0.1]:52138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfd3o-0004Ac-1d for submit@debbugs.gnu.org; Mon, 11 Sep 2023 05:18:24 -0400 Received: from mout.web.de ([212.227.15.3]:49553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfd3m-0004AQ-Dq for 65391@debbugs.gnu.org; Mon, 11 Sep 2023 05:18:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1694423875; x=1695028675; i=arne_bab@web.de; bh=KF0Ggs6ta/qZb7OWHR1gPdEpK1+f8BDD/Wrz8D5oUR0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=mH91bcLD14UMc8nrdJ05Heua0KJcNYcD17WpwgyC3iRiwIoMzvDEjhYmIuvd8xgiwaedSO9 xevm5C/4PPTh55me1GDNDeYYGDClr55Csyc8nPOUzRVR4uEdpwJyDLcIvtlkaa1uxxaULumZd kYAmkA+x0a0FwL07GGgBI1MaDxh/+93O0T60f2/taVBjRVadC1esIJJ2aGQcysf3b1vNaS+aU UPf5F0z1ejs5cH7R7ZjOMdmBvGsXdPS0LNWSXbtp6EV0zqPupMbf58XWxJXgmMu3wFT9h7MA0 T+y3y4hGR75EZwS55mg+CVKv+pedhVhutFUZsHW1trLT9Y0h4xQA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([80.136.24.98]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mvbms-1pmyjU47Jm-00ssUW; Mon, 11 Sep 2023 11:17:55 +0200 References: <295ef8c8-574a-4169-98f3-6d9aaeb773f1@telenet.be> <6a62aced-9138-0496-fb01-d5d8e89ba8d6@telenet.be> <87h6ohc3gk.fsf@gmail.com> <87zg296z7y.fsf@gmail.com> <871qfkg65s.fsf@web.de> <87pm2ukxn5.fsf@gmail.com> User-agent: mu4e 1.10.5; emacs 29.0.92 From: "Dr. Arne Babenhauserheide" Date: Mon, 11 Sep 2023 10:30:43 +0200 In-reply-to: <87pm2ukxn5.fsf@gmail.com> Message-ID: <874jk183wx.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:hDFfXgXzkRM1rVXy3aVWYN4KAgJFog/pKC7wi0X6tQHSywEcrmD DzIZzX5cA4TxTcUKAqqa981cl/xP3cT4ODr/KxEH+O8B7TElAzKoLpRJGpK2owsx0tT300b jrhMKw958NqO22M8X+mUtshiAWS/25z5msmlKsO9eCJKh+NlNKuQO5c3DBr3p8i8DKqOfMA LuO6rT150sVEMIbcipKFg== UI-OutboundReport: notjunk:1;M01:P0:0bxVI51J7TE=;eyhr0Wo/wAlK2TfdNr4mp36ebzg XtdyT7vwK/yqzhSFnnIwnkS9nKWuBtLuztnH6fbFG2IkuQn9HUHXz48dnjBO/megUT+MzX8AV LXh5rruCF5xd/UwbHaqbVgMeXlv42BBxJjnDOb1y8gNZtBPq2AEGy/WXwKM0zNjmBm4G5dTvq 8ibsIKZHDTyu4Vx5cw434hs6swFunx7L779n3FeHkt791k5gp/K8KuQfWZRE+Dkn2nO1DgIv5 7IY1BcQYYpDq/536Ix05BaQomP/wdGf8yGpXg5qa1ILxe/kzzF8WJNB9BtRHUc0GNmKv4tfJd jt/cQuWzitzWZsht7MVu4kVcT5/T3YzQr7G73qBpPrkFcet+/PgKbRV8wRZ1k1ixnc1Xwj71L 3PQuRkbuls+m9sAjnaQBe/E6Dh08r50WX9PzSmdjCMfjy+/7EY4lLY9WKhebSRj5bX4ggoFM2 WmSsUrEMO4tsLkvhWPAZTxGYpwzC1L90iTPrTR9M+CTMl40tn5X58tEWeLuV/8Gqs8BA1a96d RTj56qfehiTCYcCUOeK/8e1LrafIYMltZ3hlFEnOofQTghzBlLm1Bcdrs88LknEviqWgTzkMR +diHHobXdRunNB/KDFyYnMG1WfVaIGC+WYtIu82CAsvzYDrs/SckfWAS2Ban6V99JyeizAuM0 weThzN5jSotueSRC7YJZHpsoE2wasNoFyGuz+xg1cHnkum81tNfvBRumJQlgsMfQnP5ktzETo TquIVDOKFCiIpmdthzlzvxB5hZ1H0xaJD3JSqxekLabX0mqyqC40VLP8T8R2DYqdBBXPSKnrQ LE9shkYUWDttTIe7da6vWR1GafxRiyD3DOE6dku/pAFy+NcwKfw9iOisWM8KObSleoNBbdqC0 iRab1l/3qbwCQ6lMsaMftCqPcyVltouEY37fMxmDRXHtm5ynG7f9egb2ajeLy4niQZU8Cpj7V jdaWPA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D5E964C9B6 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 5.32 X-Spam-Score: 5.32 X-TUID: jsbk9SjbR33V --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Simon Tournier writes: > On Wed, 30 Aug 2023 at 12:39, "Dr. Arne Babenhauserheide" wrote: >> Please don=E2=80=99t remove packages that are broken on the CI. I often = had a >> case where no substitute was available but the package built just fine >> locally. This is not a perfect situation (nicer would be to track why it >> doesn=E2=80=99t come from CI =E2=80=94 sometimes it=E2=80=99s just a res= ource problem on the >> CI), but if you removed a package I use that would break all updates for >> me. > > Well, I do not think that any policy will mark a package for removal on > the first build failure. However, if the same package is still failing > after several X or attempts, it means something is wrong. > Marking it as a candidate for removal implies: > > 1. check if the failure is from CI when it builds locally, > 2. keep a set of packages that we know they are installable. > > For instance, ocaml4.07-* packages are failing since more or less April. > > https://data.guix.gnu.org/repository/1/branch/master/package/ocaml4.07-pp= xlib/output-history > > Does it make sense to keep them? For another example, some perl6-* > packages are failing since=E2=80=A6 2021. > > https://data.guix.gnu.org/repository/1/branch/master/package/perl6-xml-wr= iter/output-history > > Does it make sense to keep them? This is a good example, but not for removing broken packages. For perl6-xml-writer removing the package would keep breakage in Guix. I just checked the build, and this looks like a Guix packaging error that breaks the tests due to a change to some unrelated package: /gnu/store/ap404x14l604wm0gvaj439ga2vjzwnl7-perl6-tap-harness-0.0.7/bin/pro= ve6: /gnu/store/ap404x14l604wm0gvaj439ga2vjzwnl7-perl6-tap-harness-0.0.7/bi= n/.prove6-real: perl6: bad interpreter: No such file or directory Disabling the tests makes the package build and work. So here, removing a package would start at the wrong place: some change between 2021-02-01 and 2021-04-30 broke the perl6-tap-harness and we did not detect that. This is a problem that would get hidden by removing broken packages. The problem is that we (large inclusive we that stands for all users of Guix) did not track down this problem that causes the build to fail. From=20this I see two distinct cases: =2D packages broken upstream =2D packages broken by changes in Guix If a package is broken upstream and not going to get fixed and this requires regular patching in Guix, I agree that we have to remove it at some point. If however a change in Guix breaks packages, that change should get rolled back / reverted and fixed, so it does not break the packages. 8 | ocaml-migrate-parsetree ^^^^^^^^^^^^^^^^^^^^^^^ Error: Library "ocaml-migrate-parsetree" not found. This likely means that a change in the inherited package removed the input, but the breakage wasn=E2=80=99t detected. And that=E2=80=99s actually what happened in 386ad7d8d14dee2103927d3f3609acc63373156a Fri Jan 13 10:54:36 2023 +0000 This commit broke ocaml4.07-ppxlib by cleaning up the inputs of ocaml-ppxlib (not naming names, this is not about shaming but about detecting the deeper problem). It should have been rejected (somehow) by CI. The change it would have required is this: diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 8ff755aea9..042432be9a 100644 =2D-- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -6845,6 +6845,9 @@ (define-public ocaml4.07-ppxlib (base32 "0my9x7sxb329h0lzshppdaawiyfbaw6g5f41yiy7bhl071rnlvbv")))) (build-system dune-build-system) + (propagated-inputs + (modify-inputs (package-propagated-inputs ocaml-ppxlib) + (prepend ocaml-migrate-parsetree))) (arguments `(#:phases (modify-phases %standard-phases So for both the cases you named for removal, such a removal would have caused us to miss actual problems in our process. This does not mean that there will never be a case in which a package has to be removed, but given that both cases you showed are likely self-induced breakage due to changes that should have been rejected as breaking seemingly unrelated packages, it rather looks like the situation where removing the package is the right way forward is the exceptional case. The norm is that our CI should have detected a problem in the commit causing the breakage. (this is reasoning from only two datapoints, so take it with a grain of salt =E2=80=A6) Can we automatically rebuild all inheriting packages when a package gets changed? > The usual situation is that CI is able to build the packages. The set > of packages that CI is not able to build is very limited and it is the > exception. > > Having a rule to deal with the regular broken packages appears to me a > good thing and very helpful to keep Guix reliable. And that rule cannot > be based on rare exceptional cases. A rule should work with known cases, otherwise it causes known breakage. Also see above: in the two cases you selected, removing the package would be the wrong path forward. > On Wed, 30 Aug 2023 at 12:39, "Dr. Arne Babenhauserheide" wrote: >> If a change in packages breaks my manifest, that is extremely painful. > > Yeah, and such rule for dealing with broken packages will be helpful for > detecting such change and so avoid such situation. Since a manifest is strictly dependent on all packages defined in it, removing a single referenced package means that the manifest is broken: no update works anymore. No security updates come in anymore =E2=80=94 even= if the package in question worked locally. This is a situation we should not cause. If we had a way to have placeholder packages (similar to the renamings) that emit warnings for missing packages but do not break the build, that would reduce the damage done by removing a package. But I think such a mechanism must be in place and tested before adding a rule to remove packages. And as we=E2=80=99ve seen from the two packages you selected, removal would= n=E2=80=99t have been the right decision. The more important question is (serious question and *not* for assigning blame, but to see whether we can improve processes): with the time we already spent in this discussion, we could have fixed a lot of packages. Why did we not do that? Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmT+2y8QHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD66SUEADOhqoigJp4lgsKZ2KEctmTfjAthc5Jj7+q DX4uUtLaqjCrU6SbnMGtyV7V58DxjVdS7e3y2xlDBTWTTXTMQq2xrNya7AkV9dW+ +SnJsdJ2hSZZxwWyD0+H1AjFrQCd2Sqn2E5T5+HIuWUGGHTP8Us9KuygapEMhfGh Y3B0e+sk6EITF08Tyvrosvqx1eWMD4yc5Q1YNExBiuHyosx6arTdNt9ZdJJTesyw lxGbk6fK7XzIXkvScsCQhP8/3NmxG2rX0chHpBEAtFns39qMUjsTxycUbHPgO+Ll MsyDlmBsViczm4pi62F3dxkc88DoQ195ipZu64X0GxFAzpQeQjGGmjx3O5rRdkAE Og9szgesBqGMYMLdva9VniNzfFMV1Kfq+n3s7ZEiL2x2Hgw6OrYSZWoIxdNBes4x L70kCHOUJGDffrk/mshMrdcBLIKyonDgODSN3d7KO4T+QZNn+s13NK/amblYhWPz 9XxuDRel0kYBrEX2akn6kCVUjQ7FCXaeYvoZc3+OHAFaM9KciIqVm416dQimQNpG RmEk7o2gIwVaKU2BV6uMKRWad8KKowc/9d183LHqvEeI5MFg5eWnkFi1OHmOg2Vc fwtBKxMLYyats9rmWjytx2qQMPxjzPei9Cl7id7lB0Fm7rtcqB6yK2E+bmebm1Lc y83yKgKTDYjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmT+20EQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSPAXBACEfo4+TAuuI1p1+j21EwvKvtoC yJS8/Zi5Jz+1rTkjMI25M9AO863viuzqBcYU6wG4p6Mwn2xKmeBv5lJVQnhKWsk3 cj5h+qWr150/xDqqRTddHssN7Tlo/vL4D9eLxMmm7CU4YzJvv2NAyBQa9rWkrnLJ D9UZM3Sm3g0EKObyDQ== =RlhY -----END PGP SIGNATURE----- --=-=-=--