From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wHeINT7aAWUX9AAAauVa8A:P1 (envelope-from ) for ; Wed, 13 Sep 2023 17:50:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wHeINT7aAWUX9AAAauVa8A (envelope-from ) for ; Wed, 13 Sep 2023 17:50:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 93E686199C for ; Wed, 13 Sep 2023 17:50:22 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cqjQiJHZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694620222; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2/XZ3sMJf0m6lMivFsllh99/yZNGSvRC+AQRUvu5jxU=; b=gmjCp6cdXYA4IVIRX80rTPw8D12blEh191moZ43RWUop6sWZ4WG5TiX7RIlyOVhvV+9Gw5 1qGJkAE4kdjuR6TJsiGikgBqNlW7bYjadooOlWlnO7zJlUGRmPp3dhDy5dg51XrhHxx4Ys eK7NDc8GXI++ISJN6gCXGFl3/ED757//kpGXqUhP4WewE/raebThpPqEXWxrpI0LiEm0Pz yBdYp0qmk/hdIYZAuGFrnfxCOCuJwXZoEYCcsmI/oINgcB9sM8QSZxIivnRePLlRdWlht9 TQwgrZaBvuT95xCPrpCl861IqnMbvRnDczwz7yO+39QGVAq+O7Zgc006/tPp1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694620222; a=rsa-sha256; cv=none; b=a2r2DbBPM59qKmWMwZeZ1G6S6mCPHEg9iwJshUOD2JWGcLZkgoMCUOTaPz8ia8lJfFHkgb HwKUYoS5sjODqJ/yKD9HZe9hn7uqNB0pruKDq87hRAUuf9O736qRZG70N24iAwymw0vHnT I8YodOo/2oZRENfT9L71CmyfgcyGqJWltXMA/w9URBZIxVbTUF1B1gIHOX19PWKnkPCvWW Hu2gR4iSN2N8oV4nNpc5TjFrfBnL1L4hFuSewhPNKHkbA7Nr277zVL1E9Ph1C9pODG7llD uwAQipax0NTIUune0oNAeHEhzIWwu0kFHmwVDRDlbf/DgdriIuZsh+t97DHYpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cqjQiJHZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgS7t-0004qQ-2Z; Wed, 13 Sep 2023 11:50:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgS7m-0004pe-NR for guix-devel@gnu.org; Wed, 13 Sep 2023 11:49:55 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgS7j-0001F3-AH for guix-devel@gnu.org; Wed, 13 Sep 2023 11:49:54 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-76ef8b91a4bso448043685a.2 for ; Wed, 13 Sep 2023 08:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694620189; x=1695224989; darn=gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2/XZ3sMJf0m6lMivFsllh99/yZNGSvRC+AQRUvu5jxU=; b=cqjQiJHZGI7YWreuR20YbfsElbN2Q2twjFuIuXhYgFN518mP/ApSZhWbDdABWsyvNz I3vTsY10BKqjnmgRNuhUeDTc7pS5DNNaf8BQNP10Cqh2EoT4UfiR7IrWJfeacMJrTs12 OKOhz4m1ZyMU7RRwb8rOahxqaJH5adr6OGyFn/DA7pjsKm8f/xXNA/36A+sPB7J6NIK3 wUWz1XOVdaHFdXJtKNCL6yK+2rQNIDAGoyfsew5X0xIC0p6sQxRGcyd+4BuJRsKnD8r3 bHOMZJJ7v25BTEMXnBs+Zgp7SDkFO7DNmUfDCZgKoNixhayB8O9x1WXAI3Tp9y7OaMyf hvWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694620189; x=1695224989; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2/XZ3sMJf0m6lMivFsllh99/yZNGSvRC+AQRUvu5jxU=; b=fAYCki/sk7Rf+NUbHpZjBQzjJh1yWqt6eYYmZj8Lv+H3mrk1kktMbvrNTfutfIT4lq hKAmzzZ5KU+Bt6BdUzfX0/BtpilqoKDHHezwlZwZN64yDsOjVQ0jCG6MrN6HOgC0iSah Amq6xJ9nqyMi2XRMNkFAuF7LE7eLWjNeyIse7V3+5e/EZQn3QD5JqAEFi5E6Ym8CAsMZ guKllzOObA+wZufL7HQqIEjYbnFT33p+XjpveaGvVswVpbK5+IztN8+VShS5Y+3vPORD s9ijN/RorLaZ+jiOcXqjXOyNql4FMeoCYTdBvl4F8om7162gKgXFtR9gsjEan22cJjHU xbxg== X-Gm-Message-State: AOJu0YzBviK8jrPKzVUwEDt1xsnGlLbRVcS8ZDBBbStmQkVlG9VZNHLI ULgcU/8V9PUCFgiwK/SZiqDVviDBYftWXA== X-Google-Smtp-Source: AGHT+IHN/jVpNPGKwmcYz1bRuc+n6GGndpo8fGKayAB3Wd//lippcNuACcgmEuBXyRBaWp/F5F8kZw== X-Received: by 2002:a05:620a:4416:b0:765:5f40:426a with SMTP id v22-20020a05620a441600b007655f40426amr3891053qkp.47.1694620189215; Wed, 13 Sep 2023 08:49:49 -0700 (PDT) Received: from hurd (dsl-149-165.b2b2c.ca. [66.158.149.165]) by smtp.gmail.com with ESMTPSA id c21-20020a05620a11b500b00767d572d651sm3959715qkk.87.2023.09.13.08.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 08:49:48 -0700 (PDT) From: Maxim Cournoyer To: Vagrant Cascadian Cc: Felix Lechner , Giovanni Biscuolo , Simon Tournier , guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <86o7ien856.fsf@gmail.com> <87h6o6fdgv.fsf@xelera.eu> <877cp2nn91.fsf@gmail.com> <871qfam14v.fsf@wireframe> <87ledex5xr.fsf@gmail.com> <87sf7iiyde.fsf@wireframe> Date: Wed, 13 Sep 2023 11:49:47 -0400 In-Reply-To: <87sf7iiyde.fsf@wireframe> (Vagrant Cascadian's message of "Tue, 12 Sep 2023 19:46:21 -0700") Message-ID: <874jjyvzs4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::735; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x735.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.98 X-Spam-Score: -2.98 X-Migadu-Queue-Id: 93E686199C X-Migadu-Scanner: mx0.migadu.com X-TUID: l0FZxV/f40Z3 Hi, Vagrant Cascadian writes: > On 2023-09-09, Maxim Cournoyer wrote: >> Vagrant Cascadian writes: >>>> Did you see my message about integrating a commit-hook similar to what >>>> Gerrit uses? It produces unique ID such as: >>>> >>>> --8<---------------cut here---------------start------------->8--- >>>> Change-Id: I9b86781869d80eda347659f0c009b8dfe09bdfd0 >>>> --8<---------------cut here---------------end--------------->8--- > ... >>> That seems like it would only work if the patch was identical, as >>> opposed to a slightly rebased patch on top of newer patches on master? >>> >>> How can you correlate Change-Id to a patch in the tracker? >> >> The Change-Id stays the same unless you manually edit it out of your >> commit message when amending / rebasing, so the commit hash may change >> while the Change-Id stays the same. So you can rebase your feature >> branch on master and share a v2, whose existing commits will have the >> same Change-Ids (newly added commits would get their own Change-Id >> trailer). > > Ok, that makes some sense. > > Although the majority of bugs in the cleanup work I did were actually > filed by someone else entirely... so the Change-Id will not help with > those. Not a reason not to implement it, but not consistent with some of > the triggers of this thread. :) I doubt the Change-Id idea would help much closing *bugs* on the bug-guix tracker, but I'd expect it to be useful to close already merged (but forgotten on the guix-patches tracker) *patches*. The Change-Ids would be added automatically without the user having to install anything, so from the time it's deployed we'd have a means to identify which patch series were all merged. -- Thanks, Maxim