From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KAoRK3mcMmUyRwEAauVa8A:P1 (envelope-from ) for ; Fri, 20 Oct 2023 17:27:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KAoRK3mcMmUyRwEAauVa8A (envelope-from ) for ; Fri, 20 Oct 2023 17:27:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 896A751A57 for ; Fri, 20 Oct 2023 17:27:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fSVmO7gn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697815673; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2mZk0WVr6Xg0sCIQhm6espXC6FInpPUvKaLbGTuBdfw=; b=BnfkntAhyWREMiy7QSqUiidGqm1DKoIg1dMLSrhTuv7KXC5IZhaSLQC81tI7QkJoaNNE2/ Zz042F7rq86acLrZoB3d+a7asaj6ZGLWx99YPvVzwchR5yiE2ALdd2d38YeNd0dwimCoGO mO+Mk398ylCJsprI5gvaexdqfy8W5bGIkMUGp24kx1ZsUHGNvIQpmDZ0FwLKBzlbfbXHkL IbLin/VmG6CxP7xvHEAl3FPboBp53s6B9dhmZgYJwu9PYaobs8GvI1JhvkvDtz9Gz+buS+ GqkkIGchRaa/UnvmPYgXzHx9HaepX5uUH2rtxIVv0yoDzPbVapPI3HFtCqHZiQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fSVmO7gn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697815673; a=rsa-sha256; cv=none; b=WR0O+fNJo0pua11LMerhF0BamqsUukWf63eaif2tShH3VBJJ7uWiQqH2pPEBTkY5tfFXZ3 cvgY7szzXCaICb5w6slRz5pxVZvArBZGRHo4WKHYmsdbuCY+VOK7SFXHZYdFYStWdk4enO TmYadKnGtak4u2f2vG1I+rEdu6qXqKXkMNlC6XXMbwu0Xwc3yGebEnuATiVlFOVataPt/d Jya4ZuTvH0C0lHa/noKX2gQBoZu6bSk1L7admsBfjSdTBxefuEmoMFS7D9wEsqnq+bOkAW hCcY6R3hoXkNytIwUYitpsAKy5UxnWwmQwOyp5brVEmsLJU8+kl4qdJgvpthDA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtrOd-0003zS-Eo; Fri, 20 Oct 2023 11:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtrOY-0003dy-5z for guix-patches@gnu.org; Fri, 20 Oct 2023 11:26:39 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtrOV-0006qY-63 for guix-patches@gnu.org; Fri, 20 Oct 2023 11:26:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtrOw-0000Qk-Cf for guix-patches@gnu.org; Fri, 20 Oct 2023 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42146] [PATCH core-updates 1/?] build: substitute: Don't fail silently. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42146 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Cc: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= , 42146@debbugs.gnu.org Received: via spool by 42146-submit@debbugs.gnu.org id=B42146.16978155831610 (code B ref 42146); Fri, 20 Oct 2023 15:27:02 +0000 Received: (at 42146) by debbugs.gnu.org; 20 Oct 2023 15:26:23 +0000 Received: from localhost ([127.0.0.1]:41208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrOJ-0000Pp-47 for submit@debbugs.gnu.org; Fri, 20 Oct 2023 11:26:23 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:38220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrOE-0000P0-Ej for 42146@debbugs.gnu.org; Fri, 20 Oct 2023 11:26:19 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32da4180ca2so151971f8f.1 for <42146@debbugs.gnu.org>; Fri, 20 Oct 2023 08:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697815545; x=1698420345; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2mZk0WVr6Xg0sCIQhm6espXC6FInpPUvKaLbGTuBdfw=; b=fSVmO7gnZQy14s4wPr+RZ+CcCqY+q9icqsxD6oRK8PEaYEbPx3JSUCPkZhz9Z9CdQo bhBhR2p+e7uA+/8GrS/isWQOiuYKagV2w8V0K/fR0FC1eYxc60jd7DjJY6OAzTfGTwIe ZMjvu7bxYm3kJa6QhGowTpXCO3gdga6JJrVGC++fUDx/702ro+MiUUD1kedRd3znint0 GZsKgbQGR5RahrOgyx1f6L+f1e1Wxd05k1XtvilpSDm5n/ELVBvzc9JC/ShrZ4rUVwi5 MAnRU+fJNhzW5tdp2FSLnkXa6jkUZY4CIZZBUda4EML0GsYekNP3e0i3fo7GcgifEoe7 v4Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697815545; x=1698420345; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2mZk0WVr6Xg0sCIQhm6espXC6FInpPUvKaLbGTuBdfw=; b=xBnHR3kfKDl56CJik4+ibyrHwRYW+weaUn63kxa/Nlt039+HsGmGbJoSU83tg8zfmk Pp7nuxYBgdGyHMYT+6EtJAsLcn+bvvuZGlraVEWZjgQiw3AQ/sYJNE9eMw11Nxhlbrsd ac6XPDURzrJiq/zp1TYRgbc7akWblzRNsn80j0brzoLno/COcD/Y5nTCO8qebp2LQ/Di bWkM90Lf1iFh8y672woTvanMjCGZzQsl3n629nzZZwlT6CewXPPuWl90uXhZBjo7I/TL c5SkQrZKyDsUIdR8zT+j6DJFkYGkgsJoyeyJ2kehR16bTk4YjIkLsdkB5inuPCwumSZ3 +b8g== X-Gm-Message-State: AOJu0YwwuvOPe+KRCd0HUIzccjtqFCkVLYycuUYYGGeCHQg8y2Zpqm9X 4aoxyz4E2pJw75Lu/oOPx+gPQaGwSqI= X-Google-Smtp-Source: AGHT+IFxqtEoRIYyH3qMBkrAmXe1hzS4V3GzYEuPfUUNenkIO+mCuiDupUj8ZnKYG1qvaD6KCXm56Q== X-Received: by 2002:adf:ef52:0:b0:32d:e4b9:4851 with SMTP id c18-20020adfef52000000b0032de4b94851mr1470848wrp.7.1697815545402; Fri, 20 Oct 2023 08:25:45 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f4-20020a5d50c4000000b0032da319a27asm1928471wrt.9.2023.10.20.08.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 08:25:45 -0700 (PDT) From: Simon Tournier In-Reply-To: <87lebyxs4y.fsf_-_@gnu.org> References: <20200630220913.14665-1-kuba@kadziolka.net> <87lebyxs4y.fsf_-_@gnu.org> Date: Fri, 20 Oct 2023 17:11:05 +0200 Message-ID: <874jilmira.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 4.38 X-Spam-Score: 4.38 X-Migadu-Queue-Id: 896A751A57 X-Migadu-Scanner: mx2.migadu.com X-TUID: u0acXaazlOK9 Hi Ludo, On Thu, 19 Oct 2023 at 22:40, Ludovic Court=C3=A8s wrote: >> +;;; >> +;;; Extend regexp objects with a pattern field. >> +;;; >> +(define-record-type >> + (%make-regexp* pat flag rx) >> + regexp*? >> + (pat regexp*-pattern) ;the regexp pattern, a string >> + (flag regexp*-flag) ;regexp flags >> + (rx regexp*-rx)) ;the compiled regexp object >> + >> +;;; Work around regexp implementation. >> +;;; This record allows to track the regexp pattern and then display it. >> +(define* (make-regexp* pat #:optional (flag regexp/extended)) > > I=E2=80=99m skeptical about the concrete benefits. I would not include i= t in > (guix build utils), or at least not in this patch series. > > (I tend to be super conservative about (guix build utils) because we > rarely get a chance to change it.) If I remember correctly, the record was introduced in #58660 [1]. Basically, if you have, (make-regexp "^gnu/packages/python(-.+|)\\.scm$") then you only have access to some #. Other said, you lost the human-readable "^gnu/packages/python(-.+|)\\.scm$" regexp pattern. The workaround just stores this human-readable regexp pattern. Later, it is thus possible to display it; for debugging or else. For the location of such feature, I do not have an opinion. For the concrete benefits, I have one. :-) Well, maybe the feature =E2=80=93 keep an access to the human-readable rege= xp pattern =E2=80=93 could be implemented on Guile-side. Or maybe there is another simpler way that I am not aware of? Cheers, simon 1: https://issues.guix.gnu.org/58660