all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 66618@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes.
Date: Wed, 25 Oct 2023 22:11:54 +0200	[thread overview]
Message-ID: <874jieea2d.fsf@lassieur.org> (raw)
In-Reply-To: <87mswab2pb.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 22 Oct 2023 20:30:08 -0400")

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

>> I don't think there is a need for `--to` automation in Guix repo because
>> it's something the user can automate in their own ~/.gitconfig (with
>> `includeIf`[0]).
>
> I often have single patches, or with series I need to send the cover
> letter first; just writing 'git send-email -1' is shorter
> than 'git send-email --to=guix-patches@gnu.org -1' :-).

Well, you can use a bash alias, a git send-email wrapper, your own
.gitconfig as I said...  There are a lot of solutions.

> I also often use patman (info "(u-boot) Patman patch manager") and
> there's no way to specify a --to from the command line (you use
> Series-to: NNNNN@debbugs.gnu.org as a git trailer after having received
> it for a cover letter), which would make things slightly more
> annoying...

Then you can also write "Series-to: guix-patches@gnu.org" as trailer for
the first patch and then change.

Or you can use git send-email --to for the first patch, and patman for
the remaining ones.

>> [0]: https://git-scm.com/docs/git-config#_conditional_includes
>
> ... by having to configure this in a way that matches all my Guix
> worktrees spread around :-).

If all your Guix worktrees are in the same directory, it's
straightforward.  Otherwise, it's just one line per git repository.
Something that's surely not a problem for you.

> I guess what I'm saying is that it provides value for me, and I'd expect
> for others, although I can see how it could generate surprise when you
> initially get your 'get send-email' foo wrong.

I'm sure it provides value for you but I don't think it does for others:
all I see is that it provides confusion.

We want a software, and tools, that are simple to use and to understand.
Please don't add too much things that are hard to maintain, hard to
understand, and with unexpected defaults.

Git send-email is used by a lot of projects apart from Guix.  And
newcomers often come from those projects, they don't expect weird
defaults and weird customizations.

> Perhaps we should more prominently mention that 'mumi send-email' should
> be used for first timers, as it's less likely to get things wrong using
> it?

I think git send-email is easy to use and to understand (if people don't
modify its default behavior).

Thanks,
Clément




  parent reply	other threads:[~2023-10-25 20:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 22:23 [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes Clément Lassieur
2023-10-19  1:34 ` Maxim Cournoyer
2023-10-19  9:46   ` Clément Lassieur
2023-10-19  1:36 ` Maxim Cournoyer
2023-10-19  9:37   ` Clément Lassieur
2023-10-20  1:54     ` Maxim Cournoyer
2023-10-20  8:42       ` Clément Lassieur
2023-10-20 14:06       ` Simon Tournier
2023-10-20 15:44         ` Maxim Cournoyer
2023-10-22 20:55           ` Clément Lassieur
2023-10-23  0:30             ` Maxim Cournoyer
2023-10-23  9:57               ` Simon Tournier
2023-10-23 14:17                 ` Maxim Cournoyer
2023-10-25 20:11               ` Clément Lassieur [this message]
2023-10-26  8:31                 ` Simon Tournier
2023-10-26 10:38                   ` bug#66618: " Clément Lassieur
2023-10-23  9:49           ` [bug#66618] " Simon Tournier
2023-10-23 14:28             ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jieea2d.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=66618@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.