From: Wilko Meyer <w@wmeyer.eu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Wilko Meyer <w@wmeyer.eu>, 67917@debbugs.gnu.org
Subject: [bug#67917] [PATCH 0/2] guix import cpan improvements
Date: Sat, 23 Dec 2023 12:49:07 +0100 [thread overview]
Message-ID: <874jg9w1ae.fsf@wmeyer.eu> (raw)
In-Reply-To: <87o7eh6xbp.fsf@gnu.org>
Hi Ludo,
Thanks for reviewing this so quickly!
Ludovic Courtès <ludo@gnu.org> writes:
> I think this doesn’t belong here: right now, ‘define-public’ is added
> when using ‘-r’ by ‘package->definition’ in (guix import utils). This
> is shared by most importers so we cannot just change it in a single
> importer.
This currently seems to be inconsistent among importers. crate and go
always add define-public independent of using '-r', while e.g. egg, gnu,
elpa etc. do not do that. I'll prepare a v2 of this patch series without
this change, as the cpan importer should stay at its default behaviour.
Speaking of '-r', the cpan importer doesn't offer recursively importing
packages. I could add this functionality to the cpan importer in v2 of
this patch series, WDYT?
> This one I’m not sure, but we should make sure importers are consistent
> as well.
Agreed.
--
Kind regards,
Wilko Meyer
w@wmeyer.eu
next prev parent reply other threads:[~2023-12-23 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 23:42 [bug#67917] [PATCH 0/2] guix import cpan improvements Wilko Meyer
2023-12-19 23:45 ` [bug#67917] [PATCH 1/2] import: cpan: Add 'license:' prefix to license matching Wilko Meyer
2023-12-19 23:45 ` [bug#67917] [PATCH 2/2] import: cpan: Add 'define-public' to package definition Wilko Meyer
2023-12-23 10:13 ` [bug#67917] [PATCH 0/2] guix import cpan improvements Ludovic Courtès
2023-12-23 11:49 ` Wilko Meyer [this message]
2024-01-08 16:33 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jg9w1ae.fsf@wmeyer.eu \
--to=w@wmeyer.eu \
--cc=67917@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.