From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 68180@debbugs.gnu.org,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: [bug#68180] [PATCH 1/4] gnu: emacs: Add awk, find, sed and sh to PATH wrapper.
Date: Sun, 31 Dec 2023 16:10:03 -0500 [thread overview]
Message-ID: <874jfyoz84.fsf@gmail.com> (raw)
In-Reply-To: <6b33be06b0ea3a9aa4e29b8c8a958150cc05a7e9.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 31 Dec 2023 20:13:06 +0100")
Hi Liliana,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Sonntag, dem 31.12.2023 um 11:59 -0500 schrieb Maxim Cournoyer:
>> Before this change, using Emacs in a pure environment, e.g. 'guix
>> shell --pure emacs', would cause problems such as:
>>
>> jka-compr-insert-file-contents: Uncompression program ‘sh’ not
>> found
>>
>> And other problems were found requiring the other tools. While the
>> above could be patched in place for 'sh', it seems more robust and
>> universally useful to have the commands appear on PATH, should other
>> Elisp modules want to call to these directly as well.
>>
>> * gnu/packages/emacs.scm (emacs-minimal) [arguments] <phases>: Adjust
>> the
>> wrap-emacs-paths phase to wrap additional inputs.
>> [inputs]: Add findutils, gawk and sed.
>> (%emacs-modules): Add (srfi srfi-26).
>>
>> Change-Id: Ifb4fe2fc12ddc9eae387adb3da3f7821fab78e65
>> ---
> We already have a phase to patch in the real path of /bin/sh where it's
> used. This appears to be an odd case that's missed.
I appreciate exactness, but it seems fragile to rely on nobody adding
new references or someone catching them as new Emacs modules get added
or changed :-).
My reasoning was that since Emacs already depends on bash, why not
ensure it'll always be found on PATH, by wrapping instead of
substituting.
Does it make sense?
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-12-31 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1704041948.git.maxim.cournoyer@gmail.com>
2023-12-31 16:59 ` [bug#68180] [PATCH 1/4] gnu: emacs: Add awk, find, sed and sh to PATH wrapper Maxim Cournoyer
2023-12-31 19:13 ` Liliana Marie Prikler
2023-12-31 21:10 ` Maxim Cournoyer [this message]
2024-01-01 7:33 ` Andrew Tropin via Guix-patches via
2024-01-02 2:07 ` Maxim Cournoyer
2024-01-02 7:00 ` Andrew Tropin via Guix-patches via
2024-01-02 16:34 ` Maxim Cournoyer
2024-01-19 3:17 ` bug#68180: " Maxim Cournoyer
2023-12-31 16:59 ` [bug#68180] [PATCH 2/4] build: perl: Accept Gexps for #:module-build-flags Maxim Cournoyer
2023-12-31 16:59 ` [bug#68180] [PATCH 3/4] gnu: perl-b-keywords: Update to 1.26 Maxim Cournoyer
2023-12-31 16:59 ` [bug#68180] [PATCH 4/4] gnu: Add emacs-pde Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jfyoz84.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=68180@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.