From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uEwfO4wAw2V3agAAe85BDQ:P1 (envelope-from ) for ; Wed, 07 Feb 2024 05:01:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id uEwfO4wAw2V3agAAe85BDQ (envelope-from ) for ; Wed, 07 Feb 2024 05:01:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm2 header.b=PpjCMO0K; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="U w5SnRL"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707278476; a=rsa-sha256; cv=none; b=pk6ndes9M0I3gPikV3WHs6A26z7S02JyzsxMDJoqkzrzbfB6SxP5BcwVxYXAqj7sLrIy5Y S/8YxwXLc1VaGRspYo1cV0IzIXVD1uKBpHNi12z2G7OACY8vwLNPYB37UmssbtADm4h1ok c93FgaS/OuGmphSVWqJNCZ0TiEUMpGjXJ6p+anL82LdeOMhiyRQUUdtatpqyPcrzKBNq8U XJhNkQ3/VaHmCyRop8mBMnPUL7JOrBzqeVmOdg/H/Izi0m9mjgV+9BEZ7q0RniKzQ0hwgB hTC1gJIugqPYKLSYIvpa8/G5Fp6DvdIjE2LZZjlQiLFPSYyuVl3+MSind9MCcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm2 header.b=PpjCMO0K; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="U w5SnRL"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707278476; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0ohcfSsFjGaQF8b9S2+8LpE1QStEKKbDj3AuaPOLbwQ=; b=b8N9a64cN/sO99KLPYV6f5Xl/tvOhCIf3c+6B5+qzhEGtFBl8MlvcKno4pTxVW23pPFN5a QtFBHqUWowhWzrin55cICvb3XLZZybA8ItAEESPpzEmPhCHi0TR3RGorGWRiCFMmZZBGkL e3ETNHsOYqgAzRKQEN/WhZ4ZEdppqvbtmTEfakEyu9loPFucOAxDiShsvCCQ9cJCMs5BLE tQGqOHBPWDPStaPCnJlYnDJpU2cCSjaJ9cFParpz6IGWbiAPzsIaP7YqGQ5/SNTNgjvNLp tGQLGarJmveYR4VW5UgdcJk4kk3Oq+gIPOeg3IBwxppY5rdpPeUUdl/WhD1nCg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E0AACEAA for ; Wed, 7 Feb 2024 05:01:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXZ7E-0002rj-5b; Tue, 06 Feb 2024 23:00:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXZ7A-0002oz-Um for guix-patches@gnu.org; Tue, 06 Feb 2024 23:00:48 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXZ7A-0006ag-M6 for guix-patches@gnu.org; Tue, 06 Feb 2024 23:00:48 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXZ7N-0001NU-UE for guix-patches@gnu.org; Tue, 06 Feb 2024 23:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Feb 2024 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67512 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67512@debbugs.gnu.org Received: via spool by 67512-submit@debbugs.gnu.org id=B67512.17072784115226 (code B ref 67512); Wed, 07 Feb 2024 04:01:01 +0000 Received: (at 67512) by debbugs.gnu.org; 7 Feb 2024 04:00:11 +0000 Received: from localhost ([127.0.0.1]:55524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXZ6Y-0001MC-QI for submit@debbugs.gnu.org; Tue, 06 Feb 2024 23:00:11 -0500 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]:36059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXZ6W-0001Kn-45 for 67512@debbugs.gnu.org; Tue, 06 Feb 2024 23:00:09 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 280FE1800081 for <67512@debbugs.gnu.org>; Tue, 6 Feb 2024 22:59:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Feb 2024 22:59:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707278387; x=1707364787; bh=0ohcfSsFjGaQF8b9S2+8LpE1QStEKKbDj3AuaPOLbwQ=; b= PpjCMO0KKFiLX0dbcDXJFk/CXUQWIWo8UGUoSoBcDqYv59t6RGDEaTVMEwbRseaa ZdydLsH0NTIJa3mfwEp5J4aD5j7uLErQ8SoeeD4Z135C9Fhpwb7axeQaiFGIXeav ytxqTEzPaxWrcLsytOL8XnLVOMuBj6ghNOrlCGK1n1gd+2t8QGSLTGP+KDHW724k w3+VMnAE3DWYIn9OWJZvJeuqX82Maq+VWSy4MogXx/oDXQm2l40wi/6IKhGycRtU jIFLPM29QaZGBgo5nznj9sWPsCmp+wH1WFVdW3eoEO4SdcGyWRIOjt93KDJa9REv W3Kr4ubCAvwLKYwtvks+GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707278387; x= 1707364787; bh=0ohcfSsFjGaQF8b9S2+8LpE1QStEKKbDj3AuaPOLbwQ=; b=U w5SnRLm7Fjt9wfpldBPnFbtftUAJYARhnNLbBs4YtF8Yqj4gBYT+VJLDMRKk/tp6 45oC9cvnpv2kBCtHGZE7PjFHtRbHwd4/8PqpgowqTWE659YMoMvzFrrXEyf1WKQl RAwfvOFlOPjEY5eE/+epDzspxIK4L25oMsFT3VJGqkxkHHom/ZGkd7WefvSTa9HI a1vVufU9u2NmEse4h+AB+JjnDTsVt9J5deuIPceY+fM6B8IWzOxS00P7duwhJoES V+378pZoSmAW7u7fy+1kXhxxz88ivmp6OorHhQnnU5Crk9X8k77m/Vk7vm6jtFYm fZwn66xxREMEk75oU/bjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddugdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvufffjgfkgggtgfesthhqre dttderjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeehteffudelgeehhedvhfdvvdfhtdfhffelleelke evgeffueetgffgfefhuefhveenucffohhmrghinhepmhhoiihilhhlrgdrohhrghdpghhn uhdrohhrghdpnhhuvghvohguvghvvghlrdgtohhmpdhgihhtlhgrsgdrtghomhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvght rhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <67512@debbugs.gnu.org>; Tue, 6 Feb 2024 22:59:47 -0500 (EST) References: <87y1c92kfx.fsf@meson> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure Date: Tue, 06 Feb 2024 15:29:22 -0800 In-reply-to: Message-ID: <874jekzzyl.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -5.68 X-Migadu-Queue-Id: 5E0AACEAA X-Migadu-Spam-Score: -5.68 X-TUID: EKMe2MGSwMIY Herman Rimm writes: > On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: >> >> Herman Rimm writes: >> >> > Librewolf should not link to addons.mozilla.org, using this=20 >> > build phase >> > from torbrowser: >> > >> >> What=E2=80=99s the rationale for not using addons.mozilla.org? >> >> gnuzilla.gnu.org appears to be broken, it=E2=80=99s serving an Apache=20 >> default page, >> as if the vhost isn=E2=80=99t configured. Does the browser request=20 >> some path within >> that domain, which does work? I=E2=80=99m not familiar with the=20 >> mechanism used for >> this. > > Apologies, the URL is: https://gnuzilla.gnu.org/mozzarella/. It=20 > is used > because addons.mozilla.org contains nonfree extensions, from=20 > [1]: > I=E2=80=99ll look into this and see what it takes to adjust. >>> LibreWolf disables DRM by default[1], so I don=E2=80=99t believe this=20 >>> flag is >>> necessary. I can confirm that it=E2=80=99s disabled in the browser=20 >>> built from >>> the package definition without this flag. >>> >> >>I looked a bit deeper into this. There are actually no=20 >>EME-related >>configuration options in Librewolf at all, either to enable or=20 >>disable it. >>It=E2=80=99s always disabled. > > Interesting, I applied the patch series onto 551d013, built=20 > librewolf, > removed ~/.librewolf and ~/.mozilla, started librewolf and went=20 > to > about:config, where 'browser.eme.ui.enabled' has the default=20 > value > 'true', so I can see and toggle the checkbox for 'play=20 > DRM-controlled > content' in about:preferences. I don't know why=20 > 'browser.eme.ui.enabled' > is 'true' by default for me, but I think adding --disable-eme=20 > will set > the default to 'false', like it is in the icecat-minimal=20 > about:config. > I completely misunderstood the various settings and systems at=20 play here, which I believe led us to talk past each other. The=20 summary of the situation, best as I can tell, is this: - EME support: a build setting controlling whether the browser=20 supports *any kind* of encrypted media playback. - Widevine support: one kind of DRM, implemented as an EME plugin. - `browser.eme.ui.enabled' browser preference: controls whether=20 the UI for DRM is visible. Controls visibility *only*. A=20 browser build without EME will still show this if=20 `browser.eme.ui.enabled' is `true' (but the control does=20 nothing). A browser build *with* EME (and one or more DRM=20 plugins) can have this set to `false' and still play DRM=E2=80=99d=20 content. - The checkbox within the EME UI: On browsers built with EME and=20 DRM plugin(s), controls whether that is allowed to be used. On=20 browsers without EME+Widevine, does nothing. The default configuration of a clean install of a stock LibreWolf=20 build is: - The browser is built with EME and Widevine support - The UI to enable DRM is visible. - Within that UI, the checkbox is unchecked (meaning DRM is not=20 enabled). I have rebuilt with --disable-eme and confirmed that even with=20 browser.eme.ui.enabled=3Dtrue and the "Play DRM-controlled content"=20 box checked, the resulting build cannot play DRM=E2=80=99d streams. This=20 was actually somewhat difficult, since I don=E2=80=99t use or have access=20 to any commercial streaming service, but I found a website which=20 lets you test DRM playback, and used that to compare behavior of a=20 LibreWolf binary obtained from the project with my build. Should=20 anyone else want to verify, or need to do this kind of testing,=20 the site is: https://www.nuevodevel.com/nuevo/showcase/drm > When running grep in a Librewolf repo [3] for the aformentioned=20 > terms, > only the --disable-jxl configure flag is modified in toolkit/ > moz.configure, so I don't think the Librewolf developers disable=20 > EME.I > am not sure though, I don't want to rebuild librewolf with the > --disable-eme flag to look for the difference. > The "source" repo contains patches and orchestration to produce=20 the LibreWolf source tarball. The setting which disables DRM by=20 default is in their settings repo[1], which is a submodule. The=20 likely scenario is that you cloned the repo with the eminently=20 reasonable assumption that this would produce a full copy of its=20 contents, and grepped them. Unfortunately, Git submodules are=20 deeply unreasonable, and do not work this way -- you must perform=20 manual actions to populate or update them, which is very easy to=20 forget, especially if one doesn=E2=80=99t work with them regularly. LibreWolf=E2=80=99s specific wording is "We disable DRM by default," which= =20 I believe is accurate, but fails to capture the fullness of the=20 situation, i.e. that DRM support is included, but dormant. So=20 you=E2=80=99re also correct that they don=E2=80=99t disable EME -- the disa= bling=20 happens above that layer. This was not clear to me in the earlier=20 discussions. I=E2=80=99ve removed EME from the build, and will work on replacing=20 Mozilla=E2=80=99s addons with Mozarella, then send an updated patch=20 series. Separately, I=E2=80=99ve also managed to unbundle libpng,=20 libwebp, and nss; fixed the glxinfo utility program; and=20 eliminated a redundant copy of the main binary. Thanks, =E2=80=94 Ian [1]:=20 https://gitlab.com/librewolf-community/settings/-/blob/ba238a9ca6bfd509f31e= 6eb4a45c14c11b7ef7fe/librewolf.cfg#L258-263