bug#71952: documentation inaccuracy?

bug#71952: documentation inaccuracy?

[chris]

This section of the documentation seems innacurate,

https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-home.html#index-home-generations

> When specifying a negative value such as -1, you must precede it with -- to prevent it from being parsed as an option. For example:
>
> guix home switch-generation -- -1

Running the same command here gives the following result

> $ guix home switch-generation -- -1
>
> guix home: error: -1: extraneous command

Instead, `guix home roll-back` and `guix home switch-generation +1` can be used.

bug#71952: documentation inaccuracy?

[jgart via Bug reports for GNU Guix]

hi chris,

would you like to send a patch fixing this?

hi simon,

wdyt?
-- 
all the best,
jgart

bug#71952: documentation inaccuracy?

[Simon Tournier]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi,

>> $ guix home switch-generation -- -1
>> guix home: error: -1: extraneous command

Indeed, the command-line parser seems incorrect and inconsistent with
the documentation.

The culprit seems the procedure ’parse-args’ from ’guix-home’ command
inside the module (guix scripts home).

Hum, I guess something as the attached patch should fix the issue.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 422 bytes --]

diff --git a/guix/scripts/home.scm b/guix/scripts/home.scm
index b4c82d275f..5c39e83983 100644
--- a/guix/scripts/home.scm
+++ b/guix/scripts/home.scm
@@ -682,6 +682,8 @@ (define-command (guix-home . args)
       (match rest
         (() opts)
         (("--") opts)
+        (("--" n)
+         (alist-cons 'argument n opts))
         (("--" command ...)
          (match (assoc-ref opts 'action)
            ('container

[-- Attachment #3: Type: text/plain, Size: 22 bytes --]


WDYT?

Cheers,
simon

bug#71952: documentation inaccuracy?

[jgart via Bug reports for GNU Guix]

LGTM, Andrew WDYT?

--
jgart

bug#71952: documentation inaccuracy?

[Andrew Tropin via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]


> LGTM, Andrew WDYT?

Didn't try the patch, but overall idea seems right.

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]