From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KLoHDEclwWaBCAEAe85BDQ:P1 (envelope-from ) for ; Sat, 17 Aug 2024 22:33:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id KLoHDEclwWaBCAEAe85BDQ (envelope-from ) for ; Sun, 18 Aug 2024 00:33:43 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="kZT1KYt/"; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm2 header.b="mq/szVoe"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="e kdD3rn"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1723934023; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xSZXZ4wHW9qwGaWcGowjMyw1G8IzQqKIlo5V8whEu/4=; b=l1JV5xJZc3iRzbAe4fTvq+1wubbvkUkYJXflPNXAgCsEKE1bbp6EXMOsw0bgAt5ulXW+ny aXBX8xBuQYdhXUT6VjUxinP8ZjsW3H0e97aOwvBq9h+y7apsjGL494zxmapueXF5hI/9yH I4+sIKtGsOmyO+a+KzQJ/rjlOhM0L/nfO+Rav9itPwKFgR0nhc7VDuF62kiI5pH9PmODNO y3KSW7Ky/8RlT+gB14W/vbPNrg4ycl67KYefCkcN3L8tGgIzmwjzthOnQzK7yNpxVTOoj4 dmOSFQ7T9s9ZoCZ61CKsgpi9e9GAIT4U86cTD7Bolhz6JlgEsqb3tfGPGPUPUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1723934023; a=rsa-sha256; cv=none; b=PdnGzMS6hMR3Zps9Bb2vNtDh2xkJh3oz2IWsoTdF7ffq1224b/T7ZEwyljVVlv5YWAZTNc sy5RQ4DVY5ZFiLGNwKxG2gAbaKN8Hke8NEnwbTDlVpy01PMX+HU9e7OUqyoSzoXwSElGQ+ ZyjNKMXaLIDWoZa8IV9ZEx1QvnGwQxHTaud0tHFsbyqYgX5UX+bVC8xTMVtn1q2okFQwj5 dQRNGPzA4NPp9zmkWZEBXl5BXE3p5X5eg8QvDEtdgUKNrC6yqAmO08ikoOnOBXGEFhR99W GINZaZqcbvlWZiGTJ83PJQdKZqAPyIjym5iu3AVKMno3vIT64eCAiAu+L1pc/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="kZT1KYt/"; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm2 header.b="mq/szVoe"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="e kdD3rn"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFA663A041 for ; Sun, 18 Aug 2024 00:33:42 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfRzB-000830-Nx; Sat, 17 Aug 2024 18:33:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfRz9-00082W-U1 for guix-patches@gnu.org; Sat, 17 Aug 2024 18:33:23 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfRz9-0006tE-LH for guix-patches@gnu.org; Sat, 17 Aug 2024 18:33:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:In-reply-to:Date:From:References:To:Subject; bh=xSZXZ4wHW9qwGaWcGowjMyw1G8IzQqKIlo5V8whEu/4=; b=kZT1KYt/yiAVl/pSgRupuA89xB5ne1j5RHTO8ECGflZrnnAB4W9cYAkS61ehSwnkzFQd7n44/nbF0i1A1mymUXYhyR5fS21opQAMoBNZtHMQArAQHBmKG37cj4SHhdED/JXv6C+D1wBf2QldIhm4URGwU+CB7VhqPh8Q6yuGbFYM1Z1RwoM7Xn7YeEBoDspu1P+6ufzpSevBUh6yCnR8amMbtReER+MCj8quCSX/lb8KQtxYa4HqEPhKDnW9WlOrcuDqohJDAfw2AlfRgV+B+zhDT47LM/Xm4lz0NHZvM4l/j9pF+17uEJWkeRe7mwFqtnn47sLujojMtOg1aTsTrg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfRzm-00075j-DO for guix-patches@gnu.org; Sat, 17 Aug 2024 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72265] [PATCH 0/1] Fix hardware acceleration support for librewolf Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Aug 2024 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72265 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nikita Domnitskii Cc: 72265@debbugs.gnu.org Received: via spool by 72265-submit@debbugs.gnu.org id=B72265.172393403527244 (code B ref 72265); Sat, 17 Aug 2024 22:34:02 +0000 Received: (at 72265) by debbugs.gnu.org; 17 Aug 2024 22:33:55 +0000 Received: from localhost ([127.0.0.1]:55052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfRze-00075M-KX for submit@debbugs.gnu.org; Sat, 17 Aug 2024 18:33:54 -0400 Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]:37331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfRzc-000756-BL for 72265@debbugs.gnu.org; Sat, 17 Aug 2024 18:33:53 -0400 Received: from phl-compute-08.internal (phl-compute-08.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 41F111145481; Sat, 17 Aug 2024 18:33:07 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Sat, 17 Aug 2024 18:33:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1723933987; x=1724020387; bh=xSZXZ4wHW9qwGaWcGowjMyw1G8IzQqKIlo5V8whEu/4=; b= mq/szVoe5v8IpZ4rYHpuGvYaKcDLOovNW7uYVsCPd2lzHfubfqlGMO4o7/IRHgiR 1cSe5bmDKBxiY7z0q75A7b+KtEFvJ/ovd9dto0kwoL1+UGVD2u9IeSPnnlnDuBip v498eqtjPG72KCnojRSlTN7MPphvAjFY5tHBwQoc0Wl23hYq9FPAkPBAHM8GQ+nG IM1kzdSnG+JVmBuNhgeuLli4q1bcAdcIHf4Q7WRPStEX6+y/TVO22GnEJbzAyfv9 Y3rpMW54NXwPQrZuR6hiKUsxnYTOnaHomJ9yG4jdpfw2qF2YBxOvNxpXlJUTKaPg M6rxsqWmZF9k/aOjaOTmjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723933987; x= 1724020387; bh=xSZXZ4wHW9qwGaWcGowjMyw1G8IzQqKIlo5V8whEu/4=; b=e kdD3rnMp9rxRcaeurvz1fyxRpHGcfXoFZLGhtKxCk5pVeNzcdXlrrON4qh5lfbuC LH/DH438TbF+qp/Q4sK0I5E5cZ4zshcCiZwtloauKMDSZgKv1xDTYQ7UuBjgfe1+ 90GBMAgChQyqhDyk+iv/CmY+uNpl0czYTL/zkOTkfHgMMYiGCq7ESlysWdu7KrYG LkkLoHBofSvVsjDAP33iNzOksXXqvgOcz4NpMbtIZdTIaxW0Odj6qtaYHUqA5kwQ rpcCdeaUfWMYYhr2LExfdzW9vCSAWo90HGW8980tzgpa3j1PQI2C8uHou1pmK7sg BWpsJFkt8psrc+N9gDRHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudduuddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreej necuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqne cuggftrfgrthhtvghrnhephfelvedtieeffffggeeivdeukedutedtveejfffhleeileef heeggfdugfeiuefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhnsggprhgtphhtthhopedvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopeejvddvieehseguvggssghughhsrdhgnh hurdhorhhgpdhrtghpthhtohepnhhikhhithgrseguohhmnhhithhskhhiihdrmhgv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Aug 2024 18:33:06 -0400 (EDT) References: <87cymutnnr.fsf@meson> <87ed7a5etn.fsf@domnitskii.me> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure Date: Sat, 17 Aug 2024 15:20:02 -0700 In-reply-to: <87ed7a5etn.fsf@domnitskii.me> Message-ID: <874j7i6aqm.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.11 X-Spam-Score: -7.11 X-Migadu-Queue-Id: CFA663A041 X-Migadu-Scanner: mx11.migadu.com X-TUID: 5kRhC6F3YZDY Hi Nikita, Nikita Domnitskii writes: > Ian Eure writes: > >> Since a lot of system config stuff ends up in there, and Guix=20 >> doesn=E2=80=99t >> have a good way to manage secrets, it feels risky to me to open=20 >> it up. > > Is it really an issue? Any program on your system already does=20 > that, > why LW any different? It's a good enough solution for NixOS/FF=20 > not sure > why we have to do something different here. > I think it=E2=80=99s worth considering. While any program can read the=20 store, few of them run the huge volume of untrusted code that a=20 web browser does. That said, I=E2=80=99m okay with this approach. Ideally, I=E2=80=99d like = it to=20 be a stopgap solution, but it=E2=80=99s a clear improvement on the current= =20 situation. However, there are two changes I=E2=80=99d like to see: 1. Please remove the source patching from `make-librewolf-source'=20 and move it into the librewolf package definition.=20 `make-librewolf-source' is intended to produce a source tarball=20 identical to upstream, and isn=E2=80=99t a good place to be adding=20 Guix-specific patches. 2. Use the `substitute*' procedure instead of a patch file. I=20 maintain LibreWolf in my personal channel first, then contribute=20 patches to Guix, and the patch file facility doesn=E2=80=99t work outside=20 the main Guix repository. I work this way because I=E2=80=99m not a Guix=20 committer, and would like to run the latest version of LibreWolf.=20 Guix is often several versions behind due to intractable delays in=20 patch review. With those two changes, your patch has my +1. Though as noted, I=20 cannot commit it, since I don=E2=80=99t have those privileges. >> The approach in LW is taken directly from the Firefox packages=20 >> in=20 >> Nonguix -- can you reproduce your problem with that packages? > > I can and it never worked for me. I used to mantain my LW=20 > package > definition[1] where I put neccesary paths to LD_LIBRARY_PATH,=20 > but that > solution very specific to my setup and would not work as a=20 > general one. > Would you please file a bug report with them? I=E2=80=99d be interested=20 to hear what they have to say on the subject. Thanks, =E2=80=94 Ian