From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UAe6ApqB6WYZhgEA62LTzQ:P1 (envelope-from ) for ; Tue, 17 Sep 2024 13:18:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UAe6ApqB6WYZhgEA62LTzQ (envelope-from ) for ; Tue, 17 Sep 2024 15:18:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WstKiiRE; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=GuVceisa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726579097; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pJsCxmaRlgcfJWr/yUXgYhi2zfRG1muti/FsrlpgCsc=; b=JiP1Syab0CHAc7sle9x4hTguU1gDwtIKEUpQQFCHDBbTOeG6eQSt24nOWDzT1jVp0fHNm6 NVtpf6PIqbu3HGhrs5oEaqNxplF4hMMOTAXJPr8LFskVd2RZ1tn7igTtZqqbnbtq6UB11D CJLXxqZ3oCIUY6pneXRgtfbY/icjG0F6Xh6H3aYVLN/aqNpE6ucfyflRiLvOKjrOwZAGer 7eywP4BH381EUVC9G7vIqxT6WgG/kVxEFawTNdkmkaQSJywEHwuC9QKVPTwc50iyuKPnnJ RVtjzV4sXm8u4rRnx00vNFuBJZEWVEOh6ffHDvPoStbtKZ6Ym189Me6NRXHy4A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WstKiiRE; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=GuVceisa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726579097; a=rsa-sha256; cv=none; b=qrfJYsusLkUZMxTbgBBXAsK5WtYpvuHKfq9ZBXzF32w/9XZzj6jDvXrodPGIDehYpQtlaz sdgNyXhgqgTS+59x3dvotXO5LOfchJzhnZoUg9iW3tfOUaSSLN5QBjcq2hH6IaHQ0gW1UQ qxW2ofG4O/ZOsOrODYU+K7I4TsJ+Ve8tK9uJorMjejHbBU67IyyqJpXpey+ec7XWCiqXah HWuHW3/HFjheHoH9ZadUut2egB5VyiatYV+5Fy5zmTUvsRsguMEfVXYrat9EKA9PSbmNdb stj7TkFR7J+7NLLNf0yWSNwmapZPzLi0wMzNM0FuFiM2TRmTEV5SMWZDkQT1uw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9078F88C7 for ; Tue, 17 Sep 2024 15:18:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqY5X-0001di-Le; Tue, 17 Sep 2024 09:17:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqY5T-0001dB-CO for guix-patches@gnu.org; Tue, 17 Sep 2024 09:17:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqY5T-0007sp-2n for guix-patches@gnu.org; Tue, 17 Sep 2024 09:17:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pJsCxmaRlgcfJWr/yUXgYhi2zfRG1muti/FsrlpgCsc=; b=WstKiiRE8pi7f7SUX4CSdkxo8Fm/L3Jv+n9V9nt7AZKuzFgCPceyQ1hXmah0o4YEC/x1j0MlM9sPpFdSYvPrr65LF19bINs5ptHqMtjTJJQ0hE0B7IABkpWojWQaC3v0OmIEU+IVqjpJvf+UcfwAzmWe01LpqjOT8wmQYeMvZb4OLj3FHzPbpTB3vgRbIVhZRuJ6/rVelfmLuuoXHWhVPP/pJkf3sgj2oqr6L980XtgZ89KuigoVRPO4wXFlSxvnsa4/8emSZ5y7kdi06eCwIGd3aEH2VcQPCa6jSB3zLk+IL6ZxPZG4oj0mc3JzIHtB2mvE9bv+GSHvZHTTCXCEhQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqY5h-0003wn-NX for guix-patches@gnu.org; Tue, 17 Sep 2024 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73170] [PATCH] gnu: Add cl-async-process. Resent-From: Guillaume Le Vaillant Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Sep 2024 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 73170@debbugs.gnu.org Received: via spool by 73170-submit@debbugs.gnu.org id=B73170.172657902315053 (code B ref 73170); Tue, 17 Sep 2024 13:18:01 +0000 Received: (at 73170) by debbugs.gnu.org; 17 Sep 2024 13:17:03 +0000 Received: from localhost ([127.0.0.1]:54216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY4l-0003uj-18 for submit@debbugs.gnu.org; Tue, 17 Sep 2024 09:17:03 -0400 Received: from mout01.posteo.de ([185.67.36.65]:38383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqY4i-0003u5-RP for 73170@debbugs.gnu.org; Tue, 17 Sep 2024 09:17:01 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8E11F240027 for <73170@debbugs.gnu.org>; Tue, 17 Sep 2024 15:16:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726578998; bh=dKn+JA60wTCIbwabOUfQ97eHwWAsSjihYSD0yKuj9EA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=GuVceisaw1mfHTrB5b7zo/V2mn6zYBFcXT2aU+oQ1u+1LremeGymqH2tzg4IuH2dy id3Zow5IgymEKdpz5KdeshvzyeRjOg2zDFVw6TsjFZvoKQUDti0aJMbdvwwRCMBM7k k+jyQ62X3MRDatqEYlsaSmsmJJAQYTd9iTcmqdz9RFThgjsDvSzH3UAk3crSDJISSP qVC0PXPEPR7Zm1aJIK2R16VUiIlEJDePlmjtc0kU+iRrR+oFcJlbzYop58ZLwTBEZf MglEqdTyLx/gDmTEbzTD01hOiSbsHVeCV8MJs3R7Az7eg/wkfTM8v9lNf646pEFIfY WIAoorB1issAg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X7MkF5pylz6twM; Tue, 17 Sep 2024 15:16:37 +0200 (CEST) From: Guillaume Le Vaillant In-Reply-To: <21b927da240259b41c3ceee1a246019095509740.1725985244.git.jgart@dismail.de> (jgart@dismail.de's message of "Tue, 10 Sep 2024 11:20:44 -0500") References: <21b927da240259b41c3ceee1a246019095509740.1725985244.git.jgart@dismail.de> Date: Tue, 17 Sep 2024 13:16:36 +0000 Message-ID: <874j6es9mz.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.31 X-Spam-Score: -7.31 X-Migadu-Queue-Id: 9078F88C7 X-Migadu-Scanner: mx10.migadu.com X-TUID: hdyLEVBEBGsI --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi. jgart skribis: > +(define (async-process-origin commit name version) > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/lem-project/async-process") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1m2sfgfg6c0gqqy1pqsahsiw3j25y473mfw7sx0akkqbhwhm7mjb")) > + (modules '((guix build utils))) > + (snippet > + ;; Delete precompiled artifacts. > + `(begin > + (for-each delete-file-recursively > + (list "static" > + "static_old0001-819cbf6")))))) I don't think this function is necessary; and the sha256 hash is fixed here but it would in fact depend on the commit passed as argument to the function. > +(define async-process-c-sources > + (let ((commit "9690530fc92b59636d9f17d821afa7697e7c8ca4") > + (revision "0")) > + (package > + (name "async-process-c-sources") > + (version (git-version "0.0.1" revision commit)) > + (source (async-process-origin commit name version)) > + (build-system gnu-build-system) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (replace 'bootstrap > + (lambda _ > + (invoke "libtoolize") > + (invoke "aclocal") > + (invoke "autoheader") > + (invoke "automake" "-a") > + (invoke "autoconf")))))) > + (native-inputs (list autoconf automake libtool)) > + (home-page "https://github.com/lem-project/async-process") > + (synopsis "Asynchronous process execution for Common Lisp") > + (description "This library provides an asynchronous process > +execution mechanism for Common Lisp.") > + (license license:expat)))) So I would rather put the 'origin' field in this package building the C library. And as the purpose of this package is to build the libasyncprocess library, I would just call it "libasyncprocess". > +(define-public sbcl-async-process > + (let ((commit "9690530fc92b59636d9f17d821afa7697e7c8ca4") > + (revision "0")) > + (package > + (name "sbcl-async-process") > + (version (git-version "0.0.1" revision commit)) > + (source (async-process-origin commit name version)) > + (build-system asdf-build-system/sbcl) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-paths > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "src/async-process.lisp" > + (("libasyncprocess\\.so") > + (search-input-file inputs > + "/lib/async-process/libasyncproces= s.so")))))))) > + (inputs (list async-process-c-sources sbcl-cffi)) > + (home-page "https://github.com/lem-project/async-process") > + (synopsis "Asynchronous process execution for Common Lisp") > + (description "This library provides an asynchronous process > +execution mechanism for Common Lisp.") > + (license license:expat)))) Then the sbcl-async-process package could be simplified by inheriting from the libasyncprocess package, and modifying the 'name', 'build-system', 'inputs' and 'arguments' fields. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZumBNQ8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j98jwD8CX1SzVp/8GuAypsPptIHsD2q4oIittJc6VL6 nHm+PYABAIc4yMwb5yNatCFG2nNqZK3dQPk6t0X5/UVQOnV7D3Ee =JBOI -----END PGP SIGNATURE----- --=-=-=--