From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aOWgB2ZYQmcRDwEAe85BDQ:P1 (envelope-from ) for ; Sat, 23 Nov 2024 22:34:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aOWgB2ZYQmcRDwEAe85BDQ (envelope-from ) for ; Sat, 23 Nov 2024 23:34:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=P7sh4cwj; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Qnu9Lqe0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732401253; a=rsa-sha256; cv=none; b=i5B68lGuDpJ5bObvEN/Uy6r2ntM/WAD2KVzY+sjyqz9LqdMdBiu6aQZlMF6mXyc0kX/BpR Mk6/tK/cdeNvvxGtXTYUKxGjfZb82ScMxv1ZpsNBXIeOft4/ZWble9ud+p6rHyxkntavag 7l/5i3OLI4lL+J6befqI6H8RhTo9z7od626Clmm6c/VHW65amcNNcqnraavRt1yGH3tj4b 1Es1q7d1DS/tkGcZWe+O2NwGr2ARxXNBjbzkNnEpTeX5VpQVKZSVmD9jwMwmJPu3CLihm5 bAeLbHdoWkiQ4hZfkPA6JPf5Oqz09KJKkJtMu41adxNdj+GuTF1pGFXwCSH6zw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=P7sh4cwj; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Qnu9Lqe0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732401253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mRyVX5SBvohFcQUAxlEkZ8Ex0epJvnR7QYYeFptol+M=; b=W0au4Ki7+I+Z0aqmjgC8b16Pv/YQYNwnmj7N5iAdYzn25qOo4EahLSF2MPG5n9Rot7jEDz 7z8B+kudp8S7moLRk6yx/y1/DehJwHvyxthahG+8UdlScEW4f7l9lnChQxF1Fkm/ZwOweR lq8rnbhhv471qMC9pE00JX6xMAYNBh3gc5FjQO9YaYGHEKYHGrP/5pyWUAAbadkYxnh7LV DMuWM7Q0J0X75gvYJo0ZHUfVtaL5UlLMOT2Y8Zp6WsukytkXbCQsFvE2MWo6oz2ic59QN3 BG5nE3XAVqJtR1T3qcP63DrYOXbbB+iuPjZ63P3WQnsWd1D3b6ato8WsbQzTKg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE96C65F83 for ; Sat, 23 Nov 2024 23:34:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEyhX-0007m5-TK; Sat, 23 Nov 2024 17:34:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEyhW-0007lw-DD for guix-patches@gnu.org; Sat, 23 Nov 2024 17:34:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEyhW-00031Q-56 for guix-patches@gnu.org; Sat, 23 Nov 2024 17:34:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=mRyVX5SBvohFcQUAxlEkZ8Ex0epJvnR7QYYeFptol+M=; b=P7sh4cwjvu72Utk9WHq5q5xiJQmygLQti+wnKEnPze4X7z3vU0v8xjqC+mB51eeMrQTEgJtnk78pkZqQ5Y+KNiYDBTq0dH73wbLqxh7lPKJ8vdiZMvyfBdu4TA5lHzi5vWlxSkVm3FLO9BYV7Qefzj2Eq+F7xn32vVL/VeYIvXbIfA9I7RmvQYODkXkvPvC2GrD2XF/zCJd7h4RfbZ5NH6/+dAiK3CCxDhU6AvAqpDg6PCLvfP0rc627bv4Nf3k905khOTxd5itHF6sgKaP1VHMIfaF+dS+hNIoKl7PJyApdJPRS11LoAQ7dz3shNTO8WeZwrbYB/5HgmwUp7OBQdQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEyhV-0002Ko-U2 for guix-patches@gnu.org; Sat, 23 Nov 2024 17:34:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74495] [PATCH 00/16] gnu: Add go-github-com-noahgorstein-jqp. References: In-Reply-To: Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Nov 2024 22:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74495 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74495@debbugs.gnu.org Cc: "Artyom V. Poptsov" Received: via spool by 74495-submit@debbugs.gnu.org id=B74495.17324012058922 (code B ref 74495); Sat, 23 Nov 2024 22:34:01 +0000 Received: (at 74495) by debbugs.gnu.org; 23 Nov 2024 22:33:25 +0000 Received: from localhost ([127.0.0.1]:59796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEygu-0002Jp-Kt for submit@debbugs.gnu.org; Sat, 23 Nov 2024 17:33:25 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:51638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEygs-0002Jh-OC for 74495@debbugs.gnu.org; Sat, 23 Nov 2024 17:33:23 -0500 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-431548bd1b4so29176885e9.3 for <74495@debbugs.gnu.org>; Sat, 23 Nov 2024 14:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732401142; x=1733005942; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mRyVX5SBvohFcQUAxlEkZ8Ex0epJvnR7QYYeFptol+M=; b=Qnu9Lqe0IXV+p5F4VGCnQ3vJsBtTMSz+8L3AabirppxNui3PSvPjjAOf8z6PuQGWv5 zUIGJbnQPVLD5apUBluK8Vu5LouxZDZNgoVX47n0OQyLqiHilbK3/Sp0R+MWJ1Pfl6fA RkWvYhcunLxzDPZwMWUeeC2GV2xUT/YzyCEO2IAgCxUaOb8Zi7u2dhZ7kZJvJo+9TIMV hq6Z5CUaq+vFVgD4iu3v8+8egwBj6HkfENs93E7sN3jzMKeM5ZMBoaqfTGQnVmw5+ss+ SKPRL2V+2LvswSba9xbBK39WDxm3rvXfeVOxAuRBXjog42Xtcbhgp/LZPyYXOKjeLRZb jzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732401142; x=1733005942; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mRyVX5SBvohFcQUAxlEkZ8Ex0epJvnR7QYYeFptol+M=; b=pHU7FrMLlN0InNl5Y5y1vddgCcYOWGn0LBWoU2arQUjemq2hF3+cvhn1MiYcO/DQbH 7gadC9OpTzPlcnwpsl6CBpRFdbEZA1uL35H+OfLMRVGB8dxE95HDs8Ew7orjwCiMikhs g7itbEtMPi++B5QPUwusNpCmoOey2E7EErI3qJvt9d8E41xL2vIljisTsXMf+ufFyf/j tVPrP6TUXA57P6d5baL913U++bRR4O5k0HLpMHu/UALXZg8eYTFtxW+E/Ve10uzANDjF 3Gw/UBMVgPGACGoaPMkuCsw2FJ2Ey1am4/WuEWHfU4295RP84zOMxTnnuXS0RDU8AHnF 8Leg== X-Gm-Message-State: AOJu0Yy2rMFwjRmYH6ee17ldBUph9ya6do3VX1BoQyfsDZiz3IsxDT94 hT+KLmnj2gf+W2hKI5zSPSowkY3yI1bKPMADU1AJ9HsHI6pHkEwz X-Gm-Gg: ASbGncvOMswsFGc4fedbXULE4oHhMZzA9TzUYWMFgtYBz3Mpd2GIHTa0UTGp4Q/yEPV Cc/58NPYsL661ovCv3CHIVPPpme6ue1b9ZSDO4hd2IPjq1MToGiyBIbuZE2mbnQHOcs90A9KMIt +O66txGS+ypjlUmmJc840M96Jx0pRxAC514A9F/3ba8AB0DWIfGKVwCiB3Qs+n+3aebT3JOZunT 0lxrBJRsv4prXNffecjYL37ZGohiWaXgEYMWEiQ/54aS+oOtd41/az8qFtJA3W3wVSYbOTP2Kle 8bX7HJhFNrqgV0UOAGJGdzjhMA== X-Google-Smtp-Source: AGHT+IGvL7dZJkGcaPYkosuQXYoCfWMj9VFX/SFtiGrNBpVgpktPkkA79Tam3Y+crW2CeimTZnLNRA== X-Received: by 2002:a05:600c:3d8d:b0:432:d82d:6a6c with SMTP id 5b1f17b1804b1-433ce4e74f4mr72254635e9.30.1732401141730; Sat, 23 Nov 2024 14:32:21 -0800 (PST) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433cde9800fsm73360105e9.40.2024.11.23.14.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2024 14:32:20 -0800 (PST) From: Sharlatan Hellseher Date: Sat, 23 Nov 2024 22:32:16 +0000 Message-ID: <874j3xoa33.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.44 X-Spam-Score: -6.44 X-Migadu-Queue-Id: AE96C65F83 X-Migadu-Scanner: mx12.migadu.com X-TUID: kv7zkpjaSboC --=-=-= Content-Type: text/plain Hi, Thanks for the patches! After a intial review of package placement there are some comments: Better sutes for (gnu packages xdisorg), there are golang packages, and it prevent importing xdisorg and xorg into golang-xyz. --8<---------------cut here---------------start------------->8--- +(define-public go-github-com-atotto-clipboard --8<---------------cut here---------------end--------------->8--- What's going on here, maybe repack go-github-com-kylelemons-godebug to include all modules, wdyt? --8<---------------cut here---------------start------------->8--- +(define-public go-github-com-kylelemons-godebug-pretty --8<---------------cut here---------------end--------------->8--- Please, no new packages to golang.scm --8<---------------cut here---------------start------------->8--- +(define-public go-github-com-aymanbagabas-go-udiff --8<---------------cut here---------------end--------------->8--- Please follow the style ;-) --8<---------------cut here---------------start------------->8--- + (native-inputs (list go-github-com-kylelemons-godebug + go-github-com-kylelemons-godebug-pretty)) + (arguments + (list + #:import-path "github.com/sahilm/fuzzy")) --8<---------------cut here---------------end--------------->8--- Nixe to see that new go-import works with #:subdir! --8<---------------cut here---------------start------------->8--- +(define-public go-github-com-charmbracelet-x-exp-golden --8<---------------cut here---------------end--------------->8--- There is a guile funcion for that: --8<---------------cut here---------------start------------->8--- + #:modules '((guix build go-build-system) + (guix build utils)) + #:phases #~(modify-phases %standard-phases + (add-before 'check 'fix-tests + (lambda _ + (invoke "chmod" + "-R" + "+w" + "src/github.com/charmbracelet/x/exp/golden")))))) --8<---------------cut here---------------end--------------->8--- For any like this, please sort alphabetically: --8<---------------cut here---------------start------------->8--- + (propagated-inputs (list go-github-com-sahilm-fuzzy + go-github-com-rivo-uniseg + go-github-com-muesli-termenv + go-github-com-mattn-go-runewidth + go-github-com-lucasb-eyer-go-colorful + go-github-com-dustin-go-humanize + go-github-com-charmbracelet-x-exp-golden + go-github-com-charmbracelet-x-ansi + go-github-com-charmbracelet-lipgloss + go-github-com-charmbracelet-harmonica + go-github-com-charmbracelet-bubbletea + go-github-com-atotto-clipboard + go-github-com-makenowjust-heredoc)) --8<---------------cut here---------------end--------------->8--- It might be a good case for dedicated issues to split library out of binary, I can take it. --8<---------------cut here---------------start------------->8--- [PATCH 10/16] gnu: go-github-com-itchyny-gojq: Install the library. --8<---------------cut here---------------end--------------->8--- Description might need to be a little longer than synopsis, check the code docstring sometimes modules documented well outside of README: --8<---------------cut here---------------start------------->8--- + (synopsis "Terminal utilities and helpers") + (description + "@code{term} defines terminal utilities.") + (license license:expat))) --8<---------------cut here---------------end--------------->8--- Feel free to move to coresponded golang-* module: --8<---------------cut here---------------start------------->8--- [PATCH 12/16] gnu: go-github-com-charmbracelet-bubbletea: Remove input labels. [PATCH 15/16] gnu: go-github-com-charmbracelet-bubbletea: Update to 1.2.3. --8<---------------cut here---------------end--------------->8--- Let's keep it in web to reduce module cyles: --8<---------------cut here---------------start------------->8--- [PATCH 16/16] gnu: Add go-github-com-noahgorstein-jqp. --8<---------------cut here---------------end--------------->8--- In v2 I'll check license and package internals -- Thanks, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmdCV/AACgkQdtcnv/Ys 0rX0PA/+MXyjZhHv43Sj2w0or55r9fqDzGQyAY9iHgQFRgJ9xl1NBWZuWZx+HT+J Y+DJs3OiXtaUtXU86Q4BHTYudZRWfEO8PxmpgmU1tdyPAjXgif1IfI8wYyfCrPOO KKqCY2DybSejfnBqG0/mrIwRWE7G735sq7mFtC+yn4k6u/1F1VwLrbRUyFIFXidR 3L+OLyP7eZC2LKqhW2W/fH6BTBtVlmKhOuZrgIjhcf0YI7z/+Y4qxrUez6pSQTBY JV37UdpYoxovzbdHOTsTXxGPYbOG7TEEB5AkCR+j/cDKJ5p/bZNcy43eO+vaNtQb aX1LicclTtxB/RnkhXSw/96hHuy0Z7n3kMvWeuK4GmUXiSGyB4+nixwXkpG2L8I+ Ex2C3yqPVauHfNaqTBCv7tzOjWp6pL0LKZpwCNqkzkIioYjpmsyliIBFTl1CKJaJ Jko0Tm94u6PX7dlLOj3yXSRitv7Pwc9k2O1C8WrYVUKQ/ujyVTzJenF2AXdhhRJV eqWHn05x2ZUIEh/WMDcsdIp/kNysD2dQAT9WyD/PkJzCnA5vWTIi2Enhyr10Bku0 bfR54e0Fbh3L+ge/FnL8lWRVAtayulpGhrxNgCPCswFOT/53agy1QL2qGgz8TYKG KvOPals0ciR9d7CfrJQNZVoKWs95JxANpaKgqYL9BUNoMKnaUhw= =Cs9u -----END PGP SIGNATURE----- --=-=-=--